From d3f5a4aee7ff3d195568f884e9e5c7ed6e72a038 Mon Sep 17 00:00:00 2001
From: "Maira Salazar (srma)" <srma@odoo.com>
Date: Tue, 2 Apr 2024 14:14:30 +0200
Subject: [PATCH] [IMP] base: display only company name in duplicate Tax ID
 warning

When creating a new company from a move, if the tax ID is repeated, a warning is displayed.
The warning includes the company name, address and VAT, if those have been added. In this case,
address is shown in an extra line, which looks broken.

This commit removes additional partner information by updating the context,
displaying only the partner name.

It also slightly rewords the warning, from "are you sure to create a new one?" to
"are you sure you want to create a new one?".

To replicate the issue:
1. Create an invoice
2. Click on the empty field next to Customer, type a new name and click "Create and edit..."
3. Add a Tax ID that is already in use (e.g. US12345673)
4. Warning of duplicate Tax ID shows, displaying company name, address and VAT

task-3829641

closes odoo/odoo#160373

Signed-off-by: Quentin De Paoli <qdp@odoo.com>
---
 odoo/addons/base/views/res_partner_views.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index a3fab22fe2f..7e6134a3151 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -167,10 +167,10 @@
             <field name="arch" type="xml">
                 <form string="Partners">
                 <div class="alert alert-warning oe_edit_only" role="alert" name="warning_tax" invisible="not same_vat_partner_id">
-                  A partner with the same <span><span class="o_vat_label">Tax ID</span></span> already exists (<field name="same_vat_partner_id"/>), are you sure to create a new one?
+                  A partner with the same <span><span class="o_vat_label">Tax ID</span></span> already exists (<field name="same_vat_partner_id" context="{'show_address': False, 'show_vat': False}"/>), are you sure to create a new one?
                 </div>
                 <div class="alert alert-warning oe_edit_only" role="alert" name="warning_company" invisible="not same_company_registry_partner_id">
-                  A partner with the same <span><span class="o_vat_label">Company Registry</span></span> already exists (<field name="same_company_registry_partner_id"/>), are you sure to create a new one?
+                  A partner with the same <span><span class="o_vat_label">Company Registry</span></span> already exists (<field name="same_company_registry_partner_id" context="{'show_address': False, 'show_vat': False}"/>), are you sure to create a new one?
                 </div>
                 <sheet>
                     <div class="oe_button_box" name="button_box"/>