From d3e462b279e9ecd24bf78d0707e2c297e48bff8a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@odoo.com>
Date: Fri, 25 Jan 2019 13:03:55 +0000
Subject: [PATCH] [FIX] website_slides: fix statistics computation

Statistics computation section is a bit broken as some variables are
incorrectly defined or propagated.

This commit is linked to task ID 1933820 and PR #30553.
---
 .../website_slides/static/src/js/slides_share.js  | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/addons/website_slides/static/src/js/slides_share.js b/addons/website_slides/static/src/js/slides_share.js
index cc10629e191..1dfaa3aee41 100644
--- a/addons/website_slides/static/src/js/slides_share.js
+++ b/addons/website_slides/static/src/js/slides_share.js
@@ -55,8 +55,8 @@ sAnimations.registry.websiteSlidesShare = sAnimations.Class.extend({
         defs.push(new ShareMail(this).attachTo($('.oe_slide_js_share_email')));
 
         if ($('div#statistic').length) {
-            var slideURL = $('div#statistic').attr('slide-url');
-            var socialURLs = {
+            this.slideURL = $('div#statistic').attr('slide-url');
+            this.socialURLs = {
                 linkedin: 'https://www.linkedin.com/countserv/count/share?url=',
                 twitter: 'https://cdn.api.twitter.com/1/urls/count.json?url=',
                 facebook: 'https://graph.facebook.com/?id=',
@@ -64,9 +64,9 @@ sAnimations.registry.websiteSlidesShare = sAnimations.Class.extend({
             };
         }
 
-        _.each(socialURLs, function (value, key) {
-            self._updateStatistics(key, slideURL);
-        });
+            _.each(this.socialURLs, function (value, key) {
+                self._updateStatistics(key, self.slideURL);
+            });
 
         return $.when.apply($, defs);
     },
@@ -81,9 +81,10 @@ sAnimations.registry.websiteSlidesShare = sAnimations.Class.extend({
      * @param {string} slide_url
      */
     _updateStatistics: function (socialSite, slideURL) {
+        var self = this;
         if (socialSite === 'gplus') {
             $.ajax({
-                url: this.social_urls['gplus'],
+                url: self.socialURLs['gplus'],
                 type: 'POST',
                 dataType: 'json',
                 contentType: 'application/json',
@@ -108,7 +109,7 @@ sAnimations.registry.websiteSlidesShare = sAnimations.Class.extend({
             });
         } else {
             $.ajax({
-                url: this.social_urls[socialSite] + slideURL,
+                url: self.socialURLs[socialSite] + slideURL,
                 dataType: 'jsonp',
                 success: function (data) {
                     var shareCount = (socialSite === 'facebook' ? data.shares : data.count) || 0;