From d2f30d110920a8f380ffd8826424a23c8eff298c Mon Sep 17 00:00:00 2001 From: Benoit Socias Date: Mon, 25 Oct 2021 11:42:27 +0000 Subject: [PATCH] [FIX] web_editor: avoid error popup when saving incomplete link dialog Before this commit saving an incomplete link dialog triggered the display of a stacktrace error popup. After this commit saving is cancelled when an attempt at saving an incomplete link dialog is done. The incorrect fields already did display their error status. task-2675252 closes odoo/odoo#80043 X-original-commit: 47f0596233c2d8a09d91cdfae117aa3f595bb6bf Signed-off-by: Quentin Smetz (qsm) --- .../web_editor/static/src/js/wysiwyg/widgets/link_dialog.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js b/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js index 0accebd253a..4aecbe1c381 100644 --- a/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js +++ b/addons/web_editor/static/src/js/wysiwyg/widgets/link_dialog.js @@ -197,6 +197,10 @@ const LinkDialog = Dialog.extend({ */ save: function () { this.linkWidget.save(); + if (!this.linkWidget.final_data) { + // Invalid form content: do not proceed with save. + return; + } this.final_data = this.linkWidget.final_data; return this._super(...arguments); },