From d2e5e8b8834ebfa1a0c585d77273200451390e92 Mon Sep 17 00:00:00 2001
From: Kartik Chavda <kcv@odoo.com>
Date: Wed, 14 Jun 2023 08:58:12 +0000
Subject: [PATCH] [FIX] hr_timesheet: fix visibility of `My Timesheet` menu for
 timesheet user

Steps:
- Install timesheet.
- Give user a `user: own timesheets` access.
- Open timesheet app.

Issue:
- `My Timesheet` menu is not visible and `Reporting` is visible
but timesheet user should be able to see `My Timesheet` menu not
`Reporting` menu.

Cause:
- Both `My Timesheet` menus are under that `Timesheets` menu which
has appover group set on it but one of then should be outside of
that menu and missing group on `Reporting` menu.

Fix:
- Move one of `My Timesheet` menu outside to display it for timesheet
user and add approver group on `Reporting` menu.

task-3369534

closes odoo/odoo#125303

X-original-commit: 065227b05a9666798b918fe26ae9c4828ba53a8f
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
---
 addons/hr_timesheet/views/hr_timesheet_menus.xml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/addons/hr_timesheet/views/hr_timesheet_menus.xml b/addons/hr_timesheet/views/hr_timesheet_menus.xml
index f6f5cd87554..9f2d9c28589 100644
--- a/addons/hr_timesheet/views/hr_timesheet_menus.xml
+++ b/addons/hr_timesheet/views/hr_timesheet_menus.xml
@@ -6,6 +6,11 @@
               groups="group_hr_timesheet_user"
               web_icon="hr_timesheet,static/description/icon_timesheet.png"
     >
+        <menuitem id="timesheet_menu_activity_user"
+                  name="My Timesheets"
+                  groups="group_hr_timesheet_user"
+                  action="act_hr_timesheet_line"
+        />
         <menuitem id="menu_hr_time_tracking"
                   name="Timesheets"
                   groups="group_hr_timesheet_approver"
@@ -16,11 +21,6 @@
                       groups="group_hr_timesheet_approver"
                       action="act_hr_timesheet_line"
             />
-            <menuitem id="timesheet_menu_activity_user"
-                      name="My Timesheets"
-                      groups="group_hr_timesheet_user"
-                      action="act_hr_timesheet_line"
-            />
             <menuitem id="timesheet_menu_activity_all"
                       name="All Timesheets"
                       action="timesheet_action_all"
@@ -29,6 +29,7 @@
         </menuitem>
         <menuitem id="menu_timesheets_reports"
                   name="Reporting"
+                  groups="group_hr_timesheet_approver"
                   sequence="99"
         >
             <menuitem id="menu_timesheets_reports_timesheet"