From d24e12de9ffe2b733300e116dd26b64c464a369d Mon Sep 17 00:00:00 2001 From: "Amit Bhavsar (Open ERP)" Date: Thu, 27 Jun 2013 16:30:29 +0530 Subject: [PATCH] [Imp] improve code in hr-contract. bzr revid: amb@tinyerp.com-20130627110029-k8y7s191i80hsaua --- addons/hr_contract/hr_contract.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/addons/hr_contract/hr_contract.py b/addons/hr_contract/hr_contract.py index 3c5ba066d61..d74253b5d53 100644 --- a/addons/hr_contract/hr_contract.py +++ b/addons/hr_contract/hr_contract.py @@ -89,12 +89,13 @@ class hr_contract(osv.osv): } def onchange_employee_id(self, cr, uid, ids, employee_id, context=None): - if employee_id: - emp_obj = self.pool.get('hr.employee').browse(cr, uid, employee_id, context=context) - if emp_obj.job_id: - return {'value': {'job_id': emp_obj.job_id.id}} + if not employee_id: return {'value': {'job_id': False}} - return False + emp_obj = self.pool.get('hr.employee').browse(cr, uid, employee_id, context=context) + job_id = False + if emp_obj.job_id: + job_id = emp_obj.job_id.id + return {'value': {'job_id': job_id}} def _check_dates(self, cr, uid, ids, context=None): for contract in self.read(cr, uid, ids, ['date_start', 'date_end'], context=context):