From d1eb6089fda3725a88af3b3eaf426d03e6855dc6 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Wed, 10 Jun 2020 12:24:17 +0000
Subject: [PATCH] [IMP] website: define ir_attachment as type url when possible

Storing attachment in database (when not specified as an url attachment) copies
the given file in the filestore.  When not necessary, this should be avoided to reduce
the databases footprint (and their backups).

On a given instance, the gain is minor, but on servers with hundreds of databases and/or
backups, the impact is noticeable, leading to an economy of scale.
---
 addons/website/data/website_data.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/website/data/website_data.xml b/addons/website/data/website_data.xml
index b9e21640add..c7ed6fa16b8 100644
--- a/addons/website/data/website_data.xml
+++ b/addons/website/data/website_data.xml
@@ -250,8 +250,8 @@
             <field name="public" eval="True"/>
             <field name="name">business_conference.jpg</field>
             <field name="res_model">ir.ui.view</field>
-            <field name="type">binary</field>
-            <field name="datas" type="base64" file="website/static/src/img/library/business_conference.jpg"/>
+            <field name="type">url</field>
+            <field name="url">/website/static/src/img/library/business_conference.jpg</field>
         </record>
         <record id="website.library_image_01" model="ir.attachment">
             <field name="public" eval="True"/>