From d187fa7bf82089905dba2572e2c0711c132b3236 Mon Sep 17 00:00:00 2001 From: "P. Christeas" Date: Mon, 17 Jan 2011 23:31:08 +0200 Subject: [PATCH] ir_cron: some port to pythonic logging bzr revid: p_christ@hol.gr-20110117213108-u0k7n9y4xmtudvnk --- bin/addons/base/ir/ir_cron.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/bin/addons/base/ir/ir_cron.py b/bin/addons/base/ir/ir_cron.py index e7b1a541f0c..aa95bacfb1d 100644 --- a/bin/addons/base/ir/ir_cron.py +++ b/bin/addons/base/ir/ir_cron.py @@ -41,6 +41,10 @@ _intervalTypes = { } class ir_cron(osv.osv, netsvc.Agent): + """ This is the ORM object that periodically executes actions. + + Note that we use the netsvc.Agent()._logger member. + """ _name = "ir.cron" _order = 'name' _columns = { @@ -74,7 +78,7 @@ class ir_cron(osv.osv, netsvc.Agent): try: for this in self.browse(cr, uid, ids, context): str2tuple(this.args) - except: + except Exception: return False return True @@ -90,8 +94,7 @@ class ir_cron(osv.osv, netsvc.Agent): try: f(cr, uid, *args) except Exception, e: - self._logger.notifyChannel('timers', netsvc.LOG_ERROR, "Job call of self.pool.get('%s').%s(cr, uid, *%r) failed" % (model, func, args)) - self._logger.notifyChannel('timers', netsvc.LOG_ERROR, tools.exception_to_unicode(e)) + self._logger.exception("Job call of self.pool.get('%s').%s(cr, uid, *%r) failed" % (model, func, args)) def _poolJobs(self, db_name, check=False): @@ -135,9 +138,7 @@ class ir_cron(osv.osv, netsvc.Agent): self.setAlarm(self._poolJobs, next_call, db_name, db_name) except Exception, ex: - logger = netsvc.Logger() - logger.notifyChannel('cron', netsvc.LOG_WARNING, - 'Exception in cron:'+str(ex)) + self._logger.warning('Exception in cron:', exc_info=True) finally: cr.commit()