From d0722fb38ae3675ef9e567c81ca2b4858afd4ce0 Mon Sep 17 00:00:00 2001
From: "Theo VINCENT (thvi)" <thvi@odoo.com>
Date: Thu, 31 Aug 2023 10:28:16 +0200
Subject: [PATCH] [FIX] point_of_sale: modify config opened session

Since 605943b5eaafe7e9224f0e7fb4fbdd020102c7a5, the modification of a POS config while a session is open with that config is prevented with the error message "Unable to modify this PoS Configuraton because you can't modify Payment Methods while a session is open".

Steps to reproduce:
 - Open a POS session
 - Open the settings page of the POS config of the opened session
 - For example, enable "Set Maximum Difference", then click on the "Save" button.

The error message "Unable to modify this PoS Configuraton because you can't modify Payment Methods while a session is open" is shown.

The fix consists in replacing the "invisible" property of the payment methods field by "readonly", as it was before the 605943b5eaafe7e9224f0e7fb4fbdd020102c7a5 commit.

closes odoo/odoo#133711

Task-id: 3487621
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
---
 addons/point_of_sale/views/res_config_settings_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/point_of_sale/views/res_config_settings_views.xml b/addons/point_of_sale/views/res_config_settings_views.xml
index 035036acb99..32a5be4f98f 100644
--- a/addons/point_of_sale/views/res_config_settings_views.xml
+++ b/addons/point_of_sale/views/res_config_settings_views.xml
@@ -52,7 +52,7 @@
                         </block>
                         <block title="Payment" id="pos_payment_section">
                             <setting id="payment_methods_new" string="Payment Methods" help="Payment methods available">
-                                <field name="pos_payment_method_ids" colspan="4" widget="many2many_tags" invisible="pos_has_active_session" required="pos_company_has_template" options="{'no_create': True}" />
+                                <field name="pos_payment_method_ids" colspan="4" widget="many2many_tags" readonly="pos_has_active_session" required="pos_company_has_template" options="{'no_create': True}" />
                                 <div>
                                     <button name="%(action_payment_methods_tree)d" icon="oi-arrow-right" type="action" string="Payment Methods" class="btn-link"/>
                                 </div>