From cfbd8d1adaa04901c2792f7a3ec02bd66aab3dbd Mon Sep 17 00:00:00 2001 From: David Beguin Date: Mon, 11 Feb 2019 09:12:56 +0000 Subject: [PATCH] [IMP] gamification, website_forum : apply various improvements - add menu to configure ranks in gamification tools because was missing - move admin karma data in gamification : karma linked to gamification and not forum anymore - fix rank computation : next_rank_id could never been recomputed correctly if rank are created in a karma ascending order. Task ID : 1922159 PR #30988 --- addons/gamification/models/res_users.py | 6 ++++-- addons/gamification/views/gamification_karma_rank_views.xml | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/addons/gamification/models/res_users.py b/addons/gamification/models/res_users.py index 40bc7442b69..8f59f6c7591 100644 --- a/addons/gamification/models/res_users.py +++ b/addons/gamification/models/res_users.py @@ -74,8 +74,10 @@ class Users(models.Model): old_rank = user.rank_id for i in range(0, len(ranks)): if user.karma >= ranks[i]['karma_min']: - user.rank_id = ranks[i]['rank'].id - user.next_rank_id = ranks[i - 1]['rank'].id if i > 0 else False + user.write({ + 'rank_id': ranks[i]['rank'].id, + 'next_rank_id': ranks[i - 1]['rank'].id if i > 0 else False + }) break if old_rank != user.rank_id: user._rank_changed() diff --git a/addons/gamification/views/gamification_karma_rank_views.xml b/addons/gamification/views/gamification_karma_rank_views.xml index 1e12a283cce..f09d516ca88 100644 --- a/addons/gamification/views/gamification_karma_rank_views.xml +++ b/addons/gamification/views/gamification_karma_rank_views.xml @@ -67,5 +67,7 @@ + +