From ce1a4a2ee00fadf3c09b9dc77baa74c83375331b Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Fri, 30 Jun 2023 11:48:07 +0000 Subject: [PATCH] [IMP] base: deprecate global rules ir.model.access rules without group will now log a warning Part-of: odoo/odoo#125216 --- odoo/addons/base/models/ir_model.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/odoo/addons/base/models/ir_model.py b/odoo/addons/base/models/ir_model.py index 7602f002be2..6e54dbbc01a 100644 --- a/odoo/addons/base/models/ir_model.py +++ b/odoo/addons/base/models/ir_model.py @@ -1941,6 +1941,13 @@ class IrModelAccess(models.Model): @api.model_create_multi def create(self, vals_list): self.call_cache_clearing_methods() + for ima in vals_list: + if "group_id" in ima and not ima["group_id"] and any([ + ima.get("perm_read"), + ima.get("perm_write"), + ima.get("perm_create"), + ima.get("perm_unlink")]): + _logger.warning("Rule %s has no group, this is a deprecated feature. Every access-granting rule should specify a group.", ima['name']) return super(IrModelAccess, self).create(vals_list) def write(self, values):