From cde4a9c647ec285a9a26d6dca5fef483900ff51d Mon Sep 17 00:00:00 2001 From: Patrick Hoste Date: Wed, 29 Mar 2023 08:08:58 +0000 Subject: [PATCH] [IMP] base: improve user password wizard This commit fix the users login disappearance when hitting 'Change Password' button without setting a password by adding force_save parameter. It also removes the required parameter from the new_passwd field so we don't get a vague missing field error when one omits to enter a new password. Instead of an error, we just leave the old password for the missing lines. Task-3184727 Part-of: odoo/odoo#112806 --- odoo/addons/base/models/res_users.py | 5 ++--- odoo/addons/base/views/res_users_views.xml | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/odoo/addons/base/models/res_users.py b/odoo/addons/base/models/res_users.py index 48d832ab76c..a9804cf53fc 100644 --- a/odoo/addons/base/models/res_users.py +++ b/odoo/addons/base/models/res_users.py @@ -1876,9 +1876,8 @@ class ChangePasswordUser(models.TransientModel): def change_password_button(self): for line in self: - if not line.new_passwd: - raise UserError(_("Before clicking on 'Change Password', you have to write a new password.")) - line.user_id._change_password(line.new_passwd) + if line.new_passwd: + line.user_id._change_password(line.new_passwd) # don't keep temporary passwords in the database longer than necessary self.write({'new_passwd': False}) diff --git a/odoo/addons/base/views/res_users_views.xml b/odoo/addons/base/views/res_users_views.xml index 3cf096fda24..7e2df572041 100644 --- a/odoo/addons/base/views/res_users_views.xml +++ b/odoo/addons/base/views/res_users_views.xml @@ -39,8 +39,8 @@ - - + +