diff --git a/addons/hr_expense/__manifest__.py b/addons/hr_expense/__manifest__.py index d1f3ab98f1d..ac6f28bc91e 100644 --- a/addons/hr_expense/__manifest__.py +++ b/addons/hr_expense/__manifest__.py @@ -3,7 +3,7 @@ { - 'name': 'Expense Tracker', + 'name': 'Expenses', 'version': '2.0', 'category': 'Human Resources', 'sequence': 95, diff --git a/addons/hr_expense/data/hr_expense_data.xml b/addons/hr_expense/data/hr_expense_data.xml index 45dcc2738f9..e6a8337204a 100644 --- a/addons/hr_expense/data/hr_expense_data.xml +++ b/addons/hr_expense/data/hr_expense_data.xml @@ -52,6 +52,12 @@ Expense report paid + + Responsible + hr.expense.sheet + Changes of responsible + + Expenses To Approve diff --git a/addons/hr_expense/models/__init__.py b/addons/hr_expense/models/__init__.py index c600bfe5848..af1e04d2dd2 100644 --- a/addons/hr_expense/models/__init__.py +++ b/addons/hr_expense/models/__init__.py @@ -1,5 +1,6 @@ # -*- coding: utf-8 -*- +from . import hr_employee from . import account_move_line from . import hr_department from . import hr_expense diff --git a/addons/hr_expense/models/hr_employee.py b/addons/hr_expense/models/hr_employee.py new file mode 100644 index 00000000000..c4388789e15 --- /dev/null +++ b/addons/hr_expense/models/hr_employee.py @@ -0,0 +1,12 @@ +# -*- coding: utf-8 -*- +# Part of Odoo. See LICENSE file for full copyright and licensing details. + +from odoo import fields, models + +class Employee(models.Model): + _inherit = 'hr.employee' + + expense_manager_id = fields.Many2one( + 'res.users', string='Expense Responsible', + domain=lambda self: [('groups_id', 'in', self.env.ref('hr_expense.group_hr_expense_manager').id)], + help="User responsible of expense approval. Should be Expense Manager.") diff --git a/addons/hr_expense/models/hr_expense.py b/addons/hr_expense/models/hr_expense.py index d5b238664ac..39d062820a9 100644 --- a/addons/hr_expense/models/hr_expense.py +++ b/addons/hr_expense/models/hr_expense.py @@ -29,13 +29,13 @@ class HrExpense(models.Model): def _default_account_id(self): return self.env['ir.property'].get('property_account_expense_categ_id', 'product.category') - name = fields.Char("Expense Description", readonly=True, required=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}) - date = fields.Date("Expense Date", readonly=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, default=fields.Date.context_today) - employee_id = fields.Many2one('hr.employee', string="Employee", required=True, readonly=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, default=_default_employee_id) - product_id = fields.Many2one('product.product', string='Product', readonly=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, domain=[('can_be_expensed', '=', True)], required=True) + name = fields.Char('Description', readonly=True, required=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}) + date = fields.Date(readonly=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}, default=fields.Date.context_today, string="Date") + employee_id = fields.Many2one('hr.employee', string="Employee", required=True, readonly=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}, default=_default_employee_id) + product_id = fields.Many2one('product.product', string='Product', readonly=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}, domain=[('can_be_expensed', '=', True)], required=True) product_uom_id = fields.Many2one('product.uom', string='Unit of Measure', required=True, readonly=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, default=_default_product_uom_id) - unit_amount = fields.Float("Unit Price", readonly=True, required=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, digits=dp.get_precision('Product Price')) - quantity = fields.Float(required=True, readonly=True, states={'draft': [('readonly', False)], 'refused': [('readonly', False)]}, digits=dp.get_precision('Product Unit of Measure'), default=1) + unit_amount = fields.Float("Unit Price", readonly=True, required=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}, digits=dp.get_precision('Product Price')) + quantity = fields.Float(required=True, readonly=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}, digits=dp.get_precision('Product Unit of Measure'), default=1) tax_ids = fields.Many2many('account.tax', 'expense_tax', 'expense_id', 'tax_id', string='Taxes', states={'done': [('readonly', True)], 'post': [('readonly', True)]}) untaxed_amount = fields.Float("Subtotal", store=True, compute='_compute_amount', digits=dp.get_precision('Account')) total_amount = fields.Monetary("Total", compute='_compute_amount', store=True, currency_field='currency_id', digits=dp.get_precision('Account')) @@ -45,16 +45,17 @@ class HrExpense(models.Model): company_currency_id = fields.Many2one('res.currency', string="Report Company Currency", related='sheet_id.currency_id', store=True) analytic_account_id = fields.Many2one('account.analytic.account', string='Analytic Account', states={'post': [('readonly', True)], 'done': [('readonly', True)]}, oldname='analytic_account') account_id = fields.Many2one('account.account', string='Account', states={'post': [('readonly', True)], 'done': [('readonly', True)]}, default=_default_account_id, help="An expense account is expected") - description = fields.Text() + description = fields.Text('Notes...', readonly=True, states={'draft': [('readonly', False)], 'reported': [('readonly', False)], 'refused': [('readonly', False)]}) payment_mode = fields.Selection([ ("own_account", "Employee (to reimburse)"), ("company_account", "Company") - ], default='own_account', states={'done': [('readonly', True)], 'post': [('readonly', True)], 'submitted': [('readonly', True)]}, string="Payment By") - attachment_number = fields.Integer("Number of Attachments", compute='_compute_attachment_number') + ], default='own_account', states={'done': [('readonly', True)], 'post': [('readonly', True)], 'submitted': [('readonly', True)]}, string="Paid By") + attachment_number = fields.Integer('Number of Attachments', compute='_compute_attachment_number') state = fields.Selection([ ('draft', 'To Submit'), - ('reported', 'Reported'), - ('done', 'Posted'), + ('reported', 'Submitted'), + ('approved', 'Approved'), + ('done', 'Paid'), ('refused', 'Refused') ], compute='_compute_state', string='Status', copy=False, index=True, readonly=True, store=True, help="Status of the expense.") sheet_id = fields.Many2one('hr.expense.sheet', string="Expense Report", readonly=True, copy=False) @@ -68,6 +69,8 @@ class HrExpense(models.Model): expense.state = "draft" elif expense.sheet_id.state == "cancel": expense.state = "refused" + elif expense.sheet_id.state == "approve" or expense.sheet_id.state == "post": + expense.state = "approved" elif not expense.sheet_id.account_move_id: expense.state = "reported" else: @@ -120,8 +123,8 @@ class HrExpense(models.Model): @api.multi def unlink(self): for expense in self: - if expense.state in ['done']: - raise UserError(_('You cannot delete a posted expense.')) + if expense.state in ['done', 'approved']: + raise UserError(_('You cannot delete a posted or approved expense.')) return super(HrExpense, self).unlink() @api.model @@ -161,6 +164,7 @@ class HrExpense(models.Model): if len(self.mapped('employee_id')) != 1: raise UserError(_("You cannot report expenses for different employees in the same report!")) return { + 'name': _('New Expense Report'), 'type': 'ir.actions.act_window', 'view_mode': 'form', 'res_model': 'hr.expense.sheet', @@ -470,8 +474,8 @@ class HrExpenseSheet(models.Model): ], string='Status', index=True, readonly=True, track_visibility='onchange', copy=False, default='submit', required=True, help='Expense Report State') employee_id = fields.Many2one('hr.employee', string="Employee", required=True, readonly=True, states={'submit': [('readonly', False)]}, default=lambda self: self.env['hr.employee'].search([('user_id', '=', self.env.uid)], limit=1)) address_id = fields.Many2one('res.partner', string="Employee Home Address") - payment_mode = fields.Selection([("own_account", "Employee (to reimburse)"), ("company_account", "Company")], related='expense_line_ids.payment_mode', default='own_account', readonly=True, string="Payment By") - responsible_id = fields.Many2one('res.users', 'Validation By', readonly=True, copy=False, states={'submit': [('readonly', False)]}) + payment_mode = fields.Selection([("own_account", "Employee (to reimburse)"), ("company_account", "Company")], related='expense_line_ids.payment_mode', default='own_account', readonly=True, string="Paid By") + user_id = fields.Many2one('res.users', 'Manager', readonly=True, copy=False, states={'submit': [('readonly', False)]}, track_visibility='onchange', oldname='responsible_id') total_amount = fields.Monetary('Total Amount', currency_field='currency_id', compute='_compute_amount', store=True, digits=dp.get_precision('Account')) company_id = fields.Many2one('res.company', string='Company', readonly=True, states={'submit': [('readonly', False)]}, default=lambda self: self.env.user.company_id) currency_id = fields.Many2one('res.currency', string='Currency', readonly=True, states={'submit': [('readonly', False)]}, default=lambda self: self.env.user.company_id.currency_id) @@ -502,6 +506,7 @@ class HrExpenseSheet(models.Model): def _onchange_employee_id(self): self.address_id = self.employee_id.address_home_id self.department_id = self.employee_id.department_id + self.user_id = self.employee_id.expense_manager_id @api.multi @api.constrains('expense_line_ids') @@ -553,6 +558,8 @@ class HrExpenseSheet(models.Model): return 'hr_expense.mt_expense_refused' elif 'state' in init_values and self.state == 'done': return 'hr_expense.mt_expense_paid' + elif 'user_id' in init_values: + return 'hr_expense.mt_expense_responsible' return super(HrExpenseSheet, self)._track_subtype(init_values) def _get_users_to_subscribe(self, employee=False): @@ -583,6 +590,10 @@ class HrExpenseSheet(models.Model): MailFollowers = self.env['mail.followers'] for partner in users.mapped('partner_id'): values['message_follower_ids'] += MailFollowers._add_follower_command(self._name, [], {partner.id: None}, {})[0] + + if values.get('user_id') and values.get('user_id') != employee.user_id.id: + resp_partner = self.env['res.users'].browse(values['user_id']) + values['message_follower_ids'] += MailFollowers._add_follower_command(self._name, [], {resp_partner.partner_id.id: None}, {})[0] # -------------------------------------------- # Actions @@ -633,7 +644,8 @@ class HrExpenseSheet(models.Model): def approve_expense_sheets(self): if not self.user_has_groups('hr_expense.group_hr_expense_user'): raise UserError(_("Only HR Officers can approve expenses")) - self.write({'state': 'approve', 'responsible_id': self.env.user.id}) + responsible_id = self.user_id.id or self.env.user.id + self.write({'state': 'approve', 'user_id': responsible_id}) @api.multi def paid_expense_sheets(self): diff --git a/addons/hr_expense/models/res_config_settings.py b/addons/hr_expense/models/res_config_settings.py index a142834e17a..c07d364dd7d 100644 --- a/addons/hr_expense/models/res_config_settings.py +++ b/addons/hr_expense/models/res_config_settings.py @@ -9,7 +9,7 @@ class ResConfigSettings(models.TransientModel): expense_alias_prefix = fields.Char('Default Alias Name for Expenses') use_mailgateway = fields.Boolean(string='Let your employees record expenses by email', config_parameter='hr_expense.use_mailgateway') - module_sale_management = fields.Boolean(string="Customer Billing") + module_sale_expense = fields.Boolean(string="Customer Billing") @api.model def get_values(self): diff --git a/addons/hr_expense/report/hr_expense_report.xml b/addons/hr_expense/report/hr_expense_report.xml index 375616a8f42..46d6fe80a49 100644 --- a/addons/hr_expense/report/hr_expense_report.xml +++ b/addons/hr_expense/report/hr_expense_report.xml @@ -22,7 +22,7 @@
Validated By: -

+

Payment By: diff --git a/addons/hr_expense/static/src/js/tour.js b/addons/hr_expense/static/src/js/tour.js index 14bc3ae7873..7f53ae364cc 100644 --- a/addons/hr_expense/static/src/js/tour.js +++ b/addons/hr_expense/static/src/js/tour.js @@ -13,22 +13,17 @@ tour.register('hr_expense_tour' , [tour.STEPS.MENU_MORE, { trigger: '.o_app[data-menu-xmlid="hr_expense.menu_hr_expense_root"], .oe_menu_toggler[data-menu-xmlid="hr_expense.menu_hr_expense_root"]', - content: _t("Go to the expense to attach a receipt."), + content: _t("Want to manage your expenses? It starts here."), position: 'bottom', }, { trigger: '.o_list_button_add', extra_trigger: ".o_expense_tree", - content: _t('

Click here to create your first expense and add it under here.

'), + content: _t('

Let’s start by creating your first expense.

'), position: 'bottom' -}, { - trigger: ".o_required_modifier input", - extra_trigger: ".o_expense_form", - content: _t("Write the name of the product, or select an existing one."), - position: "top", }, { trigger: '.o_form_button_save', - extra_trigger: ".o_expense_form", - content: _t("

Once your Expense is ready, you can save it.

"), + extra_trigger: ".o_expense_sheet", + content: _t("

Once your Expense report is ready, you can save it and wait for the approval from your manager.

"), position: 'bottom', }, { trigger: '.o_expense_form .o_chatter_button_new_message', diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml index 7ad72b2ffd7..b42cdacb93d 100644 --- a/addons/hr_expense/views/hr_expense_views.xml +++ b/addons/hr_expense/views/hr_expense_views.xml @@ -1,6 +1,19 @@ + + hr.employee.view.form.expense + hr.employee + + + + + + + + + + hr.expense.tree hr.expense @@ -21,26 +34,13 @@ - - hr.expense.form + + hr.expense.view.form hr.expense - +
-
-
-
- -
@@ -160,9 +187,9 @@ - + - + @@ -196,7 +223,7 @@ - My Expenses to Submit + My Expenses hr.expense tree,kanban,form,graph,pivot @@ -347,7 +374,7 @@ form graph,pivot { - 'search_default_uncancelled': 1, + 'search_default_approved': 1, } @@ -387,7 +414,8 @@
@@ -401,15 +429,15 @@ - + - - + + @@ -418,13 +446,12 @@