From cbfdc36ad081202ba91b3d8e8be5392e5cbfa873 Mon Sep 17 00:00:00 2001
From: Aaron Bohy <aab@odoo.com>
Date: Mon, 6 Mar 2017 13:53:00 +0100
Subject: [PATCH] [REF] account_asset,sale: invisible attr in form view

When the invisible attr doesn't need to be evaluated (e.g. = "1"),
it is better not to specify it within the attrs as they are
automacally re-evaluted at each field changed.

We directly write "invisible=1" instead.

The JS framework supports both, but we encourage the later one.
---
 addons/account_asset/views/account_asset_views.xml     | 2 +-
 addons/sale/wizard/sale_make_invoice_advance_views.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account_asset/views/account_asset_views.xml b/addons/account_asset/views/account_asset_views.xml
index f569a6b60b1..b4993840004 100644
--- a/addons/account_asset/views/account_asset_views.xml
+++ b/addons/account_asset/views/account_asset_views.xml
@@ -19,7 +19,7 @@
                         </h1>
                     </div>
                     <group>
-                        <field name="type" attrs="{'invisible': 1}"/>
+                        <field name="type" invisible="1"/>
                         <field name="company_id" options="{'no_create': True}" groups="base.group_multi_company"/>
                     </group>
                     <group string="Journal Entries">
diff --git a/addons/sale/wizard/sale_make_invoice_advance_views.xml b/addons/sale/wizard/sale_make_invoice_advance_views.xml
index 2258d8913bf..9b6e653857c 100644
--- a/addons/sale/wizard/sale_make_invoice_advance_views.xml
+++ b/addons/sale/wizard/sale_make_invoice_advance_views.xml
@@ -15,7 +15,7 @@
                             attrs="{'invisible': [('count','&gt;',1)]}"/>
                         <field name="product_id"
                             context="{'search_default_services': 1, 'default_type': 'service', 'default_invoice_policy': 'order'}" class="oe_inline"
-                            attrs="{'invisible': 1}"/>
+                            invisible="1"/>
                         <label for="amount" attrs="{'invisible': [('advance_payment_method', 'not in', ('fixed','percentage'))]}"/>
                         <div attrs="{'invisible': [('advance_payment_method', 'not in', ('fixed','percentage'))]}">
                             <field name="amount"