From cbd77876fca743ea923983f882c72fdd8292f149 Mon Sep 17 00:00:00 2001
From: Varun Raval <var@odoo.com>
Date: Mon, 22 Apr 2019 13:07:48 +0000
Subject: [PATCH] [IMP] web,mail: support line break in activity feedback

Purpose of the commit is when writing feedback on an activity it
doesn't have a line break in it so feedback was printed in a single line.

After this commit feedback will support line break.

Split the line by '\n' in feedback xml template to avoid t-raw.
Avoid `preventDefault` in kanban record when hitting <ENTER> on a textarea.

Task #1965831

closes odoo/odoo#33212

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
---
 addons/mail/data/mail_data.xml                         | 7 ++++++-
 addons/web/static/src/js/views/kanban/kanban_record.js | 8 +++++---
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/addons/mail/data/mail_data.xml b/addons/mail/data/mail_data.xml
index ee008eb5e31..2f1ce77f0d8 100644
--- a/addons/mail/data/mail_data.xml
+++ b/addons/mail/data/mail_data.xml
@@ -321,7 +321,12 @@
         <t t-if="display_assignee"> (originally assigned to <span t-field="activity.user_id.name"/>)</t>
         <span t-if="activity.summary">: </span><span t-if="activity.summary" t-field="activity.summary"/>
     </p>
-    <div t-if="feedback" t-esc="feedback"/>
+    <div t-if="feedback">
+        <t t-foreach="feedback.split('\n')" t-as="feedback_line">
+            <t t-esc="feedback_line"/>
+            <br t-if="not feedback_line_last"/>
+        </t>
+    </div>
     <t t-if="activity.note != '&lt;p&gt;&lt;br&gt;&lt;/p&gt;'"><!-- <p></br></p> -->
         <div class="o_mail_note_title"><strong>Original note:</strong></div>
         <div t-field="activity.note"/>
diff --git a/addons/web/static/src/js/views/kanban/kanban_record.js b/addons/web/static/src/js/views/kanban/kanban_record.js
index b643b8355b6..4dff9d74fe3 100644
--- a/addons/web/static/src/js/views/kanban/kanban_record.js
+++ b/addons/web/static/src/js/views/kanban/kanban_record.js
@@ -695,9 +695,11 @@ var KanbanRecord = Widget.extend({
     _onKeyDownCard: function (event) {
         switch (event.keyCode) {
             case $.ui.keyCode.ENTER:
-                event.preventDefault();
-                this._onGlobalClick(event);
-                break;
+                if ($(event.target).hasClass('oe_kanban_global_click')) {
+                    event.preventDefault();
+                    this._onGlobalClick(event);
+                    break;
+                }
         }
     },
     /**