From c9fad69c17ec6df5cdf49bbea813903684813b9f Mon Sep 17 00:00:00 2001
From: Romain Derie <rde@odoo.com>
Date: Mon, 13 May 2019 13:49:47 +0000
Subject: [PATCH] [REM] *: remove useless active True on template tag

template records are already active by default

As task-1934445 will introduce a new asset type (tests) in master (12.4), it
will clean some code.
This commit got extracted from that task.

Coming with https://github.com/odoo/enterprise/pull/4331 and https://github.com/odoo/design-themes/pull/153

closes odoo/odoo#33345

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
---
 addons/stock/views/report_stock_traceability.xml            | 2 +-
 addons/website_event/views/event_templates.xml              | 4 ++--
 addons/website_sale/views/templates.xml                     | 6 +++---
 .../views/website_sale_comparison_template.xml              | 4 ++--
 addons/website_sale_coupon/views/website_sale_templates.xml | 2 +-
 .../views/website_sale_wishlist_template.xml                | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/addons/stock/views/report_stock_traceability.xml b/addons/stock/views/report_stock_traceability.xml
index a434ef0dadc..2690aeb80b4 100644
--- a/addons/stock/views/report_stock_traceability.xml
+++ b/addons/stock/views/report_stock_traceability.xml
@@ -81,7 +81,7 @@
         </div>
     </template>
 
-    <template id="assets_stock_print_report" inherit_id="web.assets_common" active="True">
+    <template id="assets_stock_print_report" inherit_id="web.assets_common">
         <xpath expr="." position="inside">
             <link rel="stylesheet" type="text/scss" href="/stock/static/src/scss/stock_traceability_report.scss"/>
         </xpath>
diff --git a/addons/website_event/views/event_templates.xml b/addons/website_event/views/event_templates.xml
index a66521e3290..374faf60552 100644
--- a/addons/website_event/views/event_templates.xml
+++ b/addons/website_event/views/event_templates.xml
@@ -125,13 +125,13 @@
     </xpath>
 </template>
 
-<template id="event_left_column" active="True" inherit_id="website_event.index" customize_show="True" name="Filters Column on the Left">
+<template id="event_left_column" inherit_id="website_event.index" customize_show="True" name="Filters Column on the Left">
     <xpath expr="//div[@id='middle_column']" position="before">
         <div class="col-lg-3 css_noprint" id="left_column"/>
     </xpath>
 </template>
 
-<template id="event_time" active="True" customize_show="True" inherit_id="website_event.event_left_column" name="Filter by Date">
+<template id="event_time" customize_show="True" inherit_id="website_event.event_left_column" name="Filter by Date">
     <xpath expr="//div[@id='left_column']" position="inside">
         <ul class="nav nav-pills flex-column mb-3">
             <t t-foreach="dates" t-as="date">
diff --git a/addons/website_sale/views/templates.xml b/addons/website_sale/views/templates.xml
index af9ac9ee069..90cfa501631 100644
--- a/addons/website_sale/views/templates.xml
+++ b/addons/website_sale/views/templates.xml
@@ -266,7 +266,7 @@
         </t>
     </template>
 
-    <template id="sort" inherit_id="website_sale.products" active="True" customize_show="True" name="Show Sort by">
+    <template id="sort" inherit_id="website_sale.products" customize_show="True" name="Show Sort by">
         <xpath expr="//div[hasclass('products_pager')]/t[@t-call][last()]" position="after">
             <t t-set="list_price_desc_label">Catalog price: High to Low</t>
             <t t-set="list_price_asc_label">Catalog price: Low to High</t>
@@ -1271,7 +1271,7 @@
         </t>
     </template>
 
-    <template id="address_b2b" inherit_id="address" name="Show b2b fields" customize_show="True" active="True">
+    <template id="address_b2b" inherit_id="address" name="Show b2b fields" customize_show="True">
         <xpath expr="//div[@id='div_phone']" position="after">
             <div class="w-100"/>
             <t t-if="mode == ('new', 'billing') or (mode == ('edit', 'billing') and (can_edit_vat or 'vat' in checkout and checkout['vat']))">
@@ -1549,7 +1549,7 @@
         </div>
     </template>
 
-    <template id="reduction_code" inherit_id="website_sale.total" active="True" customize_show="True" name="Promo Code">
+    <template id="reduction_code" inherit_id="website_sale.total" customize_show="True" name="Promo Code">
         <xpath expr="//div[@id='cart_total']//table/tr[last()]" position="after">
             <tr t-if="not hide_coupon">
                 <td colspan="3" class="text-center text-xl-right noborder">
diff --git a/addons/website_sale_comparison/views/website_sale_comparison_template.xml b/addons/website_sale_comparison/views/website_sale_comparison_template.xml
index bf7f2e021fd..fdac91bee16 100644
--- a/addons/website_sale_comparison/views/website_sale_comparison_template.xml
+++ b/addons/website_sale_comparison/views/website_sale_comparison_template.xml
@@ -9,7 +9,7 @@
         </xpath>
     </template>
 
-    <template id="add_to_compare" inherit_id="website_sale.products_item" active="True" customize_show="True" name="Comparison List" priority="22">
+    <template id="add_to_compare" inherit_id="website_sale.products_item" customize_show="True" name="Comparison List" priority="22">
         <xpath expr="//div[hasclass('product_price')]" position="inside">
             <t t-set="product_variant_id" t-value="product._get_first_possible_variant_id()"/>
             <button t-if="product_variant_id" type="button" role="button" class="d-none d-md-inline-block btn btn-secondary btn-sm o_add_compare" title="Compare" aria-label="Compare" t-att-data-product-product-id="product_variant_id" data-action="o_comparelist"><span class="fa fa-exchange"></span></button>
@@ -25,7 +25,7 @@
         </xpath>
     </template>
 
-    <template id="product_attributes_body" inherit_id="website_sale.product" customize_show="True" active="True" name="Product attributes table">
+    <template id="product_attributes_body" inherit_id="website_sale.product" customize_show="True" name="Product attributes table">
         <xpath expr="//div[@id='product_attributes_simple']" position="replace"/>
         <xpath expr="//div[@id='product_full_description']" position="after">
             <section class="container" id="product_full_spec">
diff --git a/addons/website_sale_coupon/views/website_sale_templates.xml b/addons/website_sale_coupon/views/website_sale_templates.xml
index 7032b3d76c5..bbd9a959863 100644
--- a/addons/website_sale_coupon/views/website_sale_templates.xml
+++ b/addons/website_sale_coupon/views/website_sale_templates.xml
@@ -6,7 +6,7 @@
         <script type="text/javascript" src="/website_sale_coupon/static/src/js/website_sale_coupon.test.js"></script>
     </xpath>
 </template>
-<template id="website_sale_coupon_cart_hide_qty" inherit_id="website_sale.cart_lines" active="True">
+<template id="website_sale_coupon_cart_hide_qty" inherit_id="website_sale.cart_lines">
     <xpath expr="//td[hasclass('td-qty')]/div" position="attributes">
         <attribute name="t-att-style">line.is_reward_line and "display:none;"</attribute>
     </xpath>
diff --git a/addons/website_sale_wishlist/views/website_sale_wishlist_template.xml b/addons/website_sale_wishlist/views/website_sale_wishlist_template.xml
index 4636dcc1968..6a9e955a4e8 100644
--- a/addons/website_sale_wishlist/views/website_sale_wishlist_template.xml
+++ b/addons/website_sale_wishlist/views/website_sale_wishlist_template.xml
@@ -9,7 +9,7 @@
         </xpath>
     </template>
 
-    <template id="add_to_wishlist" inherit_id="website_sale.products_item" active="True" customize_show="True" name="Wishlist" priority="20">
+    <template id="add_to_wishlist" inherit_id="website_sale.products_item" customize_show="True" name="Wishlist" priority="20">
         <xpath expr="//div[hasclass('product_price')]" position="inside">
             <t t-set="in_wish" t-value="product._is_in_wishlist()"/>
             <t t-set="product_variant_id" t-value="product._get_first_possible_variant_id()"/>