From c9f1e56d87f7cdf6cbc2ab7eb0bd7e8c81ba778a Mon Sep 17 00:00:00 2001 From: Nicolas Bayet Date: Tue, 16 Nov 2021 15:44:13 +0000 Subject: [PATCH] [FIX] web_editor: prevent traceback when droping undroppable snippet When trying to drop a snippet that could not be possibly dropped, a traceback is shown but shouldn't. Task-2692492 closes odoo/odoo#79924 X-original-commit: 4408dbaf74aa26272b6ed3ce718a2d915975d4b3 Signed-off-by: David Monjoie (dmo) --- addons/web_editor/static/src/js/editor/snippets.editor.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/addons/web_editor/static/src/js/editor/snippets.editor.js b/addons/web_editor/static/src/js/editor/snippets.editor.js index 982d7d4b8f9..604113d2d1a 100644 --- a/addons/web_editor/static/src/js/editor/snippets.editor.js +++ b/addons/web_editor/static/src/js/editor/snippets.editor.js @@ -2509,7 +2509,9 @@ var SnippetsMenu = Widget.extend({ }); } else { $toInsert.remove(); - dragAndDropResolve(); + if (dragAndDropResolve) { + dragAndDropResolve(); + } self.$el.find('.oe_snippet_thumbnail').removeClass('o_we_already_dragging'); } },