From c9ba639017de0bccef96e2cb68aa28fede2eb0c1 Mon Sep 17 00:00:00 2001
From: niyasraphy <niyasraphyk@gmail.com>
Date: Mon, 17 Oct 2022 13:51:07 +0000
Subject: [PATCH] [FIX] base: button label

The Owl web client does not suppress GTK-style mnemonics, so these
should be removed, as otherwise they are explicitly displayed.

Following GTK rules, the old GTK client would use the `_` letter
prefix in labels to underline the letter and use the corresponding
character as accelerator/mnemonic for activating the
control (https://docs.gtk.org/gtk4/ctor.Label.new_with_mnemonic.html).

The web client "supported" this feature by just ignoring and dropping
the `_` it found in labels, even after it gained support for keyboard
accelerators (= hotkeys).

The new Owl form just ignores GTK-style mnemonics entirely, not
performing that preprocessing on widget labels. As a result, the
mnemonic marker (`_`) now appears literally in some labels, and needs
to be removed.

closes odoo/odoo#103563

X-original-commit: ca80632a1045b26927f72d93f4ec58e7a58b5654
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
---
 odoo/addons/base/views/ir_model_views.xml              | 2 +-
 odoo/addons/base/wizard/base_import_language_views.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/odoo/addons/base/views/ir_model_views.xml b/odoo/addons/base/views/ir_model_views.xml
index f216db0657c..22029e25d80 100644
--- a/odoo/addons/base/views/ir_model_views.xml
+++ b/odoo/addons/base/views/ir_model_views.xml
@@ -12,7 +12,7 @@
                         <field name="menu_id"/>
                     </group>
                     <footer>
-                        <button name="menu_create" string="Create _Menu" type="object" class="btn-primary" data-hotkey="q"/>
+                        <button name="menu_create" string="Create Menu" type="object" class="btn-primary" data-hotkey="q"/>
                         <button string="Cancel" class="btn-secondary" special="cancel" data-hotkey="z" />
                     </footer>
                 </form>
diff --git a/odoo/addons/base/wizard/base_import_language_views.xml b/odoo/addons/base/wizard/base_import_language_views.xml
index 83344ecdd2d..b0f005927fa 100644
--- a/odoo/addons/base/wizard/base_import_language_views.xml
+++ b/odoo/addons/base/wizard/base_import_language_views.xml
@@ -15,7 +15,7 @@
                         <field name="overwrite" groups="base.group_no_one"/>
                     </group>
                     <footer>
-                        <button name="import_lang" string="_Import" type="object" class="btn-primary" data-hotkey="q"/>
+                        <button name="import_lang" string="Import" type="object" class="btn-primary" data-hotkey="q"/>
                         <button string="Cancel" class="btn-secondary" special="cancel" data-hotkey="z" />
                     </footer>
                 </form>