From c998fdd77b1b55531f534fcb628903d699f48b69 Mon Sep 17 00:00:00 2001
From: FrancoisGe <fge@odoo.com>
Date: Fri, 21 Oct 2022 14:04:15 +0000
Subject: [PATCH] [FIX] base: consider `multi_edit="1"` views editable

Since odoo/odoo#95729

nodes with a `groups=` are completely removed from the views when
the user is not part of the group, instead of being made invisible.

In that PR, views have been adapted to add back fields, with invisible="1",
when they were required, for instance when they were used in a domain
of another field which was still there despite the user is not part
of the given group.

As `tree` views having `multi_edit="1"` where not considered
as editable views, the domain of fields in these views were not
validated:
- https://github.com/odoo/odoo/blob/1fb8fa16ab7dc298d54f089d7163fb556dbc5fcc/odoo/addons/base/models/ir_ui_view.py#L1460
- https://github.com/odoo/odoo/blob/1fb8fa16ab7dc298d54f089d7163fb556dbc5fcc/odoo/addons/base/models/ir_ui_view.py#L1321-L1322

while they are well required for the web client,
in `multi_edit="1"` this is possible to edit relational/many2one field,
and therefore it will do `name_search` calls using the domain of the
field, and therefore the fields used in these domains must always
be present in the views. Without it, a crash in the web client occurs
when attempting to edit the relational/many2one field.

This revision targets to consider the `multi_edit="1"` tree views
as editable, to make the field domains validated as they should be.

Hence, views are adapted to add back fields with `invisible="1"`
when they are required in domains of other fields.

Part-of: odoo/odoo#103790
---
 addons/analytic/views/analytic_account_views.xml       |  1 +
 addons/analytic/views/analytic_line_views.xml          |  2 ++
 addons/crm/views/crm_lead_views.xml                    |  2 ++
 addons/hr_contract/views/hr_contract_views.xml         |  1 +
 addons/hr_expense/views/hr_expense_views.xml           |  2 ++
 addons/mrp/views/mrp_production_views.xml              |  2 ++
 addons/mrp/views/mrp_routing_views.xml                 |  2 ++
 addons/mrp/views/mrp_workcenter_views.xml              |  1 +
 addons/repair/views/repair_views.xml                   |  1 +
 addons/stock/views/stock_location_views.xml            |  1 +
 addons/stock/views/stock_picking_views.xml             |  1 +
 addons/stock/views/stock_scrap_views.xml               |  2 ++
 .../views/stock_picking_batch_views.xml                |  1 +
 addons/web/static/tests/helpers/mock_server.js         | 10 ++++------
 odoo/addons/base/models/ir_ui_view.py                  |  2 +-
 15 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/addons/analytic/views/analytic_account_views.xml b/addons/analytic/views/analytic_account_views.xml
index 33ac5a02516..450d7b84e46 100644
--- a/addons/analytic/views/analytic_account_views.xml
+++ b/addons/analytic/views/analytic_account_views.xml
@@ -52,6 +52,7 @@
             <field eval="8" name="priority"/>
             <field name="arch" type="xml">
                 <tree string="Analytic Accounts" multi_edit="1">
+                    <field name="company_id" invisible="1"/>
                     <field name="name" string="Name"/>
                     <field name="code"/>
                     <field name="partner_id"/>
diff --git a/addons/analytic/views/analytic_line_views.xml b/addons/analytic/views/analytic_line_views.xml
index 733fdd67b63..c1a543e4ce8 100644
--- a/addons/analytic/views/analytic_line_views.xml
+++ b/addons/analytic/views/analytic_line_views.xml
@@ -5,6 +5,8 @@
         <field name="model">account.analytic.line</field>
         <field name="arch" type="xml">
             <tree string="Analytic Items" multi_edit="1">
+                <field name="company_id" invisible="1"/>
+                <field name="product_uom_category_id" invisible="1"/>
                 <field name="date" optional="show"/>
                 <field name="name"/>
                 <field name="account_id"/>
diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index 7b7b41e7df7..36528002fe1 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -362,6 +362,7 @@
             <field name="priority">10</field>
             <field name="arch" type="xml">
                 <tree string="Leads" sample="1" multi_edit="1">
+                    <field name="company_id" invisible="1"/>
                     <field name="date_deadline" invisible="1"/>
                     <field name="create_date" optional="hide"/>
                     <field name="name" string="Lead" readonly="1"/>
@@ -763,6 +764,7 @@
                     <header>
                         <button name="%(crm.action_lead_mass_mail)d" type="action" string="Email" />
                     </header>
+                    <field name="company_id" invisible="1"/>
                     <field name="date_deadline" invisible="1"/>
                     <field name="create_date" optional="hide"/>
                     <field name="name" string="Opportunity" readonly="1"/>
diff --git a/addons/hr_contract/views/hr_contract_views.xml b/addons/hr_contract/views/hr_contract_views.xml
index 557a0ef0336..a1482aab2a0 100644
--- a/addons/hr_contract/views/hr_contract_views.xml
+++ b/addons/hr_contract/views/hr_contract_views.xml
@@ -239,6 +239,7 @@
             <field name="model">hr.contract</field>
             <field name="arch" type="xml">
                 <tree string="Contracts" multi_edit="1" sample="1" default_order='date_start ASC'>
+                    <field name="company_id" invisible="1"/>
                     <field name="name" readonly="1"/>
                     <field name="employee_id" readonly="1" widget="many2one_avatar_employee"/>
                     <field name="job_id"/>
diff --git a/addons/hr_expense/views/hr_expense_views.xml b/addons/hr_expense/views/hr_expense_views.xml
index 3e260c055c5..0a455bc07a5 100644
--- a/addons/hr_expense/views/hr_expense_views.xml
+++ b/addons/hr_expense/views/hr_expense_views.xml
@@ -45,6 +45,7 @@
             <field name="model">hr.expense</field>
             <field name="arch" type="xml">
                 <tree string="Expenses" multi_edit="1" sample="1" js_class="hr_expense_tree" decoration-info="state == 'draft'">
+                    <field name="company_id" invisible="1"/>
                     <field name="company_currency_id" invisible="1"/>
                     <field name="attachment_number" invisible="True"/>
                     <field name="date" optional="show"/>
@@ -613,6 +614,7 @@
             <field name="model">hr.expense.sheet</field>
             <field name="arch" type="xml">
                 <tree string="Expense Reports" multi_edit="1" js_class="hr_expense_tree" sample="1" decoration-info="state == 'draft'">
+                    <field name="company_id" invisible="1"/>
                     <field name="product_ids" invisible="1"/>
                     <field name="employee_id" widget="many2one_avatar_employee"/>
                     <field name="accounting_date" optional="hide" groups="account.group_account_manager"/>
diff --git a/addons/mrp/views/mrp_production_views.xml b/addons/mrp/views/mrp_production_views.xml
index ac9faf26ef3..21d8ef76fcc 100644
--- a/addons/mrp/views/mrp_production_views.xml
+++ b/addons/mrp/views/mrp_production_views.xml
@@ -12,6 +12,8 @@
                         <button name="do_unreserve" type="object" string="Unreserve"/>
                         <button name="action_cancel" type="object" string="Cancel"/>
                     </header>
+                    <field name="company_id" invisible="1"/>
+                    <field name="product_uom_category_id" invisible="1"/>
                     <field name="priority" optional="show" widget="priority" nolabel="1"/>
                     <field name="message_needaction" invisible="1"/>
                     <field name="name" decoration-bf="1"/>
diff --git a/addons/mrp/views/mrp_routing_views.xml b/addons/mrp/views/mrp_routing_views.xml
index 927ea6ab3b6..602553cda6f 100644
--- a/addons/mrp/views/mrp_routing_views.xml
+++ b/addons/mrp/views/mrp_routing_views.xml
@@ -7,6 +7,7 @@
             <field name="model">mrp.routing.workcenter</field>
             <field name="arch" type="xml">
                 <tree string="Routing Work Centers" multi_edit="1">
+                    <field name="company_id" invisible="1"/>
                     <field name="name"/>
                     <field name="bom_id"/>
                     <field name="workcenter_id"/>
@@ -53,6 +54,7 @@
                 <xpath expr="//field[@name='blocked_by_operation_ids']" position="replace">
                 </xpath>
                 <xpath expr="//field[@name='name']" position="after">
+                    <field name="bom_id" invisible="1"/>
                     <field name="blocked_by_operation_ids" widget="many2many_tags" optional="hide" attrs="{'column_invisible': [('parent.allow_operation_dependencies', '=', False)]}"/>
                 </xpath>
             </field>
diff --git a/addons/mrp/views/mrp_workcenter_views.xml b/addons/mrp/views/mrp_workcenter_views.xml
index 9bd085e7b33..6ff1512c487 100644
--- a/addons/mrp/views/mrp_workcenter_views.xml
+++ b/addons/mrp/views/mrp_workcenter_views.xml
@@ -33,6 +33,7 @@
             <field name="model">mrp.workcenter</field>
             <field name="arch" type="xml">
                 <tree string="Work Center" multi_edit="1">
+                    <field name="company_id" invisible="1"/>
                     <field name="sequence" widget="handle"/>
                     <field name="name" optional="show"/>
                     <field name="code" optional="show"/>
diff --git a/addons/repair/views/repair_views.xml b/addons/repair/views/repair_views.xml
index 5608b968385..08c36bd6ea1 100644
--- a/addons/repair/views/repair_views.xml
+++ b/addons/repair/views/repair_views.xml
@@ -7,6 +7,7 @@
         <field name="model">repair.order</field>
         <field name="arch" type="xml">
             <tree string="Repairs order" multi_edit="1" sample="1" decoration-info="state == 'draft'">
+                <field name="company_id" invisible="1"/>
                 <field name="priority" optional="show" widget="priority" nolabel="1"/>
                 <field name="name"/>
                 <field name="schedule_date" optional="show" widget="remaining_days"/>
diff --git a/addons/stock/views/stock_location_views.xml b/addons/stock/views/stock_location_views.xml
index b219c7b82f7..ecf5cfdab50 100644
--- a/addons/stock/views/stock_location_views.xml
+++ b/addons/stock/views/stock_location_views.xml
@@ -91,6 +91,7 @@
         <field name="priority" eval="2"/>
         <field name="arch" type="xml">
             <tree string="Stock Location" decoration-info="usage=='view'" decoration-danger="usage=='internal'" multi_edit="1">
+                <field name="company_id" invisible="1"/>
                 <field name="active" invisible="1"/>
                 <field name="complete_name" string="Location"/>
                 <field name="usage"/>
diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index 242f8ce37ae..c6d2cdc26a1 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -65,6 +65,7 @@
                         <button name="do_unreserve" type="object" string="Unreserve"/>
                         <button name="action_assign" type="object" string="Check Availability"/>
                     </header>
+                    <field name="company_id" invisible="1"/>
                     <field name="priority" optional="show" widget="priority" nolabel="1"/>
                     <field name="name" decoration-bf="1"/>
                     <field name="location_id" options="{'no_create': True}" string="From" groups="stock.group_stock_multi_locations" optional="show"/>
diff --git a/addons/stock/views/stock_scrap_views.xml b/addons/stock/views/stock_scrap_views.xml
index 970c1532c20..10ff98d47a7 100644
--- a/addons/stock/views/stock_scrap_views.xml
+++ b/addons/stock/views/stock_scrap_views.xml
@@ -121,6 +121,8 @@
             <field name="model">stock.scrap</field>
             <field name="arch" type="xml">
                 <tree multi_edit="1" sample="1" decoration-info="state == 'draft'">
+                    <field name="company_id" invisible="1"/>
+                    <field name="product_uom_category_id" invisible="1"/>
                     <field name="name" decoration-bf="1"/>
                     <field name="date_done"/>
                     <field name="product_id" readonly="1"/>
diff --git a/addons/stock_picking_batch/views/stock_picking_batch_views.xml b/addons/stock_picking_batch/views/stock_picking_batch_views.xml
index 62bef20fb7b..fb1ec110d74 100644
--- a/addons/stock_picking_batch/views/stock_picking_batch_views.xml
+++ b/addons/stock_picking_batch/views/stock_picking_batch_views.xml
@@ -174,6 +174,7 @@
         <field name="model">stock.picking.batch</field>
         <field name="arch" type="xml">
             <tree string="Stock Batch Transfer" multi_edit="1" sample="1">
+                <field name="company_id" invisible="1"/>
                 <field name="name" decoration-bf="1"/>
                 <field name="scheduled_date"/>
                 <field name="user_id" widget="many2one_avatar_user"/>
diff --git a/addons/web/static/tests/helpers/mock_server.js b/addons/web/static/tests/helpers/mock_server.js
index e0e29fcb394..8fab67c638a 100644
--- a/addons/web/static/tests/helpers/mock_server.js
+++ b/addons/web/static/tests/helpers/mock_server.js
@@ -286,7 +286,7 @@ export class MockServer {
                 }
                 const defaultValues = {};
                 const stateExceptions = {}; // what is this ?
-                (editableView && modifiersNames || ["invisible"]).forEach((attr) => {
+                ((editableView && modifiersNames) || ["invisible"]).forEach((attr) => {
                     stateExceptions[attr] = [];
                     defaultValues[attr] = !!field[attr];
                 });
@@ -467,7 +467,7 @@ export class MockServer {
             case "form":
                 return true;
             case "tree":
-                return !!node.getAttribute("editable");
+                return node.getAttribute("editable") || node.getAttribute("multi_edit");
             case "field": {
                 const fname = node.getAttribute("name");
                 const field = this.models[modelName].fields[fname];
@@ -489,11 +489,9 @@ export class MockServer {
     _onchangeAbleView(node) {
         if (node.tagName === "form") {
             return true;
-        }
-        else if (node.tagName === "tree") {
+        } else if (node.tagName === "tree") {
             return true;
-        }
-        else if (node.tagName === "kanban") {
+        } else if (node.tagName === "kanban") {
             return true;
         }
     }
diff --git a/odoo/addons/base/models/ir_ui_view.py b/odoo/addons/base/models/ir_ui_view.py
index d243da03e68..6904e950e23 100644
--- a/odoo/addons/base/models/ir_ui_view.py
+++ b/odoo/addons/base/models/ir_ui_view.py
@@ -1319,7 +1319,7 @@ actual arch.
         return True
 
     def _editable_tag_tree(self, node, name_manager):
-        return node.get('editable')
+        return node.get('editable') or node.get('multi_edit')
 
     def _editable_tag_field(self, node, name_manager):
         field = name_manager.model._fields.get(node.get('name'))