From c8ef8fd7370ed9b3cc30a52f36049e38ce7a0373 Mon Sep 17 00:00:00 2001 From: "Louis Wicket (wil)" Date: Thu, 5 May 2022 14:13:34 +0000 Subject: [PATCH] [IMP] mail: small CSS classes improvements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit + Rename the CSS class `o-mobile` to `isDeviceSmall` in order to match the name of the field tested to conditionnaly add or remove the class. + Remove unused classes (o-downloadable and o-isMobile). + Rename CSS class `o-has-multiple-action` to `o-hasMultipleActions` and introduce a new field on AttachmentCard to express more declaratively the condition used to add or remove the class closes odoo/odoo#90643 Signed-off-by: Alexandre Kühn (aku) --- .../attachment_card/attachment_card.scss | 4 ++-- .../attachment_card/attachment_card.xml | 11 +++++----- .../attachment_viewer/attachment_viewer.xml | 4 ++-- .../channel_member/channel_member.xml | 2 +- .../components/chat_window/chat_window.scss | 4 ++-- .../components/chat_window/chat_window.xml | 2 +- .../chat_window_header.scss | 4 ++-- .../chat_window_header/chat_window_header.xml | 20 +++++++++---------- .../src/components/composer/composer.xml | 8 ++++---- .../src/components/discuss/discuss.scss | 6 +++--- .../static/src/components/discuss/discuss.xml | 4 ++-- .../static/src/components/message/message.xml | 2 +- .../messaging_menu/messaging_menu.scss | 14 ++++++------- .../messaging_menu/messaging_menu.xml | 10 +++++----- .../notification_list/notification_list.xml | 6 +++--- .../notification_list_item.scss | 6 +++--- .../notification_request.xml | 4 ++-- .../thread_needaction_preview.xml | 4 ++-- .../thread_preview/thread_preview.xml | 4 ++-- .../mail/static/src/models/attachment_card.js | 12 ++++++++++- .../discuss_mobile_mailbox_selection_tests.js | 2 +- 21 files changed, 71 insertions(+), 62 deletions(-) diff --git a/addons/mail/static/src/components/attachment_card/attachment_card.scss b/addons/mail/static/src/components/attachment_card/attachment_card.scss index d5909f621e6..18c3e1ee709 100644 --- a/addons/mail/static/src/components/attachment_card/attachment_card.scss +++ b/addons/mail/static/src/components/attachment_card/attachment_card.scss @@ -11,11 +11,11 @@ } .o_AttachmentCard_aside { - &:not(.o-has-multiple-action) { + &:not(.o-hasMultipleActions) { min-width: 50px; } - &.o-has-multiple-action { + &.o-hasMultipleActions { min-width: 30px; } } diff --git a/addons/mail/static/src/components/attachment_card/attachment_card.xml b/addons/mail/static/src/components/attachment_card/attachment_card.xml index 665405195a1..2fe5267abfb 100644 --- a/addons/mail/static/src/components/attachment_card/attachment_card.xml +++ b/addons/mail/static/src/components/attachment_card/attachment_card.xml @@ -4,11 +4,10 @@
@@ -28,7 +27,7 @@
-
+
diff --git a/addons/mail/static/src/components/attachment_viewer/attachment_viewer.xml b/addons/mail/static/src/components/attachment_viewer/attachment_viewer.xml index b5ad6552d59..b6f017fa428 100644 --- a/addons/mail/static/src/components/attachment_viewer/attachment_viewer.xml +++ b/addons/mail/static/src/components/attachment_viewer/attachment_viewer.xml @@ -47,7 +47,7 @@
-