From c89d45b6583023d28735d4e17762165d10edf493 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Fri, 13 Jan 2012 10:06:11 +0100
Subject: [PATCH] [IMP] display a warning and disable excel export option when
 XLWT is not installed

lp bug: https://launchpad.net/bugs/915347 fixed

bzr revid: xmo@openerp.com-20120113090611-lmiu5y7y7b9td8hg
---
 addons/web/controllers/main.py          | 16 +++++++++++-----
 addons/web/static/src/js/data_export.js | 10 +++++++++-
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py
index fd8d85f9d69..7081ce3ce32 100644
--- a/addons/web/controllers/main.py
+++ b/addons/web/controllers/main.py
@@ -18,6 +18,10 @@ from cStringIO import StringIO
 
 import babel.messages.pofile
 import werkzeug.utils
+try:
+    import xlwt
+except ImportError:
+    xlwt = None
 
 import web.common
 openerpweb = web.common.http
@@ -1308,7 +1312,7 @@ class Export(View):
             for path, controller in openerpweb.controllers_path.iteritems()
             if path.startswith(self._cp_path)
             if hasattr(controller, 'fmt')
-        ], key=operator.itemgetter(1))
+        ], key=operator.itemgetter("label"))
 
     def fields_get(self, req, model):
         Model = req.session.model(model)
@@ -1484,7 +1488,7 @@ class Export(View):
 
 class CSVExport(Export):
     _cp_path = '/web/export/csv'
-    fmt = ('csv', 'CSV')
+    fmt = {'tag': 'csv', 'label': 'CSV'}
 
     @property
     def content_type(self):
@@ -1519,7 +1523,11 @@ class CSVExport(Export):
 
 class ExcelExport(Export):
     _cp_path = '/web/export/xls'
-    fmt = ('xls', 'Excel')
+    fmt = {
+        'tag': 'xls',
+        'label': 'Excel',
+        'error': None if xlwt else "XLWT required"
+    }
 
     @property
     def content_type(self):
@@ -1529,8 +1537,6 @@ class ExcelExport(Export):
         return base + '.xls'
 
     def from_data(self, fields, rows):
-        import xlwt
-
         workbook = xlwt.Workbook()
         worksheet = workbook.add_sheet('Sheet 1')
 
diff --git a/addons/web/static/src/js/data_export.js b/addons/web/static/src/js/data_export.js
index 1382bf841de..1268ac67fa5 100644
--- a/addons/web/static/src/js/data_export.js
+++ b/addons/web/static/src/js/data_export.js
@@ -63,7 +63,15 @@ openerp.web.DataExport = openerp.web.Dialog.extend({
     do_setup_export_formats: function (formats) {
         var $fmts = this.$element.find('#export_format');
         _(formats).each(function (format) {
-            $fmts.append(new Option(format[1], format[0]));
+            var opt = new Option(format.label, format.tag);
+            if (format.error) {
+                opt.disabled = true;
+                opt.replaceChild(
+                    document.createTextNode(
+                        _.str.sprintf("%s — %s", format.label, format.error)),
+                    opt.childNodes[0])
+            }
+            $fmts.append(opt);
         });
     },
     show_exports_list: function() {