From c87b9e105c8ffec30c2d79f527014ec7b2c5ebf9 Mon Sep 17 00:00:00 2001
From: Romain Estievenart <res@odoo.com>
Date: Tue, 9 Aug 2022 12:54:38 +0000
Subject: [PATCH] [FIX] mail: hide sharing screen button on mobile devices
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The current implementation of sharing screen uses the
`MediaDevices.getDisplayMedia()` API. Sadly this API is not currently
supported by all major existing mobile browsers[1].
Some users were confused about the browser request permission
notification. As this is a way more complicated than just adding a
permission. We prefer to hide this feature by removing the screen
sharing button on mobile devices.

Links:
[1] https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getDisplayMedia
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=487935

opw-2915773

closes odoo/odoo#97947

X-original-commit: 2bf5ce06ef18d10c79ebab57551267eb31de872f
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
---
 .../call_action_list/call_action_list.xml     | 28 ++++++++++---------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/addons/mail/static/src/components/call_action_list/call_action_list.xml b/addons/mail/static/src/components/call_action_list/call_action_list.xml
index 0fdb5db1d27..40063aa985c 100644
--- a/addons/mail/static/src/components/call_action_list/call_action_list.xml
+++ b/addons/mail/static/src/components/call_action_list/call_action_list.xml
@@ -47,19 +47,21 @@
                                 <i class="fa fa-video-camera fa-stack-1x" t-att-class="{ 'fa-lg': !callActionListView.isSmall, 'text-success': messaging.rtc.sendUserVideo }"/>
                             </div>
                         </button>
-                        <button class="o_CallActionList_button o_CallActionList_videoButton btn d-flex m-1 border-0 rounded-circle bg-800 shadow-none"
-                            t-att-class="{
-                                'o-isActive': messaging.rtc.sendDisplay,
-                                'o-isSmall p-2': callActionListView.isSmall,
-                                'p-3': !callActionListView.isSmall,
-                            }"
-                            t-att-aria-label="callActionListView.screenSharingButtonTitle"
-                            t-att-title="callActionListView.screenSharingButtonTitle"
-                            t-on-click="callActionListView.onClickScreen">
-                            <div class="o_CallActionList_buttonIconWrapper fa-stack" t-att-class="{ 'o-isSmall': callActionListView.isSmall }">
-                                <i class="fa fa-desktop fa-stack-1x" t-att-class="{ 'fa-lg': !callActionListView.isSmall, 'text-success': messaging.rtc.sendDisplay }"/>
-                            </div>
-                        </button>
+                        <t t-if="!env.device.isMobileDevice">
+                            <button class="o_CallActionList_button o_CallActionList_videoButton btn d-flex m-1 border-0 rounded-circle bg-800 shadow-none"
+                                t-att-class="{
+                                    'o-isActive': messaging.rtc.sendDisplay,
+                                    'o-isSmall p-2': callActionListView.isSmall,
+                                    'p-3': !callActionListView.isSmall,
+                                }"
+                                t-att-aria-label="callActionListView.screenSharingButtonTitle"
+                                t-att-title="callActionListView.screenSharingButtonTitle"
+                                t-on-click="callActionListView.onClickScreen">
+                                <div class="o_CallActionList_buttonIconWrapper fa-stack" t-att-class="{ 'o-isSmall': callActionListView.isSmall }">
+                                    <i class="fa fa-desktop fa-stack-1x" t-att-class="{ 'fa-lg': !callActionListView.isSmall, 'text-success': messaging.rtc.sendDisplay }"/>
+                                </div>
+                            </button>
+                        </t>
                         <Popover position="'top'" popoverClass="'o_CallActionList_popover'">
                             <button class="o_CallActionList_button btn d-flex m-1 border-0 rounded-circle bg-800 shadow-none"
                                 aria-label="More"