From c7d6fc84a8db667070febb2117007d42fb7a231c Mon Sep 17 00:00:00 2001 From: David Beguin Date: Mon, 30 Sep 2019 13:29:29 +0000 Subject: [PATCH] [FIX] rating : set rating_last_image/feedback to readonly It's a non sense to be able to write on rating_last_image/feedback field as it is a related to a computed field based on the last rating, given by someone. We should not even try to corrupt data ! Task ID: 2076656 PR #37511 --- addons/rating/models/rating_mixin.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/rating/models/rating_mixin.py b/addons/rating/models/rating_mixin.py index 09b7d328f9e..1ed1a7987e7 100644 --- a/addons/rating/models/rating_mixin.py +++ b/addons/rating/models/rating_mixin.py @@ -48,8 +48,8 @@ class RatingMixin(models.AbstractModel): rating_ids = fields.One2many('rating.rating', 'res_id', string='Rating', domain=lambda self: [('res_model', '=', self._name)], auto_join=True) rating_last_value = fields.Float('Rating Last Value', compute='_compute_rating_last_value', compute_sudo=True, store=True) - rating_last_feedback = fields.Text('Rating Last Feedback', related='rating_ids.feedback', readonly=False) - rating_last_image = fields.Binary('Rating Last Image', related='rating_ids.rating_image', readonly=False) + rating_last_feedback = fields.Text('Rating Last Feedback', related='rating_ids.feedback') + rating_last_image = fields.Binary('Rating Last Image', related='rating_ids.rating_image') rating_count = fields.Integer('Rating count', compute="_compute_rating_stats") rating_avg = fields.Float("Rating Average", compute='_compute_rating_stats')