From ec247ab4b308617ddf78bd72d67e8d94dd5a3a6a Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Thu, 3 Mar 2011 14:42:22 +0530
Subject: [PATCH 1/5] [REF]point_of_sale:change the old wizard style .change
dynamic field to one2many Field in pos_return.py
bzr revid: ron@tinyerp.com-20110303091222-tl0kfk2akmhdqign
---
addons/point_of_sale/wizard/pos_return.py | 129 +++++++++---------
.../point_of_sale/wizard/pos_return_view.xml | 26 ++++
2 files changed, 89 insertions(+), 66 deletions(-)
diff --git a/addons/point_of_sale/wizard/pos_return.py b/addons/point_of_sale/wizard/pos_return.py
index 810ef86ec7b..f86b96b04d5 100644
--- a/addons/point_of_sale/wizard/pos_return.py
+++ b/addons/point_of_sale/wizard/pos_return.py
@@ -24,9 +24,25 @@ from osv import osv,fields
from tools.translate import _
import time
+class pos_return_memory(osv.osv_memory):
+ _name = "pos.return.memory"
+ _rec_name = 'product_id'
+ _columns = {
+ 'product_id' : fields.many2one('product.product', string="Product", required=True),
+ 'quantity' : fields.float("Quantity", required=True),
+ 'pos_moves_id' : fields.many2one('pos.return', string="Move"),
+ 'line_id': fields.integer('Line Id'),
+ }
+
+pos_return_memory()
+
+
class pos_return(osv.osv_memory):
_name = 'pos.return'
_description = 'Point of sale return'
+ _columns = {
+ 'pos_moves_ids' : fields.one2many('pos.return.memory', 'pos_moves_id', 'Moves'),
+ }
def default_get(self, cr, uid, fields, context=None):
"""
@@ -41,38 +57,22 @@ class pos_return(osv.osv_memory):
@return: A dictionary which of fields with values.
"""
-
res = super(pos_return, self).default_get(cr, uid, fields, context=context)
order_obj = self.pool.get('pos.order')
if context is None:
context={}
active_ids = context.get('active_ids')
+ result=[]
+ memory={}
for order in order_obj.browse(cr, uid, active_ids, context=context):
for line in order.lines:
- if 'return%s'%(line.id) in fields:
- res['return%s'%(line.id)] = line.qty
- return res
-
- def view_init(self, cr, uid, fields_list, context=None):
- """
- Creates view dynamically and adding fields at runtime.
- @param self: The object pointer.
- @param cr: A database cursor
- @param uid: ID of the user currently logged in
- @param context: A standard dictionary
- @return: New arch of view with new columns.
- """
- res = super(pos_return, self).view_init(cr, uid, fields_list, context=context)
- order_obj=self.pool.get('pos.order')
- if context is None:
- context={}
-
- active_ids=context.get('active_ids')
- for order in order_obj.browse(cr, uid, active_ids, context=context):
- for line in order.lines:
- if 'return%s'%(line.id) not in self._columns:
- self._columns['return%s'%(line.id)] = fields.float("Quantity")
-
+ memory = {
+ 'product_id' : line.product_id.id,
+ 'quantity' : line.qty,
+ 'line_id':line.id
+ }
+ result.append(memory)
+ res.update({'pos_moves_ids': result})
return res
def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False,submenu=False):
@@ -99,23 +99,19 @@ class pos_return(osv.osv_memory):
if active_id:
_moves_arch_lst="""
"""
-
- result['arch'] = _moves_arch_lst
- result['fields'] = _line_fields
- return result
-
-
def create_returns(self, cr, uid, data, context=None):
"""
@param self: The object pointer.
diff --git a/addons/point_of_sale/wizard/pos_return_view.xml b/addons/point_of_sale/wizard/pos_return_view.xml
index 0a631d9577a..b5248e93654 100644
--- a/addons/point_of_sale/wizard/pos_return_view.xml
+++ b/addons/point_of_sale/wizard/pos_return_view.xml
@@ -1,13 +1,32 @@
-
-
- Return lines
- pos.return
- form
- form
- new
-
+
+
+ pos.return
+ pos.return
+ form
+
+
+
+
+
+
+ Return lines
+ pos.return
+ form
+ form
+ new
+
pos.return.memory
@@ -35,5 +54,5 @@
-
-
+
+
From 46a9cc35465a2c51625a1702d6ad02a1f8a17387 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 7 Mar 2011 11:54:32 +0530
Subject: [PATCH 4/5] [IMP]point_of_sale:code Optimize in pos_return.py
bzr revid: ron@tinyerp.com-20110307062432-dtrkxb9xuq6fmsvj
---
addons/point_of_sale/wizard/pos_return.py | 30 +++++++----------------
1 file changed, 9 insertions(+), 21 deletions(-)
diff --git a/addons/point_of_sale/wizard/pos_return.py b/addons/point_of_sale/wizard/pos_return.py
index 65a596d4dd3..c458044365f 100644
--- a/addons/point_of_sale/wizard/pos_return.py
+++ b/addons/point_of_sale/wizard/pos_return.py
@@ -63,15 +63,13 @@ class pos_return(osv.osv_memory):
context={}
active_ids = context.get('active_ids')
result=[]
- memory={}
for order in order_obj.browse(cr, uid, active_ids, context=context):
for line in order.lines:
- memory = {
+ result.append({
'product_id' : line.product_id.id,
'quantity' : line.qty,
'line_id':line.id
- }
- result.append(memory)
+ })
res.update({'pos_moves_ids': result})
return res
@@ -91,18 +89,11 @@ class pos_return(osv.osv_memory):
order_obj =self.pool.get('pos.order')
line_obj = self.pool.get('pos.order.line')
pos_current = order_obj.browse(cr, uid, context.get('active_id'), context=context)
- pos_line_ids = pos_current.lines
- if pos_line_ids:
- for pos_line in pos_line_ids:
- newline_vals = {}
- for record in current_rec.pos_moves_ids:
- if pos_line.id == record.line_id:
- less_qty = record.quantity
- pos_cur_line = line_obj.browse(cr, uid, pos_line.id, context=context)
- qty = pos_cur_line.qty
- qty = qty - less_qty
- newline_vals.update({'qty':qty})
- line_obj.write(cr, uid, pos_line.id, newline_vals, context=context)
+ for pos_line in pos_current.lines:
+ for record in current_rec.pos_moves_ids:
+ if pos_line.id == record.line_id:
+ less_qty = record.quantity
+ line_obj.write(cr, uid, pos_line.id, {'qty':pos_line.qty - less_qty}, context=context)
return {
'name': _('Add Product'),
'view_type': 'form',
@@ -156,11 +147,8 @@ class pos_return(osv.osv_memory):
for line in order_id.lines:
for record in data.pos_moves_ids:
if line.id == record.line_id:
- try:
- qty = record.quantity
- amount += qty * line.price_unit
- except :
- qty = line.qty
+ qty = record.quantity
+ amount += qty * line.price_unit
stock_move_obj.create(cr, uid, {
'product_qty': qty ,
'product_uos_qty': uom_obj._compute_qty(cr, uid, qty ,line.product_id.uom_id.id),
From c70f68837789ce02c5f32c3dac0bececb38397bd Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Wed, 9 Mar 2011 14:08:39 +0530
Subject: [PATCH 5/5] [IMP]point_of_sale:correct string and code improve for
property field
bzr revid: ron@tinyerp.com-20110309083839-pqfbqs85e2q6316m
---
addons/point_of_sale/wizard/pos_return.py | 13 +++----------
addons/point_of_sale/wizard/pos_return_view.xml | 4 ++--
2 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/addons/point_of_sale/wizard/pos_return.py b/addons/point_of_sale/wizard/pos_return.py
index c458044365f..e45e6984a9a 100644
--- a/addons/point_of_sale/wizard/pos_return.py
+++ b/addons/point_of_sale/wizard/pos_return.py
@@ -124,14 +124,12 @@ class pos_return(osv.osv_memory):
date_cur = time.strftime('%Y-%m-%d %H:%M:%S')
for order_id in order_obj.browse(cr, uid, [active_id], context=context):
- prop_ids = property_obj.search(cr, uid,[('name', '=', 'property_stock_customer')])
- val = property_obj.browse(cr, uid, prop_ids[0], context=context).value_reference
+ stock_dest_id = property_obj.get(cr, uid, 'property_stock_customer', 'res.partner', context=context).id
cr.execute("SELECT s.id FROM stock_location s, stock_warehouse w "
"WHERE w.lot_stock_id=s.id AND w.id=%s ",
(order_id.shop_id.warehouse_id.id,))
res = cr.fetchone()
location_id = res and res[0] or None
- stock_dest_id = val.id
new_picking = picking_obj.copy(cr, uid, order_id.picking_id.id, {'name':'%s (return)' % order_id.name,
'move_lines': [],
'state':'draft',
@@ -221,15 +219,12 @@ class add_product(osv.osv_memory):
for order_id in order_obj.browse(cr, uid, [active_id], context=context):
prod=data['product_id']
qty=data['quantity']
- prop_ids = property_obj.search(cr, uid, [('name', '=', 'property_stock_customer')])
- val = property_obj.browse(cr, uid, prop_ids[0]).value_reference
+ stock_dest_id = property_obj.get(cr, uid, 'property_stock_customer', 'res.partner', context=context).id
cr.execute("SELECT s.id FROM stock_location s, stock_warehouse w "
"WHERE w.lot_stock_id=s.id AND w.id=%s ",
(order_id.shop_id.warehouse_id.id,))
res=cr.fetchone()
location_id=res and res[0] or None
- stock_dest_id = val.id
-
prod_id=prod_obj.browse(cr, uid, prod, context=context)
new_picking=picking_obj.create(cr, uid, {
'name':'%s (Added)' %order_id.name,
@@ -288,14 +283,12 @@ class add_product(osv.osv_memory):
order_obj.add_product(cr, uid, active_ids[0], self_data['product_id'], self_data['quantity'], context=context)
for order_id in order_obj.browse(cr, uid, active_ids, context=context):
- prop_ids =property_obj.search(cr, uid, [('name', '=', 'property_stock_customer')])
- val = property_obj.browse(cr, uid, prop_ids[0]).value_reference
+ stock_dest_id = property_obj.get(cr, uid, 'property_stock_customer', 'res.partner', context=context).id
cr.execute("SELECT s.id FROM stock_location s, stock_warehouse w "
" WHERE w.lot_stock_id=s.id AND w.id=%s ",
(order_id.shop_id.warehouse_id.id,))
res=cr.fetchone()
location_id=res and res[0] or None
- stock_dest_id = val.id
order_obj.write(cr,uid,[order_id.id],{'type_rec':'Exchange'})
if order_id.invoice_id:
diff --git a/addons/point_of_sale/wizard/pos_return_view.xml b/addons/point_of_sale/wizard/pos_return_view.xml
index b5248e93654..7509b55b5d8 100644
--- a/addons/point_of_sale/wizard/pos_return_view.xml
+++ b/addons/point_of_sale/wizard/pos_return_view.xml
@@ -7,14 +7,14 @@
form