From c76297c4f832a759c3057589dcaa0bd67c24e69f Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Thu, 2 Oct 2014 10:13:29 +0200 Subject: [PATCH] [FIX] website: editor: ignore spurious changes for editable content Changes to contentEditable or attributeEditable attributes should not cause the corresponding section to be marked as dirty (oe_dirty). This would otherwise cause an extra editor save() for those, wrongly marking untouched templates as `noupdate`, and possibly triggering access right errors. --- addons/website/static/src/js/website.editor.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/addons/website/static/src/js/website.editor.js b/addons/website/static/src/js/website.editor.js index 82888c5d8a3..6d151dc1008 100644 --- a/addons/website/static/src/js/website.editor.js +++ b/addons/website/static/src/js/website.editor.js @@ -1924,9 +1924,10 @@ return false; } switch(m.type) { - case 'attributes': // ignore .cke_focus being added or removed - // ignore id modification - if (m.attributeName === 'id') { return false; } + case 'attributes': + // ignore special attributes and .cke_focus class being added or removed + var ignored_attrs = ['id', 'contenteditable', 'attributeeditable'] + if (_.contains(ignored_attrs, m.attributeName)) { return false; } // if attribute is not a class, can't be .cke_focus change if (m.attributeName !== 'class') { return true; }