From c70e7ebecab55951f2f0834e4f867f430414587d Mon Sep 17 00:00:00 2001
From: Adrien Dieudonne <adr@odoo.com>
Date: Fri, 21 Feb 2020 15:27:02 +0000
Subject: [PATCH] [FIX] account: invoice outstanding wrong displayed on mobile
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Steps to reproduce:
- Go to Invoicing
- Select an invoice
- Add credit note
- Click on "Post"
- Invoice footer is overlapped on mobile

This bug occured because of "float: right".
Get rid of this is too much work (oe_subtotal_footer is already floating),
so we decided to keep it with a "clear: both".
In desktop, this element is on the right of the screen but
on mobile we take the whole horizontal space.

closes odoo/odoo#46007

Task-id: 2184243
X-original-commit: 986152405a0ba6038df7d93c9264a46ee4207dd8
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
---
 addons/account/static/src/css/account.css   | 13 ++++++--
 addons/account/views/account_move_views.xml | 37 +++++++++------------
 2 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/addons/account/static/src/css/account.css b/addons/account/static/src/css/account.css
index 512fe608b72..c38173708c5 100644
--- a/addons/account/static/src/css/account.css
+++ b/addons/account/static/src/css/account.css
@@ -24,6 +24,15 @@
     color: grey;
 }
 
-.oe_invoice_outstanding_credits_debits tbody tr td{
-    padding-right: 0 !important;
+.oe_invoice_outstanding_credits_debits {
+    clear: both;
+    float: right;
+    min-width: 350px;
+}
+
+@media (max-width: 767.98px) {
+    .oe_invoice_outstanding_credits_debits {
+        min-width: initial;
+        width: 100%;
+    }
 }
diff --git a/addons/account/views/account_move_views.xml b/addons/account/views/account_move_views.xml
index 64950f612ed..004e7c7ae2e 100644
--- a/addons/account/views/account_move_views.xml
+++ b/addons/account/views/account_move_views.xml
@@ -834,28 +834,23 @@
                                 </field>
 
                                 <!-- Totals (only invoices / receipts) -->
-                                <group class="oe_right">
-                                    <group class="oe_subtotal_footer"
-                                       attrs="{'invisible': ['|', ('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund', 'out_receipt', 'in_receipt')),
-                                                                  ('payment_state' ,'=', 'invoicing_legacy')]}">
-                                        <field name="amount_tax" invisible="1"/>
-                                        <field name="amount_untaxed" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
-                                        <field name="amount_by_group" widget="tax-group-custom-field" nolabel="1" colspan="2" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
-                                        <field name="amount_total" attrs="{'invisible': [('amount_tax', '!=', 0)]}"/>
-                                        <field name="amount_total" class="oe_subtotal_footer_separator" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
-                                        <field name="invoice_payments_widget" colspan="2" nolabel="1" widget="payment"/>
-                                        <field name="amount_residual" class="oe_subtotal_footer_separator" attrs="{'invisible': [('state', '=', 'draft')]}"/>
-                                    </group>
-
-                                    <newline/>
-
-                                    <group class="oe_invoice_outstanding_credits_debits" style="width: 350px !important;">
-                                        <field name="invoice_outstanding_credits_debits_widget"
-                                            colspan="2" nolabel="1" widget="payment"
-                                            attrs="{'invisible': ['|', ('state', '!=', 'posted'), ('move_type', 'in', ('out_receipt', 'in_receipt'))]}"/>
-                                    </group>
-
+                                <group class="oe_subtotal_footer"
+                                    attrs="{'invisible': ['|', ('move_type', 'not in', ('out_invoice', 'out_refund', 'in_invoice', 'in_refund', 'out_receipt', 'in_receipt')),
+                                                               ('payment_state' ,'=', 'invoicing_legacy')]}">
+                                    <field name="amount_tax" invisible="1"/>
+                                    <field name="amount_untaxed" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
+                                    <field name="amount_by_group" widget="tax-group-custom-field" nolabel="1" colspan="2" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
+                                    <field name="amount_total" attrs="{'invisible': [('amount_tax', '!=', 0)]}"/>
+                                    <field name="amount_total" class="oe_subtotal_footer_separator" attrs="{'invisible': [('amount_tax', '=', 0)]}"/>
+                                    <field name="invoice_payments_widget" colspan="2" nolabel="1" widget="payment"/>
+                                    <field name="amount_residual" class="oe_subtotal_footer_separator" attrs="{'invisible': [('state', '=', 'draft')]}"/>
                                 </group>
+
+                                <field name="invoice_outstanding_credits_debits_widget"
+                                    class="oe_invoice_outstanding_credits_debits"
+                                    colspan="2" nolabel="1" widget="payment"
+                                    attrs="{'invisible': ['|', ('state', '!=', 'posted'), ('move_type', 'in', ('out_receipt', 'in_receipt'))]}"/>
+
                                 <!-- Internal note -->
                                 <field name="narration" placeholder="Terms and Conditions" nolabel="1" height="50"/>
                             </page>