From c6a0ff52f9727b18f888d6bf8a16c6fdca88d021 Mon Sep 17 00:00:00 2001 From: Martin Geubelle Date: Tue, 2 May 2017 11:50:56 +0200 Subject: [PATCH] [FIX] web: Kanban: fallback on empty array for x2many raw_value The commit e07f27d has wrongly changed the fallback for one2many raw_value from an empty array to `false`. This modification brokes a lot of templates where we assume that the value is always an array. This commit restores the previous behavior with the fallback on []. --- addons/web/static/src/js/views/kanban/kanban_record.js | 2 +- addons/web/static/tests/views/kanban_tests.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/js/views/kanban/kanban_record.js b/addons/web/static/src/js/views/kanban/kanban_record.js index 5434ed7da72..c22a10ce6e6 100644 --- a/addons/web/static/src/js/views/kanban/kanban_record.js +++ b/addons/web/static/src/js/views/kanban/kanban_record.js @@ -368,7 +368,7 @@ var KanbanRecord = Widget.extend({ if ((r.type === 'date' || r.type === 'datetime') && value) { r.raw_value = value.toDate(); } else if (r.type === 'one2many' || r.type === 'many2many') { - r.raw_value = value.count ? value.res_ids : false; + r.raw_value = value.count ? value.res_ids : []; } else if (r.type === 'many2one' ) { r.raw_value = value && value.res_id || false; } else { diff --git a/addons/web/static/tests/views/kanban_tests.js b/addons/web/static/tests/views/kanban_tests.js index d7ef88d4c94..d804ab35d71 100644 --- a/addons/web/static/tests/views/kanban_tests.js +++ b/addons/web/static/tests/views/kanban_tests.js @@ -1031,7 +1031,7 @@ QUnit.module('Views', { '' + '
' + '' + - '' + + '' + '
' + '
' + '',