From c63c225274c4e6b0647e24fda91f72de4f046430 Mon Sep 17 00:00:00 2001 From: Devendra Kavthekar Date: Thu, 13 Oct 2016 19:31:22 +0530 Subject: [PATCH] [FIX] web: is_false() for reference field widget. (#9335) In the widget, the value of reference field is a pair `[val1, val2]`. When the field is blank, its value is `[false,false]`, thus checking `[false,false] === false` never succeeds, and this breaks the check for required fields. --- addons/web/static/src/js/views/form_widgets.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/addons/web/static/src/js/views/form_widgets.js b/addons/web/static/src/js/views/form_widgets.js index 3b630d4232d..15acd788263 100644 --- a/addons/web/static/src/js/views/form_widgets.js +++ b/addons/web/static/src/js/views/form_widgets.js @@ -1152,6 +1152,9 @@ var FieldReference = common.AbstractField.extend(common.ReinitializeFieldMixin, this.m2o.do_toggle(!!this.get('value')[0]); this.reference_ready = true; }, + is_false: function() { + return this.get('value')[0] == false || this.get('value')[1] == false; + }, }); var FieldBinary = common.AbstractField.extend(common.ReinitializeFieldMixin, {