From c5cefea2dca7924c8787457f5759ddb1cdf0d3b8 Mon Sep 17 00:00:00 2001 From: "kdeb@odoo.com" Date: Tue, 26 Mar 2024 12:56:59 +0000 Subject: [PATCH] [FIX] iap: add generic email domains to _MAIL_DOMAIN_BLACKLIST Issue: When we have open tickets from anyone with the email domain @proton.me, they are linked together even though this domain is generic, not a private one. same issue with @cegetel.net and @dbmail.com Steps To Reproduce: - Create three tickets with "@proton.me" domain but different addresses. - See that in the smart button, the tickets are linked to each other even though the customers are different. Solution: - in `_compute_partner_ticket_count` we check if the email domain of the partner is in `iap_tools._MAIL_DOMAIN_BLACKLIST `, if not, we consider the email to be a company email which tickets can be grouped by. - the _MAIL_DOMAIN_BLACKLIST is a list of generic email providers on which IAP services should not run. Retrieving company information from them makes no sense. - To fix this issue I added `proton.me`, `cegetel.net` and `dbmail.com` to _MAIL_DOMAIN_BLACKLIST opw-3786308 closes odoo/odoo#160804 X-original-commit: 0258fccc217142e66873c1dbb99efbfdd70a3887 Signed-off-by: Louis Baudoux (lba) Signed-off-by: Kawtar Drissi El Bouzaidi (kdeb) --- addons/iap/tools/iap_tools.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/addons/iap/tools/iap_tools.py b/addons/iap/tools/iap_tools.py index 10b7ad3c1c1..bc58f4b83f1 100644 --- a/addons/iap/tools/iap_tools.py +++ b/addons/iap/tools/iap_tools.py @@ -21,7 +21,6 @@ DEFAULT_ENDPOINT = 'https://iap.odoo.com' #---------------------------------------------------------- _MAIL_DOMAIN_BLACKLIST = set([ - # Top 100 email providers on SaaS at 2020-10 'gmail.com', 'hotmail.com', 'yahoo.com', 'qq.com', 'outlook.com', '163.com', 'yahoo.fr', 'live.com', 'hotmail.fr', 'icloud.com', '126.com', 'me.com', 'free.fr', 'ymail.com', 'msn.com', 'mail.com', 'orange.fr', 'aol.com', 'wanadoo.fr', 'live.fr', 'mail.ru', 'yahoo.co.in', 'rediffmail.com', 'hku.hk', 'googlemail.com', 'gmx.de', 'sina.com', 'skynet.be', 'laposte.net', 'yahoo.co.uk', 'yahoo.co.id', 'web.de', @@ -44,7 +43,7 @@ _MAIL_DOMAIN_BLACKLIST = set([ 'freemail.hu', 'live.it', 'blackwaretech.com', 'byom.de', 'dispostable.com', 'dayrep.com', 'aim.com', 'prixgen.com', 'gmail.om', 'asterisk-tech.mn', 'in.com', 'aliceadsl.fr', 'lycos.com', 'topnet.tn', 'teleworm.us', 'kedgebs.com', 'supinfo.com', 'posteo.de', 'yahoo.com ', 'op.pl', 'gmail.fr', 'grr.la', 'oci.fr', 'aselcis.com', 'optusnet.com.au', 'mailcatch.com', 'rambler.ru', 'protonmail.ch', - 'prisme.ch', 'bbox.fr', 'orbitalu.com', 'netcourrier.com', 'iinet.net.au', + 'prisme.ch', 'bbox.fr', 'orbitalu.com', 'netcourrier.com', 'iinet.net.au', 'cegetel.net', 'proton.me', 'dbmail.com', # Dummy entries 'example.com', ])