From c5ae9b38d1816f4fc3c29907fe8e370c78ed3d4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20Warnon?= Date: Mon, 30 Mar 2020 07:45:55 +0000 Subject: [PATCH] [FIX] survey: fix some issues == Fix results scored question display == This commit fixes the display for scored choice question. The text "Right answer" was displayed twice. == Add default values to avoid constraints inconsistencies == This commit adds a 0 default values to some of our validation fields on survey questions. Without a default value, the ORM would store "NULL" in the fields and then allow users to define a "min" without a "max", that would result in an error while trying to validate the answers to that question. Furthermore, when creating a question from the frontend, the web framework will always send 0 for all field values anyway. The code change adds consistency and avoids potential errors on that issue. LINKS Task 2208574 closes odoo/odoo#48371 Signed-off-by: Thibault Delavallee (tde) --- addons/survey/models/survey_question.py | 8 ++++---- addons/survey/views/survey_templates_statistics.xml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/addons/survey/models/survey_question.py b/addons/survey/models/survey_question.py index 54ae51e0ec1..8da3acce891 100644 --- a/addons/survey/models/survey_question.py +++ b/addons/survey/models/survey_question.py @@ -123,10 +123,10 @@ class SurveyQuestion(models.Model): # question validation validation_required = fields.Boolean('Validate entry') validation_email = fields.Boolean('Input must be an email') - validation_length_min = fields.Integer('Minimum Text Length') - validation_length_max = fields.Integer('Maximum Text Length') - validation_min_float_value = fields.Float('Minimum value') - validation_max_float_value = fields.Float('Maximum value') + validation_length_min = fields.Integer('Minimum Text Length', default=0) + validation_length_max = fields.Integer('Maximum Text Length', default=0) + validation_min_float_value = fields.Float('Minimum value', default=0.0) + validation_max_float_value = fields.Float('Maximum value', default=0.0) validation_min_date = fields.Date('Minimum Date') validation_max_date = fields.Date('Maximum Date') validation_min_datetime = fields.Datetime('Minimum Datetime') diff --git a/addons/survey/views/survey_templates_statistics.xml b/addons/survey/views/survey_templates_statistics.xml index c738e6a80ba..c22f2b7b9ca 100644 --- a/addons/survey/views/survey_templates_statistics.xml +++ b/addons/survey/views/survey_templates_statistics.xml @@ -86,7 +86,7 @@ - + Right answer: