From c4bbe13fdfa410e4b7ad1fbb32b65ee10e9069c5 Mon Sep 17 00:00:00 2001
From: Julien Giannone <jgi@odoo.com>
Date: Thu, 3 Feb 2022 13:45:43 +0000
Subject: [PATCH] [FIX] mail: click on link in a message preview while replying
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When clicking on a mention (or a link) within the preview of the
message we're replying to, there was a traceback because we tried
to update a component which has already been deleted.

closes odoo/odoo#83912

Task-id: 2747321
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
---
 addons/mail/static/src/components/message_list/message_list.js | 3 +++
 addons/mail/static/src/models/message_view/message_view.js     | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/addons/mail/static/src/components/message_list/message_list.js b/addons/mail/static/src/components/message_list/message_list.js
index 63b8e23c56b..82bfeb4a982 100644
--- a/addons/mail/static/src/components/message_list/message_list.js
+++ b/addons/mail/static/src/components/message_list/message_list.js
@@ -337,6 +337,9 @@ export class MessageList extends Component {
      * @param {ScrollEvent} ev
      */
     _onScrollThrottled(ev) {
+        if (!this.messageListView) {
+            return;
+        }
         const {
             orderedMessages,
             thread,
diff --git a/addons/mail/static/src/models/message_view/message_view.js b/addons/mail/static/src/models/message_view/message_view.js
index 4d1ab22dc0c..76c669559bd 100644
--- a/addons/mail/static/src/models/message_view/message_view.js
+++ b/addons/mail/static/src/models/message_view/message_view.js
@@ -17,6 +17,9 @@ registerModel({
             this.update({
                 isHighlighted: true,
                 highlightTimeout: this.env.browser.setTimeout(() => {
+                    if (!this.exists()) {
+                        return;
+                    }
                     this.update({ isHighlighted: false });
                 }, 2000),
             });