From c0c6be8dd1048594dc699fd38bc6d6e3331dc9f5 Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Mon, 19 Apr 2021 13:17:55 +0000 Subject: [PATCH] [FIX] web: properly unpatch session after each test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, `getTZOffset` and `user_has_group` weren't correctly reset to their initial values after tests. As a consequence tests executed afterwards might behave unexpectedly. closes odoo/odoo#69497 X-original-commit: b7b83db88c61d7db87045d87b09d7348f3a8a9eb Signed-off-by: Géry Debongnie (ged) Signed-off-by: Aaron Bohy (aab) --- addons/web/static/tests/helpers/test_utils_mock.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/addons/web/static/tests/helpers/test_utils_mock.js b/addons/web/static/tests/helpers/test_utils_mock.js index c7bc927fbe3..8cf2c79e528 100644 --- a/addons/web/static/tests/helpers/test_utils_mock.js +++ b/addons/web/static/tests/helpers/test_utils_mock.js @@ -174,11 +174,12 @@ async function _getMockedOwlEnv(params, mockServer) { function _mockGlobalObjects(params) { // store initial session state (for restoration) const initialSession = Object.assign({}, session); - // patch session - Object.assign(session, { + const sessionPatch = Object.assign({ getTZOffset() { return 0; }, async user_has_group() { return false; }, }, params.session); + // patch session + Object.assign(session, sessionPatch); // patch config let initialConfig; @@ -203,10 +204,8 @@ function _mockGlobalObjects(params) { // build the cleanUp function to restore everything at the end of the test function cleanUp() { let key; - if ('session' in params) { - for (key in session) { - delete session[key]; - } + for (key in sessionPatch) { + delete session[key]; } Object.assign(session, initialSession); if ('config' in params) {