From bfd5af76467d71f068234d021c869bbbf41fd2b1 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Mon, 16 May 2022 10:19:40 +0000
Subject: [PATCH] [FIX] sale_stock: rely on views priority instead of hacks

for views button ordering

closes odoo/odoo#91462

Related: odoo/upgrade#3522
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 addons/sale_stock/views/stock_views.xml | 32 +------------------------
 addons/stock/views/product_views.xml    |  1 +
 2 files changed, 2 insertions(+), 31 deletions(-)

diff --git a/addons/sale_stock/views/stock_views.xml b/addons/sale_stock/views/stock_views.xml
index 798eff39f10..0adce7469b4 100644
--- a/addons/sale_stock/views/stock_views.xml
+++ b/addons/sale_stock/views/stock_views.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <data>
+
         <menuitem id="menu_aftersale" name="After-Sale"
             groups="sales_team.group_sale_salesman"
             parent="sale.sale_menu_root" sequence="5" />
@@ -17,34 +17,4 @@
             </field>
         </record>
 
-        <record id="product_template_view_form_inherit_sale" model="ir.ui.view">
-            <field name="name">product.template.inherit.form</field>
-            <field name="inherit_id" ref="sale.product_template_form_view_sale_order_button"/>
-            <field name="model">product.template</field>
-            <field name="arch" type="xml">
-                <xpath expr="//button[@name='action_view_sales']" position="replace" />
-            </field>
-        </record>
-
-        <record id="product_template_view_form_inherit_stock" model="ir.ui.view">
-            <field name="name">product.template.inherit.form</field>
-            <field name="inherit_id" ref="stock.product_template_form_view_procurement_button"/>
-            <field name="model">product.template</field>
-            <field name="arch" type="xml">
-                <button name="action_view_orderpoints" position="after">
-                    <button class="oe_stat_button" name="action_view_sales"
-                        type="object" icon="fa-signal" attrs="{'invisible': [('sale_ok', '=', False)]}"
-                        groups="sales_team.group_sale_salesman" help="Sold in the last 365 days">
-                        <div class="o_field_widget o_stat_info">
-                            <span class="o_stat_value">
-                                <field name="sales_count" widget="statinfo" nolabel="1" class="mr4"/>
-                                <field name="uom_name"/>
-                            </span>
-                            <span class="o_stat_text">Sold</span>
-                        </div>
-                    </button>
-                </button>
-            </field>
-        </record>
-    </data>
 </odoo>
diff --git a/addons/stock/views/product_views.xml b/addons/stock/views/product_views.xml
index 7a7b2986429..f1557646819 100644
--- a/addons/stock/views/product_views.xml
+++ b/addons/stock/views/product_views.xml
@@ -343,6 +343,7 @@
             <field name="model">product.template</field>
             <field name="groups_id" eval="[(4, ref('stock.group_stock_user'))]"/>
             <field name="inherit_id" ref="product.product_template_only_form_view"/>
+            <field name="priority" eval="15"/>
             <field name="arch" type="xml">
                 <data>
                     <header position="inside" >