From bf72e97065e3345b3a28b796f8d59f3b5a8575a9 Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Thu, 16 Jun 2011 18:03:17 +0200 Subject: [PATCH] [FIX] users_ldap: consistent handling of login() vs check() Explicit check for blank passwords was introduced recently in check() for bug 760301, but login() did not behave the same so the resulting error message would be inconsistent. lp bug: https://launchpad.net/bugs/760301 fixed bzr revid: odo@openerp.com-20110616160317-4hfw5e360e600pgq --- addons/users_ldap/users_ldap.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/addons/users_ldap/users_ldap.py b/addons/users_ldap/users_ldap.py index e4fec6a391f..14d985e5f92 100644 --- a/addons/users_ldap/users_ldap.py +++ b/addons/users_ldap/users_ldap.py @@ -66,6 +66,11 @@ res_company() class users(osv.osv): _inherit = "res.users" def login(self, db, login, password): + + if not password: + # empty passwords are disallowed for obvious security reasons + return False + ret = super(users,self).login(db, login, password) if ret: return ret