From bee69d3b2df3bc4f480d5c22c11dcc09648fb810 Mon Sep 17 00:00:00 2001
From: qsm-odoo <qsm@odoo.com>
Date: Thu, 24 Aug 2017 14:39:58 +0200
Subject: [PATCH] [REF] *: get rid of o_visible and o_invisible in kanban

* account, hr, hr_recruitment, maintenance, mrp, point_of_sale,
  project, sales_team, stock
---
 .../static/src/less/account_journal_dashboard.less |  4 ----
 .../views/account_journal_dashboard_view.xml       | 14 +++++++-------
 addons/hr/views/hr_views.xml                       |  4 ++--
 addons/hr_recruitment/views/hr_job_views.xml       |  4 ++--
 addons/maintenance/views/maintenance_views.xml     |  8 ++++----
 addons/mrp/views/mrp_workcenter_views.xml          | 10 +++++-----
 addons/mrp/views/stock_picking_views.xml           |  4 ++--
 .../views/point_of_sale_dashboard.xml              |  4 ++--
 addons/project/views/project_views.xml             |  4 ++--
 addons/sales_team/views/sales_team_dashboard.xml   |  4 ++--
 addons/stock/views/stock_picking_views.xml         |  4 ++--
 11 files changed, 30 insertions(+), 34 deletions(-)

diff --git a/addons/account/static/src/less/account_journal_dashboard.less b/addons/account/static/src/less/account_journal_dashboard.less
index fd73dc9dfe3..a61d7aebf01 100644
--- a/addons/account/static/src/less/account_journal_dashboard.less
+++ b/addons/account/static/src/less/account_journal_dashboard.less
@@ -108,7 +108,3 @@
         }
     }
 }
-
-.o_invisible .o_dashboard_graph {
-    display: none; // This fix a bug on firefox
-}
diff --git a/addons/account/views/account_journal_dashboard_view.xml b/addons/account/views/account_journal_dashboard_view.xml
index 80a21554cdd..210d1f1d106 100644
--- a/addons/account/views/account_journal_dashboard_view.xml
+++ b/addons/account/views/account_journal_dashboard_view.xml
@@ -16,7 +16,7 @@
                             <t t-value="JSON.parse(record.kanban_dashboard.raw_value)" t-set="dashboard"/>
                             <t t-value="record.type.raw_value" t-set="journal_type"/>
                             <t t-call="JournalTop"/>
-                            <div class="container o_kanban_card_content o_visible">
+                            <div class="container o_kanban_card_content">
                                 <div class="row">
                                     <t t-if="(journal_type == 'bank' || journal_type == 'cash')" t-call="JournalBodyBankCash"/>
                                     <t t-if="journal_type == 'sale' || journal_type == 'purchase'" t-call="JournalBodySalePurchase"/>
@@ -29,7 +29,7 @@
                                     </t>
                                 </div>
                                 <t t-if="journal_type == 'bank' || journal_type == 'cash' || journal_type == 'sale' || journal_type == 'purchase'" t-call="JournalBodyGraph"/>
-                            </div><div class="container o_kanban_card_manage_pane o_invisible">
+                            </div><div class="container o_kanban_card_manage_pane">
                                 <t t-call="JournalManage"/>
                             </div>
                         </div>
@@ -288,13 +288,13 @@
                                 </div>
                             </div>
                             <div class="row">
-                                <div class="col-xs-6">                                    
-                                    <a type="object" t-if="journal_type == 'sale'" name="open_action" 
+                                <div class="col-xs-6">
+                                    <a type="object" t-if="journal_type == 'sale'" name="open_action"
                                     context="{'search_default_unpaid':1}" id="account_dashboard_sale_pay_link">
-                                        <t t-esc="dashboard.number_waiting"/> Awaiting payments 
+                                        <t t-esc="dashboard.number_waiting"/> Awaiting payments
                                     </a>
-                                    
-                                    <a type="object" t-if="journal_type == 'purchase'" name="open_action" 
+
+                                    <a type="object" t-if="journal_type == 'purchase'" name="open_action"
                                     context="{'search_default_unpaid':1}" id="account_dashboard_purchase_pay_link">
                                         <t t-esc="dashboard.number_waiting"/> Payments to do
                                     </a>
diff --git a/addons/hr/views/hr_views.xml b/addons/hr/views/hr_views.xml
index cf21ae2f4a6..ef433a637cb 100644
--- a/addons/hr/views/hr_views.xml
+++ b/addons/hr/views/hr_views.xml
@@ -526,7 +526,7 @@
                                         <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                     </div>
                                 </div>
-                                <div class="container o_kanban_card_content o_visible">
+                                <div class="container o_kanban_card_content">
                                     <div class="row">
                                         <div class="col-xs-6 o_kanban_primary_left">
                                             <button class="btn btn-primary" name="%(act_employee_from_department)d" type="action">Employees</button>
@@ -534,7 +534,7 @@
                                         <div class="col-xs-6 o_kanban_primary_right">
                                         </div>
                                     </div>
-                                </div><div class="container o_kanban_card_manage_pane o_invisible">
+                                </div><div class="container o_kanban_card_manage_pane">
                                     <div class="row">
                                         <div class="col-xs-4 o_kanban_card_manage_section o_kanban_manage_to_do">
                                             <div class="o_kanban_card_manage_title">
diff --git a/addons/hr_recruitment/views/hr_job_views.xml b/addons/hr_recruitment/views/hr_job_views.xml
index 489b82618fe..03374409c42 100644
--- a/addons/hr_recruitment/views/hr_job_views.xml
+++ b/addons/hr_recruitment/views/hr_job_views.xml
@@ -37,7 +37,7 @@
                                     <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                 </div>
                             </div>
-                            <div class="container o_kanban_card_content o_visible">
+                            <div class="container o_kanban_card_content">
                                 <t t-if="record.state.raw_value == 'recruit'">
                                     <div class="row">
                                         <div class="col-xs-6 o_kanban_primary_left">
@@ -67,7 +67,7 @@
                                         </div>
                                     </div>
                                 </t>
-                            </div><div class="container o_kanban_card_manage_pane o_invisible">
+                            </div><div class="container o_kanban_card_manage_pane">
                                 <div class="row">
                                     <div class="col-xs-4 o_kanban_card_manage_section o_kanban_manage_view">
                                         <div class="o_kanban_card_manage_title">
diff --git a/addons/maintenance/views/maintenance_views.xml b/addons/maintenance/views/maintenance_views.xml
index 2c8df9070ec..da979db5952 100644
--- a/addons/maintenance/views/maintenance_views.xml
+++ b/addons/maintenance/views/maintenance_views.xml
@@ -755,7 +755,7 @@
                                     <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                 </div>
                             </div>
-                            <div class="container o_kanban_card_content o_visible">
+                            <div class="container o_kanban_card_content">
                                 <div class="row">
                                     <div class="col-xs-6 o_kanban_primary_left">
                                         <button class="btn btn-primary" name="%(hr_equipment_todo_request_action_from_dashboard)d" type="action" context="{'search_default_todo': 1}">
@@ -799,7 +799,7 @@
                                         </div>
                                     </div>
                                 </div>
-                            </div><div class="container o_kanban_card_manage_pane o_invisible">
+                            </div><div class="container o_kanban_card_manage_pane">
                                 <div class="row">
                                     <div class="col-xs-6 o_kanban_card_manage_section o_kanban_manage_view">
                                         <div class="o_kanban_card_manage_title">
@@ -895,7 +895,7 @@
         sequence="0"/>
 
     <menuitem
-        id="menu_m_request" 
+        id="menu_m_request"
         name="Maintenance"
         parent="menu_maintenance_title"
         groups="group_equipment_manager,base.group_user"
@@ -926,7 +926,7 @@
         sequence="2"/>
 
     <menuitem
-        id="menu_m_reports" 
+        id="menu_m_reports"
         name="Reporting"
         parent="menu_maintenance_title"
         groups="group_equipment_manager,base.group_user"
diff --git a/addons/mrp/views/mrp_workcenter_views.xml b/addons/mrp/views/mrp_workcenter_views.xml
index 9f340a36671..0fac28477f3 100644
--- a/addons/mrp/views/mrp_workcenter_views.xml
+++ b/addons/mrp/views/mrp_workcenter_views.xml
@@ -77,7 +77,7 @@
             <field name="res_model">mrp.workcenter.productivity</field>
             <field name="view_type">form</field>
             <field name="view_mode">tree,form,graph,pivot</field>
-            <field name="context">{'search_default_availability': '1', 
+            <field name="context">{'search_default_availability': '1',
                                    'search_default_performance': '1',
                                    'search_default_quality': '1',
                                    'default_workcenter_id': active_id,
@@ -129,7 +129,7 @@
                                         <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                     </div>
                                 </div>
-                                <div class="container o_kanban_card_content o_visible">
+                                <div class="container o_kanban_card_content">
                                     <div class="row">
                                         <div class="col-xs-6 o_kanban_primary_left">
                                             <div class="btn-group" name="o_wo">
@@ -203,7 +203,7 @@
                                                 attrs="{'invisible': [('working_state','in',('normal','blocked'))]}"/>
                                         </div>
                                     </div>
-                                </div><div class="container o_kanban_card_manage_pane o_invisible">
+                                </div><div class="container o_kanban_card_manage_pane">
                                     <div class="row">
                                         <div class="col-xs-6 o_kanban_card_manage_section o_kanban_manage_view">
                                             <div class="o_kanban_card_manage_title">
@@ -375,7 +375,7 @@
               </p><p>
                 Manufacturing operations are processed at Work Centers. A Work Center can be composed of
                 workers and/or machines, they are used for costing, scheduling, capacity planning, etc.
-                The Work Centers are defined on the Routing's operations. 
+                The Work Centers are defined on the Routing's operations.
               </p>
             </field>
         </record>
@@ -592,4 +592,4 @@
           groups="group_mrp_routings"
           sequence="12"/>
     </data>
-</odoo>
\ No newline at end of file
+</odoo>
diff --git a/addons/mrp/views/stock_picking_views.xml b/addons/mrp/views/stock_picking_views.xml
index 5c8f525fb9b..d82e1bf6fbf 100644
--- a/addons/mrp/views/stock_picking_views.xml
+++ b/addons/mrp/views/stock_picking_views.xml
@@ -25,7 +25,7 @@
                                 <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                             </div>
                         </div>
-                        <div class="container o_kanban_card_content o_visible">
+                        <div class="container o_kanban_card_content">
                             <div class="row">
                                 <div class="col-xs-6 o_kanban_primary_left">
                                     <button class="btn btn-primary" name="%(mrp_production_action_picking_deshboard)d" type="action" context="{'search_default_todo': 1}">
@@ -55,7 +55,7 @@
                                     </div>
                                 </div>
                             </div>
-                        </div><div class="container o_kanban_card_manage_pane o_invisible">
+                        </div><div class="container o_kanban_card_manage_pane">
                             <div class="row">
                                 <div class="col-xs-6 o_kanban_card_manage_section o_kanban_manage_view" name="picking_left_manage_pane">
                                     <div class="o_kanban_card_manage_title">
diff --git a/addons/point_of_sale/views/point_of_sale_dashboard.xml b/addons/point_of_sale/views/point_of_sale_dashboard.xml
index fa42bbee80b..3c8c9e073b0 100644
--- a/addons/point_of_sale/views/point_of_sale_dashboard.xml
+++ b/addons/point_of_sale/views/point_of_sale_dashboard.xml
@@ -77,7 +77,7 @@
                                     <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                 </div>
                             </div>
-                            <div class="container o_kanban_card_content o_visible">
+                            <div class="container o_kanban_card_content">
                                 <div class="row">
                                     <div class="col-xs-6 o_kanban_primary_left">
                                         <button t-if="record.current_session_state.raw_value === 'opened'" class="btn btn-primary" name="open_ui" type="object">Resume</button>
@@ -110,7 +110,7 @@
                                         </div>
                                     </div>
                                 </div>
-                            </div><div class="container o_kanban_card_manage_pane o_invisible">
+                            </div><div class="container o_kanban_card_manage_pane">
                                 <div class="row">
                                     <div class="col-xs-6 o_kanban_card_manage_section o_kanban_manage_view">
                                         <div class="o_kanban_card_manage_title">
diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 439e869a61e..d3180ec4cef 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -268,7 +268,7 @@
                         <t t-name="kanban-box">
                             <div t-attf-class="#{kanban_color(record.color.raw_value)} oe_kanban_global_click o_has_icon">
                                 <div class="o_project_kanban_main">
-                                    <div class="o_kanban_card_content o_visible">
+                                    <div class="o_kanban_card_content">
                                         <div class="o_kanban_primary_left">
                                             <div class="o_primary">
                                                 <span><t t-esc="record.name.value"/></span>
@@ -281,7 +281,7 @@
                                             </div>
                                         </div>
                                     </div>
-                                    <div class="o_kanban_card_manage_pane o_invisible">
+                                    <div class="o_kanban_card_manage_pane">
                                         <div class="o_kanban_card_manage_section o_kanban_manage_reports">
                                             <div groups="project.group_project_manager">
                                                 <a type="edit">Settings</a>
diff --git a/addons/sales_team/views/sales_team_dashboard.xml b/addons/sales_team/views/sales_team_dashboard.xml
index f17d83cbc87..e77949ad667 100644
--- a/addons/sales_team/views/sales_team_dashboard.xml
+++ b/addons/sales_team/views/sales_team_dashboard.xml
@@ -23,7 +23,7 @@
                                     <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                 </div>
                             </div>
-                            <div class="container o_kanban_card_content o_visible">
+                            <div class="container o_kanban_card_content">
                                 <div class="row o_kanban_card_upper_content">
                                     <div class="col-xs-6 o_kanban_primary_left" name="to_replace_in_sale_crm">
                                         <button type="object" class="btn btn-primary" name="action_primary_channel_button"><field name="dashboard_button_name"/></button>
@@ -41,7 +41,7 @@
                                     <div class="col-xs-12 o_kanban_primary_bottom bottom_block">
                                     </div>
                                 </div>
-                            </div><div class="container o_kanban_card_manage_pane o_invisible">
+                            </div><div class="container o_kanban_card_manage_pane">
                                 <div class="row">
                                     <div class="col-xs-4 o_kanban_card_manage_section o_kanban_manage_view">
                                         <div class="o_kanban_card_manage_title">
diff --git a/addons/stock/views/stock_picking_views.xml b/addons/stock/views/stock_picking_views.xml
index 07ede1a9f9f..41ae7d7035a 100644
--- a/addons/stock/views/stock_picking_views.xml
+++ b/addons/stock/views/stock_picking_views.xml
@@ -632,7 +632,7 @@
                                             <a class="o_kanban_manage_toggle_button" href="#"><i class="fa fa-ellipsis-v" /></a>
                                         </div>
                                     </div>
-                                    <div class="container o_kanban_card_content o_visible">
+                                    <div class="container o_kanban_card_content">
                                         <div class="row">
                                             <div class="col-xs-6 o_kanban_primary_left">
                                                 <button class="btn btn-primary" name="get_action_picking_tree_ready" type="object">
@@ -679,7 +679,7 @@
                                                 </div>
                                             </div>
                                         </div>
-                                    </div><div class="container o_kanban_card_manage_pane o_invisible">
+                                    </div><div class="container o_kanban_card_manage_pane">
                                         <div class="row">
                                             <div class="col-xs-6 o_kanban_card_manage_section o_kanban_manage_view">
                                                 <div class="o_kanban_card_manage_title">