From bee407d8d751e22c73070ecb5a37593c6557ee0e Mon Sep 17 00:00:00 2001
From: David Tran <david.tran@tvtmarine.com>
Date: Fri, 2 Dec 2016 19:53:50 +0700
Subject: [PATCH] [IMP] crm: improve crm opportunity report extendability

split SQL query inside the init method of the model
'crm.opportunity.report' into multiple methods (i.e.
_select, _from, _join, _where, _group_by) to bring ease for other
modules to inherit

Closes #14568
---
 addons/crm/report/crm_opportunity_report.py | 113 ++++++++++++--------
 1 file changed, 71 insertions(+), 42 deletions(-)

diff --git a/addons/crm/report/crm_opportunity_report.py b/addons/crm/report/crm_opportunity_report.py
index 5bf8abc1d8d..9bf2f14fd06 100644
--- a/addons/crm/report/crm_opportunity_report.py
+++ b/addons/crm/report/crm_opportunity_report.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
-from odoo import fields, models, tools
+from odoo import fields, models, tools, api
 
 from ..models import crm_stage
 
@@ -48,47 +48,76 @@ class OpportunityReport(models.Model):
     source_id = fields.Many2one('utm.source', string='Source', readonly=True)
     medium_id = fields.Many2one('utm.medium', string='Medium', readonly=True)
 
-    def init(self):
-        tools.drop_view_if_exists(self._cr, 'crm_opportunity_report')
-        self._cr.execute("""
-            CREATE VIEW crm_opportunity_report AS (
-                SELECT
-                    c.id,
-                    c.date_deadline,
+    def _select(self):
+        select_str = """
+        SELECT
+            c.id,
+            c.date_deadline,
 
-                    c.date_open as opening_date,
-                    c.date_closed as date_closed,
-                    c.date_last_stage_update as date_last_stage_update,
+            c.date_open as opening_date,
+            c.date_closed as date_closed,
+            c.date_last_stage_update as date_last_stage_update,
 
-                    c.user_id,
-                    c.probability,
-                    c.stage_id,
-                    stage.name as stage_name,
-                    c.type,
-                    c.company_id,
-                    c.priority,
-                    c.team_id,
-                    (SELECT COUNT(*)
-                     FROM mail_message m
-                     WHERE m.model = 'crm.lead' and m.res_id = c.id) as nbr_activities,
-                    c.active,
-                    c.campaign_id,
-                    c.source_id,
-                    c.medium_id,
-                    c.partner_id,
-                    c.city,
-                    c.country_id,
-                    c.planned_revenue as total_revenue,
-                    c.planned_revenue*(c.probability/100) as expected_revenue,
-                    c.create_date as create_date,
-                    extract('epoch' from (c.date_closed-c.create_date))/(3600*24) as  delay_close,
-                    abs(extract('epoch' from (c.date_deadline - c.date_closed))/(3600*24)) as  delay_expected,
-                    extract('epoch' from (c.date_open-c.create_date))/(3600*24) as  delay_open,
-                    c.lost_reason,
-                    c.date_conversion as date_conversion
-                FROM
+            c.user_id,
+            c.probability,
+            c.stage_id,
+            stage.name as stage_name,
+            c.type,
+            c.company_id,
+            c.priority,
+            c.team_id,
+            (SELECT COUNT(*)
+             FROM mail_message m
+             WHERE m.model = 'crm.lead' and m.res_id = c.id) as nbr_activities,
+            c.active,
+            c.campaign_id,
+            c.source_id,
+            c.medium_id,
+            c.partner_id,
+            c.city,
+            c.country_id,
+            c.planned_revenue as total_revenue,
+            c.planned_revenue*(c.probability/100) as expected_revenue,
+            c.create_date as create_date,
+            extract('epoch' from (c.date_closed-c.create_date))/(3600*24) as  delay_close,
+            abs(extract('epoch' from (c.date_deadline - c.date_closed))/(3600*24)) as  delay_expected,
+            extract('epoch' from (c.date_open-c.create_date))/(3600*24) as  delay_open,
+            c.lost_reason,
+            c.date_conversion as date_conversion
+        """
+        return select_str
+
+    def _from(self):
+        from_str = """
+            FROM
                     "crm_lead" c
-                LEFT JOIN "crm_stage" stage
-                ON stage.id = c.stage_id
-                GROUP BY c.id, stage.name
-            )""")
+        """
+        return from_str
+
+    def _join(self):
+        join_str = """
+            LEFT JOIN "crm_stage" stage ON stage.id = c.stage_id
+        """
+        return join_str
+
+    def _where(self):
+        where_str = """
+        """
+        return where_str
+
+    def _group_by(self):
+        group_by_str = """
+            GROUP BY c.id, stage.name
+        """
+        return group_by_str
+
+    @api.model_cr
+    def init(self):
+        tools.drop_view_if_exists(self.env.cr, self._table)
+        self.env.cr.execute("""CREATE VIEW %s AS (
+            %s
+            %s
+            %s
+            %s
+            %s
+        )""" % (self._table, self._select(), self._from(), self._join(), self._where(), self._group_by()))