From be54b82afdb246697d9c46e7d73bac09cc45a4c6 Mon Sep 17 00:00:00 2001
From: Samuel Degueldre <sad@odoo.com>
Date: Wed, 20 May 2020 09:48:21 +0000
Subject: [PATCH] [FIX] web_editor, mass_mailing: fix assets template unable to
 load

View rendering from javascript has recently been made to check
permissions (See commits 64d0dab0a69fc62db85f67dfd1ea8638976610f6
through ccc98e01691b88c2da9c484c0e6de235b9d18548). Some assets required
by the iframe editor are rendered in JS so that they can be injected
into the iframe, but their permissions had not been updated, causing a
crash when trying to create or edit a mass_mailing campaign.

This commit fixes that by adding groups="base.group_user" to the
required templates.

closes odoo/odoo#51598

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
---
 addons/mass_mailing/views/assets.xml          | 4 ++--
 addons/mass_mailing/views/snippets_themes.xml | 2 +-
 addons/web_editor/views/editor.xml            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/mass_mailing/views/assets.xml b/addons/mass_mailing/views/assets.xml
index 806d95ad4ff..ef99898703d 100644
--- a/addons/mass_mailing/views/assets.xml
+++ b/addons/mass_mailing/views/assets.xml
@@ -29,12 +29,12 @@
         <link rel="stylesheet" type="text/scss" href="/web/static/src/scss/webclient.scss"/>
     </template>
 
-    <template id="iframe_css_assets_edit">
+    <template id="iframe_css_assets_edit" groups="base.group_user">
         <t t-call-assets="mass_mailing.assets_mail_themes" t-js="false"/>
         <t t-call-assets="mass_mailing.assets_mail_themes_edition" t-js="false"/>
     </template>
 
-    <template id="iframe_css_assets_readonly">
+    <template id="iframe_css_assets_readonly" groups="base.group_user">
         <link rel="stylesheet" type="text/scss" href="/mass_mailing/static/src/css/basic_theme_readonly.css"/>
     </template>
 
diff --git a/addons/mass_mailing/views/snippets_themes.xml b/addons/mass_mailing/views/snippets_themes.xml
index 63257b088e8..9da535d7480 100644
--- a/addons/mass_mailing/views/snippets_themes.xml
+++ b/addons/mass_mailing/views/snippets_themes.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
 <!-- Snippets & Themes Menu -->
-<template id="email_designer_snippets" inherit_id="web_editor.snippets" primary="True">
+<template id="email_designer_snippets" inherit_id="web_editor.snippets" primary="True" groups="base.group_user">
     <xpath expr="//div[@id='snippets_menu']" position="inside">
         <button type="button" disabled="disabled">Select a template</button>
     </xpath>
diff --git a/addons/web_editor/views/editor.xml b/addons/web_editor/views/editor.xml
index 0021ee56a3f..2ebd3ff40b5 100644
--- a/addons/web_editor/views/editor.xml
+++ b/addons/web_editor/views/editor.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
 
-<template id="wysiwyg_iframe_editor_assets" name="Editor assets for wysiwyg iframe content">
+<template id="wysiwyg_iframe_editor_assets" name="Editor assets for wysiwyg iframe content" groups="base.group_user">
     <t t-call-assets="web.assets_common"/>
     <t t-call-assets="web.assets_frontend" t-js="false"/>
     <t t-call-assets="web_editor.assets_wysiwyg"/>