From 410abecd240dfbe2452e02071a4636cb991285f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Wed, 26 Jun 2019 10:13:47 +0200
Subject: [PATCH 1/5] [IMP] base: Load translation when language is activated

Purpose
=======
Settings > Translations > Languages > I find the language I want
and I click on stat button to activate it.
Now I set it up on my user, it still doesn't work > the langage has not been loaded !!!

Specification
=============
When activating a language load the translation (and open the load translation wizard)
---
 odoo/addons/base/models/res_lang.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/odoo/addons/base/models/res_lang.py b/odoo/addons/base/models/res_lang.py
index 6fcd82354b6..050eba993ff 100644
--- a/odoo/addons/base/models/res_lang.py
+++ b/odoo/addons/base/models/res_lang.py
@@ -212,6 +212,20 @@ class Lang(models.Model):
         langs = self.with_context(active_test=True).search([])
         return sorted([(lang.code, lang.name) for lang in langs], key=itemgetter(1))
 
+    def toggle_active(self):
+        super().toggle_active()
+        # Automatically load translation
+        if len(self) == 1 and self.active:
+            return {
+                'name': "Load a Translation",
+                'type': 'ir.actions.act_window',
+                'res_model': 'base.language.install',
+                'context': {'default_lang': self.code},
+                'view_mode': 'form',
+                'target': 'new',
+                'views': [[False, 'form']],
+            }
+
     @api.model_create_multi
     def create(self, vals_list):
         self.clear_caches()

From 1ce23c5050fd7f35ddab47f5545212183c7e3dac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Wed, 26 Jun 2019 10:32:05 +0200
Subject: [PATCH 2/5] [IMP] base: Add shortcut button to load language

Pupose
======
On the res.partner and res.user form view if you want to change
the language, it's not easy to know where I can activate more
langages.

Specification
=============
Add a small icon next to the language field to activate more
languages (similar interface than to send an SMS).
---
 odoo/addons/base/views/res_partner_views.xml | 13 +++++++++-
 odoo/addons/base/views/res_users_views.xml   | 26 ++++++++++++++++++--
 2 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index 2851ecb72ff..c570b57e054 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -262,7 +262,18 @@
                             <field name="website" widget="url" placeholder="e.g. www.odoo.com"/>
                             <field name="title" options='{"no_open": True}'
                                 attrs="{'invisible': [('is_company', '=', True)]}"/>
-                            <field name="lang"/>
+                            <label for="lang"/>
+                            <div class="o_row">
+                                <field name="lang" placeholder="System (English)"/>
+                                <button
+                                    type="action"
+                                    name="%(base.res_lang_act_window)d"
+                                    class="btn-sm btn-link mb4 fa fa-globe"
+                                    aria-label="More languages"
+                                    groups="base.group_system"
+                                    title="More languages"
+                                />
+                            </div>
                             <field name="category_id" widget="many2many_tags" options="{'color_field': 'color', 'no_create_edit': True}" placeholder="Tags..."/>
                         </group>
                     </group>
diff --git a/odoo/addons/base/views/res_users_views.xml b/odoo/addons/base/views/res_users_views.xml
index b4a68ced71e..9bf981f3246 100644
--- a/odoo/addons/base/views/res_users_views.xml
+++ b/odoo/addons/base/views/res_users_views.xml
@@ -213,8 +213,19 @@
                             <page string="Preferences">
                                 <group>
                                     <group string="Localization" name="preferences">
-                                        <field name="lang"/>
+                                        <label for="lang" placeholder="System (English)"/>
                                         <field name="active" invisible="1"/>
+                                        <div class="o_row">
+                                            <field name="lang"/>
+                                            <button
+                                                type="action"
+                                                name="%(base.res_lang_act_window)d"
+                                                class="btn-sm btn-link mb4 fa fa-globe"
+                                                aria-label="More languages"
+                                                groups="base.group_system"
+                                                title="More languages"
+                                            />
+                                        </div>
                                         <field name="tz" widget="timezone_mismatch" options="{'tz_offset_field': 'tz_offset'}" />
                                         <field name="tz_offset" invisible="1"/>
                                     </group>
@@ -344,7 +355,18 @@
                                 groups="base.group_multi_company"/>
                         </group>
                         <group>
-                            <field name="lang" readonly="0" placeholder="System (English)"/>
+                            <label for="lang"/>
+                            <div class="o_row">
+                                <field name="lang" placeholder="System (English)"/>
+                                <button
+                                    type="action"
+                                    name="%(base.res_lang_act_window)d"
+                                    class="btn-sm btn-link mb4 fa fa-globe"
+                                    aria-label="More languages"
+                                    groups="base.group_system"
+                                    title="More languages"
+                                />
+                            </div>
                             <field name="tz" widget="timezone_mismatch" options="{'tz_offset_field': 'tz_offset'}" readonly="0"/>
                             <field name="tz_offset" invisible="1"/>
                         </group>

From 1796c5d74fe9603fb8d90149c734e54b061c4686 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Wed, 26 Jun 2019 11:47:27 +0200
Subject: [PATCH 3/5] [IMP] base: Clean res.lang tree view

1. Set limit to 200 to display all current 82 languages
in one page (current limit is 80/82).

2. Move some fields to debug mode.

3. Add a button to directly load a language.
---
 odoo/addons/base/views/res_lang_views.xml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/odoo/addons/base/views/res_lang_views.xml b/odoo/addons/base/views/res_lang_views.xml
index ee842a22188..7bd7c9954fe 100644
--- a/odoo/addons/base/views/res_lang_views.xml
+++ b/odoo/addons/base/views/res_lang_views.xml
@@ -5,16 +5,15 @@
             <field name="name">res.lang.tree</field>
             <field name="model">res.lang</field>
             <field name="arch" type="xml">
-                <tree string="Languages">
+                <tree string="Languages" limit="200">
                     <field name="name"/>
-                    <field name="code"/>
-                    <field name="iso_code"/>
-                    <field name="direction"/>
-                    <field name="translatable"/>
+                    <field name="code" groups="base.group_no_one"/>
+                    <field name="iso_code" groups="base.group_no_one"/>
+                    <field name="direction" groups="base.group_no_one"/>
+                    <field name="translatable" groups="base.group_no_one"/>
                     <field name="active"/>
                     <button name="%(base.action_view_base_language_install)d"
-                    string="Update Terms" type="action" icon="fa-refresh" help="Update Language Terms"
-                    attrs="{'invisible': [('active', '=', False)]}"/>
+                    string="Download and Update Translation" type="action" icon="fa-refresh" help="Download and Update Translation"/>
                 </tree>
             </field>
         </record>

From 4f47b729b1ac885cf9ad540334567303cfd8b8a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Wed, 26 Jun 2019 16:16:18 +0200
Subject: [PATCH 4/5] [IMP] base: Remove Load a Translation menu

Activating a language automatically load the translation,
hence the menu is no longer necessary.
---
 doc/reference/translations.rst                          | 2 +-
 odoo/addons/base/wizard/base_language_install_views.xml | 6 ------
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/doc/reference/translations.rst b/doc/reference/translations.rst
index 81ec506df63..2acdaf48f67 100644
--- a/doc/reference/translations.rst
+++ b/doc/reference/translations.rst
@@ -37,7 +37,7 @@ translation tool like POEdit_ or by simply copying the template to a new file
 called :file:`{language}.po`. Translation files should be put in
 :file:`{yourmodule}/i18n/`, next to :file:`{yourmodule}.pot`, and will be
 automatically loaded by Odoo when the corresponding language is installed (via
-:menuselection:`Settings --> Translations --> Load a Translation`)
+:menuselection:`Settings --> Translations --> Languages`)
 
 .. note:: translations for all loaded languages are also installed or updated
           when installing or updating a module
diff --git a/odoo/addons/base/wizard/base_language_install_views.xml b/odoo/addons/base/wizard/base_language_install_views.xml
index 0869f0cf77b..811bac29aad 100644
--- a/odoo/addons/base/wizard/base_language_install_views.xml
+++ b/odoo/addons/base/wizard/base_language_install_views.xml
@@ -34,12 +34,6 @@ You must change the preferences of the user to view the changes.</span>
             <field name="view_mode">form</field>
             <field name="target">new</field>
         </record>
-
-        <menuitem
-            name="Load a Translation"
-            action="action_view_base_language_install"
-            id="menu_view_base_language_install"
-            parent="menu_translation" sequence="2"/>
     </data>
 </odoo>
 

From a5077b300c5cb5eae59e0bb67a5d5429b846f642 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lucas=20Lef=C3=A8vre?= <lul@odoo.com>
Date: Wed, 26 Jun 2019 17:24:44 +0200
Subject: [PATCH 5/5] [IMP] base: Don't show language if only one active

If only one language is active, don't show in the contact
form view (`res.partner`) the language field. Changing the language is
not possible since there is only one language.
Hence the field is useless and therefore hidden.
---
 odoo/addons/base/models/res_partner.py       | 6 ++++++
 odoo/addons/base/views/res_partner_views.xml | 5 +++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/odoo/addons/base/models/res_partner.py b/odoo/addons/base/models/res_partner.py
index 185e5a28dfa..711c46d4460 100644
--- a/odoo/addons/base/models/res_partner.py
+++ b/odoo/addons/base/models/res_partner.py
@@ -154,6 +154,7 @@ class Partner(models.Model):
     ref = fields.Char(string='Reference', index=True)
     lang = fields.Selection(_lang_get, string='Language', default=lambda self: self.env.lang,
                             help="All the emails and documents sent to this contact will be translated in this language.")
+    active_lang_count = fields.Integer(compute='_compute_active_lang_count')
     tz = fields.Selection(_tz_get, string='Timezone', default=lambda self: self._context.get('tz'),
                           help="When printing documents and exporting/importing data, time values are computed according to this timezone.\n"
                                "If the timezone is not set, UTC (Coordinated Universal Time) is used.\n"
@@ -253,6 +254,11 @@ class Partner(models.Model):
         for partner in self:
             partner.display_name = names.get(partner.id)
 
+    def _compute_active_lang_count(self):
+        lang_count = len(self.env['res.lang'].get_installed())
+        for partner in self:
+            partner.active_lang_count = lang_count
+
     @api.depends('tz')
     def _compute_tz_offset(self):
         for partner in self:
diff --git a/odoo/addons/base/views/res_partner_views.xml b/odoo/addons/base/views/res_partner_views.xml
index c570b57e054..2bb056f75b6 100644
--- a/odoo/addons/base/views/res_partner_views.xml
+++ b/odoo/addons/base/views/res_partner_views.xml
@@ -262,8 +262,9 @@
                             <field name="website" widget="url" placeholder="e.g. www.odoo.com"/>
                             <field name="title" options='{"no_open": True}'
                                 attrs="{'invisible': [('is_company', '=', True)]}"/>
-                            <label for="lang"/>
-                            <div class="o_row">
+                            <field name="active_lang_count" invisible="1"/>
+                            <label for="lang" attrs="{'invisible': [('active_lang_count', '&lt;=', 1)]}"/>
+                            <div class="o_row" attrs="{'invisible': [('active_lang_count', '&lt;=', 1)]}">
                                 <field name="lang" placeholder="System (English)"/>
                                 <button
                                     type="action"