From bca14070a60446f1f127e2efd9218a6ad984f1ed Mon Sep 17 00:00:00 2001
From: "Gaetan Vanden Bergh (gavb)" <gavb@odoo.com>
Date: Mon, 4 Sep 2023 08:45:05 +0200
Subject: [PATCH] [FIX] mail: No author reply trigger error due to parent
 message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Steps:
No precise steps:
Send/Receive a email in discuss
Reply to it via email

Actual result: crash due to parentMessage
Expected result: no crash

opw-3480185

closes odoo/odoo#134123

X-original-commit: 743a298089620865d95f725cae8b3e5ffc9a822e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
---
 addons/mail/static/src/core/common/message_in_reply.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/mail/static/src/core/common/message_in_reply.xml b/addons/mail/static/src/core/common/message_in_reply.xml
index f83d586d14b..de290587df9 100644
--- a/addons/mail/static/src/core/common/message_in_reply.xml
+++ b/addons/mail/static/src/core/common/message_in_reply.xml
@@ -9,9 +9,9 @@
             <small class="position-relative d-block text-small mb-1" t-attf-class="{{ env.inChatWindow and props.alignedRight ? 'justify-content-end pe-5': 'ps-5' }}" t-on-click="() => this.props.onClick?.()">
                 <span class="o-mail-MessageInReply-corner position-absolute bottom-0 top-50 pe-4 border-top text-300" t-attf-class="{{ env.inChatWindow and props.alignedRight ? 'o-isRightAlign border-end' : 'o-isLeftAlign border-start' }}" t-att-class="{ 'ms-n2': store.discuss.isActive }"/>
                 <span t-if="!message.parentMessage.isEmpty" class="d-inline-flex align-items-center text-muted opacity-75" t-att-class="{ 'cursor-pointer opacity-100-hover': props.onClick }">
-                    <img class="o-mail-MessageInReply-avatar me-2 rounded" t-att-src="authorAvatarUrl" t-att-title="message.parentMessage.author.name" alt="Avatar"/>
+                    <img class="o-mail-MessageInReply-avatar me-2 rounded" t-att-src="authorAvatarUrl" t-att-title="message.parentMessage.author?.name ?? message.parentMessage.email_from" alt="Avatar"/>
                     <span class="o-mail-MessageInReply-content overflow-hidden">
-                        <b>@<t t-out="message.parentMessage.author.name"/></b>:
+                        <b>@<t t-out="message.parentMessage.author?.name ?? message.parentMessage.email_from"/></b>:
                         <span class="o-mail-MessageInReply-message ms-1 text-break">
                             <t t-if="!message.parentMessage.isBodyEmpty">
                                 <t t-out="message.parentMessage.body"/>