From bc9e1f7ed09bb36d65a1515a8f684265fcd8a6fe Mon Sep 17 00:00:00 2001
From: Cedric Snauwaert <csn@openerp.com>
Date: Fri, 28 Sep 2018 11:56:49 +0200
Subject: [PATCH] [FIX] account: fix account type of other income and asset
 filter

Account type of other income should be of type 'income' and not 'other'
Filter 'Assets' in chart of accounts view is not working correctly due to typo in the filter.
---
 addons/account/data/data_account_type.xml | 2 +-
 addons/account/views/account_view.xml     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/account/data/data_account_type.xml b/addons/account/data/data_account_type.xml
index 3778a0affcf..05f4a76bf36 100644
--- a/addons/account/data/data_account_type.xml
+++ b/addons/account/data/data_account_type.xml
@@ -74,7 +74,7 @@
         <record model="account.account.type" id="data_account_type_other_income">
           <field name="name">Other Income</field>
           <field name="type">other</field>
-          <field name="internal_group">asset</field>
+          <field name="internal_group">income</field>
         </record>
         <record model="account.account.type" id="data_account_type_revenue">
           <field name="name">Income</field>
diff --git a/addons/account/views/account_view.xml b/addons/account/views/account_view.xml
index 807275ed73a..a34a743db4a 100644
--- a/addons/account/views/account_view.xml
+++ b/addons/account/views/account_view.xml
@@ -139,7 +139,7 @@
                     <filter string="Receivable Accounts" name="receivableacc" domain="[('internal_type','=','receivable')]"/>
                     <filter string="Payable Accounts" name="payableacc" domain="[('internal_type','=','payable')]"/>
                     <filter string="Equity" name="equityacc" domain="[('internal_group','=', 'equity')]"/>
-                    <filter string="Assets" name="assetsacc" domain="[('internal_group','=', 'assets')]"/>
+                    <filter string="Assets" name="assetsacc" domain="[('internal_group','=', 'asset')]"/>
                     <filter string="Liability" name="liabilityacc" domain="[('internal_group','=', 'liability')]"/>
                     <filter string="Income" name="incomeacc" domain="[('internal_group','=', 'income')]"/>
                     <filter string="Expenses" name="expensesacc" domain="[('internal_group','=', 'expense')]"/>