From bc945ef3f238c47d59d86e1d0e325cadc2a56bb9 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Thu, 18 Nov 2021 16:27:36 +0100 Subject: [PATCH] [FIX] sale: remove wrong default qty on lines Compute was never called because of the compute, which lead to wrong values (raising due to the SQL constraints). Integrate the default in the compute directly. --- addons/sale/models/sale_order_line.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/addons/sale/models/sale_order_line.py b/addons/sale/models/sale_order_line.py index f04a9958dd1..05dcb5d95c9 100644 --- a/addons/sale/models/sale_order_line.py +++ b/addons/sale/models/sale_order_line.py @@ -250,7 +250,7 @@ class SaleOrderLine(models.Model): related="product_id.product_tmpl_id", domain=[('sale_ok', '=', True)]) product_updatable = fields.Boolean(compute='_compute_product_updatable', string='Can Edit Product') product_uom_qty = fields.Float( - string='Quantity', digits='Product Unit of Measure', required=True, default=1.0, + string='Quantity', digits='Product Unit of Measure', required=True, compute='_compute_product_uom_qty', store=True, readonly=False, pre_compute=True) product_uom = fields.Many2one( 'uom.uom', string='Unit of Measure', @@ -458,8 +458,8 @@ class SaleOrderLine(models.Model): line.product_uom_qty = 0.0 continue - if not line.product_uom or (line.product_id.uom_id.id != line.product_uom.id): - line.product_uom_qty = line.product_uom_qty or 1.0 + # Default value = 1.0 + line.product_uom_qty = line.product_uom_qty or 1.0 if not line.product_packaging_id: continue packaging_uom = line.product_packaging_id.product_uom_id