From bc20eb47908cb0b9479f7436dfc94a6e32d1b774 Mon Sep 17 00:00:00 2001 From: Jorge Pinna Puissant Date: Tue, 1 Mar 2022 08:19:29 +0000 Subject: [PATCH] [IMP] test_lint, *: enable no-unused-vars rule Part-of: odoo/odoo#85569 --- .../static/src/js/account_payment_field.js | 2 +- .../static/src/js/account_selection.js | 2 - addons/account/static/src/js/bills_upload.js | 4 -- addons/account/static/src/js/mail_activity.js | 1 - addons/account/static/src/js/tax_totals.js | 2 +- .../auth_totp_mail/static/tests/totp_flow.js | 16 ------- .../src/js/base_automation_error_dialog.js | 1 - .../tests/base_automation_error_dialog.js | 3 +- .../static/src/legacy/js/import_action.js | 3 -- .../static/src/legacy/js/import_menu.js | 2 - .../static/src/js/google_calendar.js | 4 -- .../static/src/js/expense_qr_code_action.js | 1 - .../hr_expense/static/src/js/upload_mixin.js | 1 - .../tests/tours/expense_upload_tours.js | 1 - .../time_off_calendar_renderer.js | 1 - .../time_off_popover_renderer.js | 1 - .../static/src/js/hr_org_chart.js | 2 - .../static/src/js/qr_code_action.js | 1 - addons/l10n_sa_pos/static/src/js/models.js | 9 ---- .../static/tests/lunch_kanban_mobile_tests.js | 2 - .../src/components/activity/activity.js | 2 +- .../activity_mark_done_popover.js | 2 +- .../attachment_card/attachment_card.js | 2 - .../attachment_image/attachment_image.js | 2 - .../attachment_viewer/attachment_viewer.js | 2 - .../src/components/chat_window/chat_window.js | 2 +- .../static/src/components/chatter/chatter.js | 2 +- .../static/src/components/discuss/discuss.js | 2 - .../src/components/emoji_list/emoji_list.js | 2 - .../tests/messaging_menu_tests.js | 1 - .../rtc_layout_menu/rtc_layout_menu.js | 2 - .../rtc_option_list/rtc_option_list.js | 2 - addons/mail/static/src/js/activity.js | 2 - .../mail/static/src/js/field_emojis_common.js | 2 - .../static/src/js/many2many_tags_email.js | 2 - .../static/src/models/activity/activity.js | 2 - .../follower_subtype_list.js | 1 - .../message_action_list.js | 2 +- .../src/models/popover_view/popover_view.js | 2 - addons/mail/static/src/utils/test_utils.js | 1 - .../commands/mail_providers_tests.js | 4 +- .../mailing_mailing_view_form_full_width.js | 2 +- .../static/src/js/mass_mailing_widget.js | 1 - .../static/tests/mass_mailing_html_tests.js | 4 -- .../static/src/js/microsoft_calendar.js | 3 -- .../static/src/js/PosComponent.js | 2 +- .../PartnerListScreen/PartnerListScreen.js | 1 - addons/point_of_sale/static/src/js/utils.js | 2 - .../static/tests/tours/point_of_sale.js | 13 ----- .../static/tests/unit/helpers/test_env.js | 1 - .../static/tests/unit/test_NumberBuffer.js | 2 +- addons/portal/static/src/js/portal_chatter.js | 1 - addons/pos_hr/static/src/js/CashierName.js | 1 - addons/pos_hr/static/src/js/LoginScreen.js | 1 - .../ControlButtons/SubmitOrderButton.js | 2 - .../OrderManagementScreen/SaleOrderFetcher.js | 1 - .../static/src/js/SetSaleOrderButton.js | 2 - .../src/js/right_panel/project_right_panel.js | 2 +- .../src/js/right_panel/project_utils.js | 3 +- .../project_name_with_subtask_count_widget.js | 4 +- .../components/favorite_menu_registry.js | 2 +- .../src/project_sharing/project_sharing.js | 2 +- .../js/inventory_singleton_list_renderer.js | 3 -- addons/stock/static/src/js/popover_widget.js | 1 - .../js/stock_orderpoint_list_controller.js | 1 - .../src/js/stock_orderpoint_list_model.js | 3 -- .../src/js/tours/wevent_register_tour.js | 5 -- .../src/core/commands/default_providers.js | 2 - .../static/src/core/datepicker/datepicker.js | 1 - addons/web/static/src/core/dialog/dialog.js | 2 +- .../web/static/src/core/dropdown/dropdown.js | 1 - .../static/src/core/dropdown/dropdown_item.js | 2 - .../static/src/core/effects/rainbow_man.js | 2 +- .../static/src/core/file_input/file_input.js | 2 +- .../web/static/src/core/utils/components.js | 2 +- .../src/legacy/js/components/action_menus.js | 1 - .../legacy/js/components/custom_checkbox.js | 2 - .../legacy/js/components/custom_file_input.js | 2 +- .../src/legacy/js/components/datepicker.js | 1 - .../src/legacy/js/components/dropdown_menu.js | 2 +- .../js/components/dropdown_menu_item.js | 2 +- .../static/src/legacy/js/components/pager.js | 2 +- .../js/control_panel/comparison_menu.js | 2 - .../legacy/js/control_panel/control_panel.js | 1 - .../js/control_panel/custom_favorite_item.js | 2 +- .../js/control_panel/custom_filter_item.js | 3 +- .../legacy/js/control_panel/favorite_menu.js | 2 +- .../legacy/js/control_panel/filter_menu.js | 2 - .../legacy/js/control_panel/groupby_menu.js | 2 - .../src/legacy/js/control_panel/search_bar.js | 2 +- addons/web/static/src/legacy/js/core/dom.js | 1 - .../web/static/src/legacy/js/core/domain.js | 1 - .../static/src/legacy/js/core/error_utils.js | 1 - .../static/src/legacy/js/core/owl_dialog.js | 2 +- .../web/static/src/legacy/js/core/popover.js | 2 +- .../legacy/js/fields/abstract_field_owl.js | 2 +- .../src/legacy/js/fields/relational_fields.js | 4 +- .../src/legacy/js/public/public_widget.js | 1 - .../src/legacy/js/services/data_manager.js | 2 +- .../legacy/js/views/abstract_controller.js | 2 - .../legacy/js/views/abstract_renderer_owl.js | 2 +- .../src/legacy/js/views/basic/basic_model.js | 2 +- .../js/views/calendar/calendar_model.js | 1 - .../js/views/calendar/calendar_renderer.js | 2 - .../src/legacy/js/views/form/form_renderer.js | 1 - .../legacy/js/views/kanban/kanban_column.js | 1 - .../js/views/kanban/kanban_controller.js | 2 - .../legacy/js/views/kanban/kanban_model.js | 2 +- .../legacy/js/views/pivot/pivot_renderer.js | 4 +- .../src/legacy/js/views/search_panel.js | 2 +- .../js/views/search_panel_model_extension.js | 4 +- .../src/legacy/js/widgets/change_password.js | 1 - .../static/src/legacy/js/widgets/week_days.js | 2 +- .../src/legacy/legacy_client_actions.js | 2 +- addons/web/static/src/legacy/legacy_views.js | 2 +- .../group_by_menu/custom_group_by_item.js | 2 +- .../src/search/search_bar/search_bar.js | 2 +- .../src/search/search_panel/search_panel.js | 2 +- .../src/search/with_search/with_search.js | 2 +- .../static/src/views/graph/graph_renderer.js | 2 +- .../web/static/src/views/graph/graph_view.js | 1 - addons/web/static/src/views/layout.js | 2 - .../web/static/src/views/onboarding_banner.js | 2 +- .../static/src/views/pivot/pivot_renderer.js | 2 +- .../web/static/src/views/pivot/pivot_view.js | 1 - addons/web/static/src/views/view.js | 2 +- addons/web/static/src/views/view_service.js | 2 +- .../web/static/src/webclient/navbar/navbar.js | 2 +- .../switch_company_menu.js | 2 +- .../core/commands/command_palette_tests.js | 47 +++++++++---------- .../core/commands/command_service_tests.js | 2 +- .../web/static/tests/core/datepicker_tests.js | 2 +- addons/web/static/tests/core/dialog_tests.js | 2 +- .../core/effects/effect_service_tests.js | 2 +- .../tests/core/errors/error_service_tests.js | 2 +- .../tests/core/l10n/translation_tests.js | 2 +- .../tests/core/network/rpc_service_tests.js | 2 +- .../static/tests/core/orm_service_tests.js | 4 +- .../web/static/tests/core/ui_service_tests.js | 3 +- .../tests/legacy/component_extension_tests.js | 2 +- .../legacy/components/dropdown_menu_tests.js | 2 +- .../tests/legacy/components/pager_tests.js | 2 +- .../tests/legacy/core/owl_dialog_tests.js | 2 +- .../static/tests/legacy/core/popover_tests.js | 2 +- .../static/tests/legacy/core/widget_tests.js | 2 +- .../tests/legacy/fields/basic_fields_tests.js | 4 +- .../relational_fields/field_one2many_tests.js | 1 - .../legacy/fields/relational_fields_tests.js | 1 - .../tests/legacy/owl_compatibility_tests.js | 8 +--- .../legacy/views/abstract_controller_tests.js | 1 - .../tests/legacy/views/basic_view_tests.js | 2 +- .../tests/legacy/views/calendar_tests.js | 3 -- .../static/tests/legacy/views/form_tests.js | 3 +- .../static/tests/legacy/views/kanban_tests.js | 5 +- .../static/tests/legacy/views/list_tests.js | 2 +- .../tests/legacy/views/state_mapping_tests.js | 2 +- .../tests/legacy/views/view_dialogs_tests.js | 5 +- .../tests/legacy/widgets/week_days_tests.js | 1 - .../tests/search/favorite_menu_tests.js | 1 - addons/web/static/tests/setup.js | 2 +- addons/web/static/tests/views/view_tests.js | 2 +- .../webclient/actions/client_action_tests.js | 2 +- .../webclient/actions/concurrency_tests.js | 20 ++++---- .../webclient/actions/error_handling_tests.js | 2 +- .../webclient/actions/load_state_tests.js | 2 +- .../webclient/actions/push_state_tests.js | 2 +- .../tests/webclient/actions/target_tests.js | 2 +- .../static/tests/webclient/navbar_tests.js | 2 +- .../static/tests/webclient/user_menu_tests.js | 7 ++- .../static/tests/webclient/webclient_tests.js | 2 +- addons/web/tooling/_eslintrc.json | 3 +- .../static/src/js/backend/field_html.js | 4 -- addons/web_editor/static/src/js/common/ace.js | 1 - .../static/src/js/wysiwyg/wysiwyg.js | 1 - .../static/src/js/wysiwyg/wysiwyg_iframe.js | 1 - .../static/tests/field_html_tests.js | 2 - .../static/src/js/kanban_gauge.js | 6 --- .../static/src/js/unsplash_image_widget.js | 1 - .../web_unsplash/static/src/js/unsplashapi.js | 1 - .../static/src/js/content/website_root.js | 1 - .../website/static/src/js/editor/wysiwyg.js | 1 - .../website/static/src/js/menu/new_content.js | 2 +- .../s_dynamic_snippet_carousel/000.js | 2 - .../static/src/js/display_timer_widget.js | 2 - .../static/src/js/website_event.editor.js | 1 - .../static/src/js/service_worker.js | 2 +- .../static/src/js/website_event_pwa_widget.js | 1 - .../static/src/js/website_event_track_live.js | 4 +- .../static/src/js/website_google_map.js | 2 +- .../website_jitsi/static/src/js/chat_room.js | 2 - .../static/src/js/website_links_menu.js | 1 - .../static/src/js/website_profile.js | 1 - .../static/src/js/website_sale.editor.js | 1 - .../s_dynamic_snippet_products/000.js | 2 - .../tours/website_sale_shop_cart_recovery.js | 1 - .../src/js/slides_course_unsubscribe.js | 1 - .../src/js/website_slides_forum.editor.js | 2 - .../static/src/js/test_jsfile1.js | 2 +- .../static/src/js/test_jsfile2.js | 2 +- .../static/src/js/test_jsfile3.js | 2 +- .../static/src/js/test_jsfile4.js | 2 +- odoo/addons/test_lint/tests/eslintrc | 3 +- .../static/tests/tours/constraint.js | 1 - 203 files changed, 143 insertions(+), 363 deletions(-) diff --git a/addons/account/static/src/js/account_payment_field.js b/addons/account/static/src/js/account_payment_field.js index 8fe3a9bc568..b4918655bc6 100644 --- a/addons/account/static/src/js/account_payment_field.js +++ b/addons/account/static/src/js/account_payment_field.js @@ -62,7 +62,7 @@ var ShowPaymentLineWidget = AbstractField.extend({ var options = { content: function () { var $content = $(QWeb.render('PaymentPopOver', content)); - var unreconcile_button = $content.filter('.js_unreconcile_payment').on('click', self._onRemoveMoveReconcile.bind(self)); + $content.filter('.js_unreconcile_payment').on('click', self._onRemoveMoveReconcile.bind(self)); $content.filter('.js_open_payment').on('click', self._onOpenPaymentOrMove.bind(self)); return $content; diff --git a/addons/account/static/src/js/account_selection.js b/addons/account/static/src/js/account_selection.js index cb58b2be23a..f93ba3f2342 100644 --- a/addons/account/static/src/js/account_selection.js +++ b/addons/account/static/src/js/account_selection.js @@ -9,8 +9,6 @@ odoo.define('account.hierarchy.selection', function (require) { var FieldSelection = relational_fields.FieldSelection; - var qweb = core.qweb; - var HierarchySelection = FieldSelection.extend({ _renderEdit: function () { var self = this; diff --git a/addons/account/static/src/js/bills_upload.js b/addons/account/static/src/js/bills_upload.js index 7b0a3fa3f9f..2e0e254e4ff 100644 --- a/addons/account/static/src/js/bills_upload.js +++ b/addons/account/static/src/js/bills_upload.js @@ -2,7 +2,6 @@ odoo.define('account.upload.bill.mixin', function (require) { "use strict"; var core = require('web.core'); - var _t = core._t; var qweb = core.qweb; @@ -46,7 +45,6 @@ odoo.define('account.upload.bill.mixin', function (require) { }, _onUpload: function (event) { - var self = this; // If hidden upload form don't exists, create it var $formContainer = this.$('.o_content').find('.o_vendor_bill_upload'); if (!$formContainer.length) { @@ -63,7 +61,6 @@ odoo.define('account.upload.bill.mixin', function (require) { odoo.define('account.bills.tree', function (require) { "use strict"; - var core = require('web.core'); var ListController = require('web.ListController'); var ListView = require('web.ListView'); var UploadBillMixin = require('account.upload.bill.mixin'); @@ -111,7 +108,6 @@ odoo.define('account.bills.kanban', function (require) { odoo.define('account.dashboard.kanban', function (require) { "use strict"; - var core = require('web.core'); var KanbanController = require('web.KanbanController'); var KanbanView = require('web.KanbanView'); var UploadBillMixin = require('account.upload.bill.mixin'); diff --git a/addons/account/static/src/js/mail_activity.js b/addons/account/static/src/js/mail_activity.js index 8b84afda726..068355c08b2 100644 --- a/addons/account/static/src/js/mail_activity.js +++ b/addons/account/static/src/js/mail_activity.js @@ -22,7 +22,6 @@ var VatActivity = AbstractField.extend({ // Private //------------------------------------------------------------ _render: function () { - var self = this; var info = JSON.parse(this.value); if (!info) { this.$el.html(''); diff --git a/addons/account/static/src/js/tax_totals.js b/addons/account/static/src/js/tax_totals.js index 8505e1174e4..deb52d991ba 100644 --- a/addons/account/static/src/js/tax_totals.js +++ b/addons/account/static/src/js/tax_totals.js @@ -7,7 +7,7 @@ import fieldUtils from 'web.field_utils'; import field_registry from 'web.field_registry_owl'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onPatched, onWillUpdateProps, useRef, useState } = owl; +const { onPatched, onWillUpdateProps, useRef, useState } = owl; /** A line of some TaxTotalsComponent, giving the values of a tax group. diff --git a/addons/auth_totp_mail/static/tests/totp_flow.js b/addons/auth_totp_mail/static/tests/totp_flow.js index f1c1a5caf1e..540bc7c562a 100644 --- a/addons/auth_totp_mail/static/tests/totp_flow.js +++ b/addons/auth_totp_mail/static/tests/totp_flow.js @@ -3,22 +3,6 @@ odoo.define('auth_totp_mail.tours', function(require) { const tour = require('web_tour.tour'); -function openUserProfileAtSecurityTab() { - return [{ - content: 'Open user account menu', - trigger: '.o_user_menu .oe_topbar_name', - run: 'click', - }, { - content: "Open preferences / profile screen", - trigger: '[data-menu=settings]', - run: 'click', - }, { - content: "Switch to security tab", - trigger: 'a[role=tab]:contains("Account Security")', - run: 'click', - }]; -} - function openAccountSettingsTab() { return [{ content: 'Go to settings', diff --git a/addons/base_automation/static/src/js/base_automation_error_dialog.js b/addons/base_automation/static/src/js/base_automation_error_dialog.js index 718c6505a4c..a0cc2c3b106 100644 --- a/addons/base_automation/static/src/js/base_automation_error_dialog.js +++ b/addons/base_automation/static/src/js/base_automation_error_dialog.js @@ -1,7 +1,6 @@ /** @odoo-module */ import { ErrorDialog } from "@web/core/errors/error_dialogs"; -import session from "web.session"; import { registry } from "@web/core/registry"; import { useService } from "@web/core/utils/hooks"; diff --git a/addons/base_automation/static/tests/base_automation_error_dialog.js b/addons/base_automation/static/tests/base_automation_error_dialog.js index 8bc93a688c9..869d2c0259a 100644 --- a/addons/base_automation/static/tests/base_automation_error_dialog.js +++ b/addons/base_automation/static/tests/base_automation_error_dialog.js @@ -14,9 +14,8 @@ import { RPCError } from "@web/core/network/rpc_service"; import { BaseAutomationErrorDialog } from "../src/js/base_automation_error_dialog"; import { patchWithCleanup,getFixture, mount, nextTick } from "@web/../tests/helpers/utils"; -import { DialogContainer } from "@web/core/dialog/dialog_container"; -const { onMounted, toRaw } = owl; +const { toRaw } = owl; const serviceRegistry = registry.category("services"); diff --git a/addons/base_import/static/src/legacy/js/import_action.js b/addons/base_import/static/src/legacy/js/import_action.js index c48f82c07d1..6271c7bdd8d 100644 --- a/addons/base_import/static/src/legacy/js/import_action.js +++ b/addons/base_import/static/src/legacy/js/import_action.js @@ -2,9 +2,7 @@ odoo.define('base_import.import', function (require) { "use strict"; var AbstractAction = require('web.AbstractAction'); -var config = require('web.config'); var core = require('web.core'); -var Dialog = require('web.Dialog'); var session = require('web.session'); var time = require('web.time'); var fieldUtils = require('web.field_utils'); @@ -386,7 +384,6 @@ var DataImport = AbstractAction.extend({ this.$('.oe_import_sheet').val(''); this.$form.removeClass('oe_import_preview oe_import_error'); - var import_toggle = false; var file = this.$('input.oe_import_file')[0].files[0]; // some platforms send text/csv, application/csv, or other things if Excel is prevent var isCSV = ((file.type && _.last(file.type.split('/')) === "csv") || ( _.last(file.name.split('.')) === "csv")) diff --git a/addons/base_import/static/src/legacy/js/import_menu.js b/addons/base_import/static/src/legacy/js/import_menu.js index 89e94f8a017..ed3f6cc0616 100644 --- a/addons/base_import/static/src/legacy/js/import_menu.js +++ b/addons/base_import/static/src/legacy/js/import_menu.js @@ -6,8 +6,6 @@ odoo.define('base_import.ImportMenu', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component } = owl; - /** * Import Records menu * diff --git a/addons/google_calendar/static/src/js/google_calendar.js b/addons/google_calendar/static/src/js/google_calendar.js index bc67837ee52..bba15cb074f 100644 --- a/addons/google_calendar/static/src/js/google_calendar.js +++ b/addons/google_calendar/static/src/js/google_calendar.js @@ -4,11 +4,9 @@ odoo.define('google_calendar.CalendarView', function (require) { var core = require('web.core'); var Dialog = require('web.Dialog'); var framework = require('web.framework'); -const CalendarView = require('@calendar/js/calendar_view')[Symbol.for("default")]; const CalendarRenderer = require('@calendar/js/calendar_renderer')[Symbol.for("default")].AttendeeCalendarRenderer; const CalendarController = require('@calendar/js/calendar_controller')[Symbol.for("default")]; const CalendarModel = require('@calendar/js/calendar_model')[Symbol.for("default")]; -const viewRegistry = require('web.view_registry'); const session = require('web.session'); var _t = core._t; @@ -61,7 +59,6 @@ const GoogleCalendarModel = CalendarModel.include({ _syncGoogleCalendar(shadow = false) { var self = this; - var context = this.getSession().user_context; this.google_pending_sync = true; return this._rpc({ route: '/google_calendar/sync_data', @@ -271,7 +268,6 @@ const GoogleCalendarRenderer = CalendarRenderer.include({ */ _onGoogleSyncCalendar: function () { var self = this; - var context = this.getSession().user_context; this.$googleButton.prop('disabled', true); this.trigger_up('syncGoogleCalendar', { on_always: function () { diff --git a/addons/hr_expense/static/src/js/expense_qr_code_action.js b/addons/hr_expense/static/src/js/expense_qr_code_action.js index 00ceb37e2c2..7ea4dcbafa2 100644 --- a/addons/hr_expense/static/src/js/expense_qr_code_action.js +++ b/addons/hr_expense/static/src/js/expense_qr_code_action.js @@ -3,7 +3,6 @@ odoo.define('hr_expense.qr_code_action', function (require) { const AbstractAction = require('web.AbstractAction'); const core = require('web.core'); -const config = require('web.config'); const QRModalAction = AbstractAction.extend({ template: 'hr_expense_qr_code', diff --git a/addons/hr_expense/static/src/js/upload_mixin.js b/addons/hr_expense/static/src/js/upload_mixin.js index 317aeee4cff..b680b670d35 100644 --- a/addons/hr_expense/static/src/js/upload_mixin.js +++ b/addons/hr_expense/static/src/js/upload_mixin.js @@ -60,7 +60,6 @@ var DocumentUploadMixin = { * @param {Event} event */ _onUpload: function (event) { - var self = this; // If hidden upload form don't exists, create it var $formContainer = this.$('.o_content').find('.o_expense_documents_upload'); if (!$formContainer.length) { diff --git a/addons/hr_expense/static/tests/tours/expense_upload_tours.js b/addons/hr_expense/static/tests/tours/expense_upload_tours.js index e9cd036dfb4..52807a7959f 100644 --- a/addons/hr_expense/static/tests/tours/expense_upload_tours.js +++ b/addons/hr_expense/static/tests/tours/expense_upload_tours.js @@ -1,7 +1,6 @@ odoo.define('hr_expense.tests.tours', function (require) { "use strict"; - var core = require('web.core'); var tour = require('web_tour.tour'); tour.register('hr_expense_test_tour', { diff --git a/addons/hr_holidays/static/src/js/time_off_calendar/time_off_calendar_renderer.js b/addons/hr_holidays/static/src/js/time_off_calendar/time_off_calendar_renderer.js index dd43a656f9a..2df26a788f6 100644 --- a/addons/hr_holidays/static/src/js/time_off_calendar/time_off_calendar_renderer.js +++ b/addons/hr_holidays/static/src/js/time_off_calendar/time_off_calendar_renderer.js @@ -7,7 +7,6 @@ import { TimeOffDashboard } from '@hr_holidays/dashboard/time_off_dashboard'; import { TimeOffCardMobile } from '@hr_holidays/dashboard/time_off_card'; import config from 'web.config'; -import session from 'web.session'; export const TimeOffCalendarRenderer = TimeOffPopoverRenderer.extend({ async willStart() { diff --git a/addons/hr_holidays/static/src/js/time_off_calendar/time_off_popover_renderer.js b/addons/hr_holidays/static/src/js/time_off_calendar/time_off_popover_renderer.js index 12115b6aeae..41e172ed903 100644 --- a/addons/hr_holidays/static/src/js/time_off_calendar/time_off_popover_renderer.js +++ b/addons/hr_holidays/static/src/js/time_off_calendar/time_off_popover_renderer.js @@ -1,7 +1,6 @@ /** @odoo-module **/ import { qweb as QWeb }from 'web.core'; -import config from 'web.config'; import CalendarRenderer from "web.CalendarRenderer"; import { TimeOffCalendarPopover } from "./time_off_calendar_popover"; diff --git a/addons/hr_org_chart/static/src/js/hr_org_chart.js b/addons/hr_org_chart/static/src/js/hr_org_chart.js index 21706687bf3..93f2934b525 100644 --- a/addons/hr_org_chart/static/src/js/hr_org_chart.js +++ b/addons/hr_org_chart/static/src/js/hr_org_chart.js @@ -38,7 +38,6 @@ var FieldOrgChart = AbstractField.extend({ * @returns {Promise} */ _getOrgData: function () { - var self = this; return this.dm.add(this._rpc({ route: '/hr/get_org_chart', params: { @@ -166,7 +165,6 @@ var FieldOrgChart = AbstractField.extend({ _onEmployeeSubRedirect: function (event) { event.preventDefault(); var employee_id = parseInt($(event.currentTarget).data('employee-id')); - var employee_name = $(event.currentTarget).data('employee-name'); var type = $(event.currentTarget).data('type') || 'direct'; var self = this; if (employee_id) { diff --git a/addons/hr_timesheet/static/src/js/qr_code_action.js b/addons/hr_timesheet/static/src/js/qr_code_action.js index 35559139a7a..774ec367aab 100644 --- a/addons/hr_timesheet/static/src/js/qr_code_action.js +++ b/addons/hr_timesheet/static/src/js/qr_code_action.js @@ -3,7 +3,6 @@ odoo.define('hr_timesheet.qr_code_action', function (require) { const AbstractAction = require('web.AbstractAction'); const core = require('web.core'); -const config = require('web.config'); const QRModalAction = AbstractAction.extend({ template: 'hr_timesheet_qr_code', diff --git a/addons/l10n_sa_pos/static/src/js/models.js b/addons/l10n_sa_pos/static/src/js/models.js index 8f1e8244549..9806a8704d7 100644 --- a/addons/l10n_sa_pos/static/src/js/models.js +++ b/addons/l10n_sa_pos/static/src/js/models.js @@ -1,18 +1,9 @@ odoo.define('l10n_sa_pos.pos', function (require) { "use strict"; -const { Gui } = require('point_of_sale.Gui'); var { Order } = require('point_of_sale.models'); -var rpc = require('web.rpc'); -var session = require('web.session'); -var core = require('web.core'); -var utils = require('web.utils'); var Registries = require('point_of_sale.Registries'); -var _t = core._t; -var round_di = utils.round_decimals; - - const PosL10nSAOrder = (Order) => class PosL10nSAOrder extends Order { export_for_printing() { var result = super.export_for_printing(...arguments); diff --git a/addons/lunch/static/tests/lunch_kanban_mobile_tests.js b/addons/lunch/static/tests/lunch_kanban_mobile_tests.js index 30b0ec7b469..cfcf4fa3c8b 100644 --- a/addons/lunch/static/tests/lunch_kanban_mobile_tests.js +++ b/addons/lunch/static/tests/lunch_kanban_mobile_tests.js @@ -10,8 +10,6 @@ QUnit.module('Views'); QUnit.module('LunchKanbanView Mobile', { beforeEach() { - const PORTAL_GROUP_ID = 1234; - this.data = { 'product': { fields: { diff --git a/addons/mail/static/src/components/activity/activity.js b/addons/mail/static/src/components/activity/activity.js index badc03cb29d..23cbc426622 100644 --- a/addons/mail/static/src/components/activity/activity.js +++ b/addons/mail/static/src/components/activity/activity.js @@ -5,7 +5,7 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import Popover from "web.Popover"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, markup } = owl; +const { markup } = owl; export class Activity extends LegacyComponent { diff --git a/addons/mail/static/src/components/activity_mark_done_popover/activity_mark_done_popover.js b/addons/mail/static/src/components/activity_mark_done_popover/activity_mark_done_popover.js index 920c689f413..1f7c8aef59b 100644 --- a/addons/mail/static/src/components/activity_mark_done_popover/activity_mark_done_popover.js +++ b/addons/mail/static/src/components/activity_mark_done_popover/activity_mark_done_popover.js @@ -5,7 +5,7 @@ import { useRefToModel } from '@mail/component_hooks/use_ref_to_model/use_ref_to import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onMounted, useRef } = owl; +const { onMounted, useRef } = owl; export class ActivityMarkDonePopover extends LegacyComponent { diff --git a/addons/mail/static/src/components/attachment_card/attachment_card.js b/addons/mail/static/src/components/attachment_card/attachment_card.js index f665fe283e5..77052e1784a 100644 --- a/addons/mail/static/src/components/attachment_card/attachment_card.js +++ b/addons/mail/static/src/components/attachment_card/attachment_card.js @@ -4,8 +4,6 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useComponentToModel } from '@mail/component_hooks/use_component_to_model/use_component_to_model'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - export class AttachmentCard extends LegacyComponent { /** diff --git a/addons/mail/static/src/components/attachment_image/attachment_image.js b/addons/mail/static/src/components/attachment_image/attachment_image.js index c29d34a942c..69abf40884f 100644 --- a/addons/mail/static/src/components/attachment_image/attachment_image.js +++ b/addons/mail/static/src/components/attachment_image/attachment_image.js @@ -4,8 +4,6 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useComponentToModel } from '@mail/component_hooks/use_component_to_model/use_component_to_model'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - export class AttachmentImage extends LegacyComponent { /** diff --git a/addons/mail/static/src/components/attachment_viewer/attachment_viewer.js b/addons/mail/static/src/components/attachment_viewer/attachment_viewer.js index 067881a7ac8..6570df37d43 100644 --- a/addons/mail/static/src/components/attachment_viewer/attachment_viewer.js +++ b/addons/mail/static/src/components/attachment_viewer/attachment_viewer.js @@ -3,8 +3,6 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useComponentToModel } from '@mail/component_hooks/use_component_to_model/use_component_to_model'; import { useRefs } from '@mail/component_hooks/use_refs/use_refs'; -import { link } from '@mail/model/model_field_command'; - import { hidePDFJSButtons } from '@web/legacy/js/libs/pdfjs'; const { Component, onMounted, onPatched, onWillUnmount, useRef } = owl; diff --git a/addons/mail/static/src/components/chat_window/chat_window.js b/addons/mail/static/src/components/chat_window/chat_window.js index 74cf9bfc005..6fe56844c06 100644 --- a/addons/mail/static/src/components/chat_window/chat_window.js +++ b/addons/mail/static/src/components/chat_window/chat_window.js @@ -4,7 +4,7 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useUpdate } from '@mail/component_hooks/use_update/use_update'; import { isEventHandled } from '@mail/utils/utils'; -const { Component, useRef } = owl; +const { Component } = owl; export class ChatWindow extends Component { diff --git a/addons/mail/static/src/components/chatter/chatter.js b/addons/mail/static/src/components/chatter/chatter.js index 3d01c8fa490..facceb043b6 100644 --- a/addons/mail/static/src/components/chatter/chatter.js +++ b/addons/mail/static/src/components/chatter/chatter.js @@ -5,7 +5,7 @@ import { useComponentToModel } from '@mail/component_hooks/use_component_to_mode import { useUpdate } from '@mail/component_hooks/use_update/use_update'; import { LegacyComponent } from '@web/legacy/legacy_component'; -const { Component, useRef } = owl; +const { useRef } = owl; export class Chatter extends LegacyComponent { diff --git a/addons/mail/static/src/components/discuss/discuss.js b/addons/mail/static/src/components/discuss/discuss.js index b2db1c4e931..cfe680e0411 100644 --- a/addons/mail/static/src/components/discuss/discuss.js +++ b/addons/mail/static/src/components/discuss/discuss.js @@ -4,8 +4,6 @@ import { useUpdate } from '@mail/component_hooks/use_update/use_update'; import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { LegacyComponent } from '@web/legacy/legacy_component'; -const { Component } = owl; - export class Discuss extends LegacyComponent { /** diff --git a/addons/mail/static/src/components/emoji_list/emoji_list.js b/addons/mail/static/src/components/emoji_list/emoji_list.js index f050cef3e1c..292945f8a07 100644 --- a/addons/mail/static/src/components/emoji_list/emoji_list.js +++ b/addons/mail/static/src/components/emoji_list/emoji_list.js @@ -5,8 +5,6 @@ import { useUpdate } from '@mail/component_hooks/use_update/use_update'; import emojis from '@mail/js/emojis'; import { LegacyComponent } from '@web/legacy/legacy_component'; -const { Component } = owl; - export class EmojiList extends LegacyComponent { /** diff --git a/addons/mail/static/src/components/messaging_menu/tests/messaging_menu_tests.js b/addons/mail/static/src/components/messaging_menu/tests/messaging_menu_tests.js index 5fe9caa7b0a..04e1cacb313 100644 --- a/addons/mail/static/src/components/messaging_menu/tests/messaging_menu_tests.js +++ b/addons/mail/static/src/components/messaging_menu/tests/messaging_menu_tests.js @@ -4,7 +4,6 @@ import { afterEach, afterNextRender, beforeEach, - nextAnimationFrame, start, } from '@mail/utils/test_utils'; diff --git a/addons/mail/static/src/components/rtc_layout_menu/rtc_layout_menu.js b/addons/mail/static/src/components/rtc_layout_menu/rtc_layout_menu.js index 4951b356c06..8d594e4e4de 100644 --- a/addons/mail/static/src/components/rtc_layout_menu/rtc_layout_menu.js +++ b/addons/mail/static/src/components/rtc_layout_menu/rtc_layout_menu.js @@ -4,8 +4,6 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useComponentToModel } from '@mail/component_hooks/use_component_to_model/use_component_to_model'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - export class RtcLayoutMenu extends LegacyComponent { /** diff --git a/addons/mail/static/src/components/rtc_option_list/rtc_option_list.js b/addons/mail/static/src/components/rtc_option_list/rtc_option_list.js index 90365e5db73..520423adcb9 100644 --- a/addons/mail/static/src/components/rtc_option_list/rtc_option_list.js +++ b/addons/mail/static/src/components/rtc_option_list/rtc_option_list.js @@ -4,8 +4,6 @@ import { registerMessagingComponent } from '@mail/utils/messaging_component'; import { useComponentToModel } from '@mail/component_hooks/use_component_to_model/use_component_to_model'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - export class RtcOptionList extends LegacyComponent { /** diff --git a/addons/mail/static/src/js/activity.js b/addons/mail/static/src/js/activity.js index 8862bebd360..0713d0314c4 100644 --- a/addons/mail/static/src/js/activity.js +++ b/addons/mail/static/src/js/activity.js @@ -1,7 +1,5 @@ /** @odoo-module **/ -import * as mailUtils from '@mail/js/utils'; - import AbstractField from 'web.AbstractField'; import BasicModel from 'web.BasicModel'; import config from 'web.config'; diff --git a/addons/mail/static/src/js/field_emojis_common.js b/addons/mail/static/src/js/field_emojis_common.js index 9b5eb0205c4..8dad1a26d0e 100644 --- a/addons/mail/static/src/js/field_emojis_common.js +++ b/addons/mail/static/src/js/field_emojis_common.js @@ -2,8 +2,6 @@ import emojis from '@mail/js/emojis'; import MailEmojisMixin from '@mail/js/emojis_mixin'; - -import basicFields from 'web.basic_fields'; import core from 'web.core'; var _onEmojiClickMixin = MailEmojisMixin._onEmojiClick; diff --git a/addons/mail/static/src/js/many2many_tags_email.js b/addons/mail/static/src/js/many2many_tags_email.js index 47cef8a9ec5..de1af974445 100644 --- a/addons/mail/static/src/js/many2many_tags_email.js +++ b/addons/mail/static/src/js/many2many_tags_email.js @@ -1,13 +1,11 @@ /** @odoo-module **/ import BasicModel from 'web.BasicModel'; -import core from 'web.core'; import form_common from 'web.view_dialogs'; import field_registry from 'web.field_registry'; import relational_fields from 'web.relational_fields'; var M2MTags = relational_fields.FieldMany2ManyTags; -var _t = core._t; BasicModel.include({ diff --git a/addons/mail/static/src/models/activity/activity.js b/addons/mail/static/src/models/activity/activity.js index cbd7ec95079..468d427cd1e 100644 --- a/addons/mail/static/src/models/activity/activity.js +++ b/addons/mail/static/src/models/activity/activity.js @@ -4,8 +4,6 @@ import { registerModel } from '@mail/model/model_core'; import { attr, many, one } from '@mail/model/model_field'; import { clear, insert, unlink, unlinkAll } from '@mail/model/model_field_command'; -const { markup } = owl; - registerModel({ name: 'Activity', identifyingFields: ['id'], diff --git a/addons/mail/static/src/models/follower_subtype_list/follower_subtype_list.js b/addons/mail/static/src/models/follower_subtype_list/follower_subtype_list.js index 6cf9fcda3e0..20eed282be5 100644 --- a/addons/mail/static/src/models/follower_subtype_list/follower_subtype_list.js +++ b/addons/mail/static/src/models/follower_subtype_list/follower_subtype_list.js @@ -2,7 +2,6 @@ import { registerModel } from '@mail/model/model_core'; import { attr, one } from '@mail/model/model_field'; -import { replace } from '@mail/model/model_field_command'; registerModel({ name: 'FollowerSubtypeList', diff --git a/addons/mail/static/src/models/message_action_list/message_action_list.js b/addons/mail/static/src/models/message_action_list/message_action_list.js index bbeb3196f4a..61abef25228 100644 --- a/addons/mail/static/src/models/message_action_list/message_action_list.js +++ b/addons/mail/static/src/models/message_action_list/message_action_list.js @@ -2,7 +2,7 @@ import { registerModel } from '@mail/model/model_core'; import { attr, one } from '@mail/model/model_field'; -import { clear, insertAndReplace, replace } from '@mail/model/model_field_command'; +import { clear, insertAndReplace } from '@mail/model/model_field_command'; import { markEventHandled } from '@mail/utils/utils'; registerModel({ diff --git a/addons/mail/static/src/models/popover_view/popover_view.js b/addons/mail/static/src/models/popover_view/popover_view.js index bd467328e00..c8d6488b554 100644 --- a/addons/mail/static/src/models/popover_view/popover_view.js +++ b/addons/mail/static/src/models/popover_view/popover_view.js @@ -4,8 +4,6 @@ import { registerModel } from '@mail/model/model_core'; import { attr, one } from '@mail/model/model_field'; import { clear, insertAndReplace, replace } from '@mail/model/model_field_command'; -const { Ref } = owl; - registerModel({ name: 'PopoverView', identifyingFields: [['composerViewOwnerAsEmoji', 'messageActionListOwnerAsReaction', 'threadViewTopbarOwnerAsInvite']], diff --git a/addons/mail/static/src/utils/test_utils.js b/addons/mail/static/src/utils/test_utils.js index 861a7aef03d..aa50795a7f4 100644 --- a/addons/mail/static/src/utils/test_utils.js +++ b/addons/mail/static/src/utils/test_utils.js @@ -21,7 +21,6 @@ import AbstractStorageService from 'web.AbstractStorageService'; import RamStorage from 'web.RamStorage'; import { createView, - makeTestPromise, mock, } from 'web.test_utils'; import Widget from 'web.Widget'; diff --git a/addons/mail/static/tests/webclient/commands/mail_providers_tests.js b/addons/mail/static/tests/webclient/commands/mail_providers_tests.js index 5905e67cda2..f7954936468 100644 --- a/addons/mail/static/tests/webclient/commands/mail_providers_tests.js +++ b/addons/mail/static/tests/webclient/commands/mail_providers_tests.js @@ -42,7 +42,7 @@ QUnit.module('mail', {}, function () { ); const target = getFixture(); - const { widget: webClient } = await start({ + await start({ data: this.data, hasChatWindow: true, hasWebClient: true, @@ -81,7 +81,7 @@ QUnit.module('mail', {}, function () { members: [this.data.currentPartnerId], }); const target = getFixture(); - const { widget: webClient } = await start({ + await start({ data: this.data, hasChatWindow: true, hasWebClient: true, diff --git a/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js b/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js index 946885533aa..40adf1db3d4 100644 --- a/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js +++ b/addons/mass_mailing/static/src/js/mailing_mailing_view_form_full_width.js @@ -3,7 +3,7 @@ import FormView from 'web.FormView'; import FormController from 'web.FormController'; import FormRenderer from 'web.FormRenderer'; -import { bus, _t } from 'web.core'; +import { bus } from 'web.core'; import viewRegistry from 'web.view_registry'; import config from 'web.config'; diff --git a/addons/mass_mailing/static/src/js/mass_mailing_widget.js b/addons/mass_mailing/static/src/js/mass_mailing_widget.js index 9c07ede8e7a..aa52e478395 100644 --- a/addons/mass_mailing/static/src/js/mass_mailing_widget.js +++ b/addons/mass_mailing/static/src/js/mass_mailing_widget.js @@ -247,7 +247,6 @@ var MassMailingFieldHtml = FieldHtml.extend({ this.$content.closest('body').removeClass(this._allClasses).addClass(themeParams.className); const old_layout = this.$content.find('.o_layout')[0]; - const $old_layout = $(old_layout); var $new_wrapper; var $newWrapperContent; diff --git a/addons/mass_mailing/static/tests/mass_mailing_html_tests.js b/addons/mass_mailing/static/tests/mass_mailing_html_tests.js index e039fa14c86..7c63ebc6d6a 100644 --- a/addons/mass_mailing/static/tests/mass_mailing_html_tests.js +++ b/addons/mass_mailing/static/tests/mass_mailing_html_tests.js @@ -3,12 +3,8 @@ odoo.define('mass_mailing.field_html_tests', function (require) { var ajax = require('web.ajax'); var FormView = require('web.FormView'); -var FieldHtml = require('web_editor.field.html'); -var MassMailingFieldHtml = require('mass_mailing.FieldHtml'); var testUtils = require('web.test_utils'); var weTestUtils = require('web_editor.test_utils'); -var Wysiwyg = require('web_editor.wysiwyg'); - QUnit.module('mass_mailing', {}, function () { QUnit.module('field html', { diff --git a/addons/microsoft_calendar/static/src/js/microsoft_calendar.js b/addons/microsoft_calendar/static/src/js/microsoft_calendar.js index 1c3adb6fce1..35fcac650be 100644 --- a/addons/microsoft_calendar/static/src/js/microsoft_calendar.js +++ b/addons/microsoft_calendar/static/src/js/microsoft_calendar.js @@ -4,11 +4,9 @@ odoo.define('microsoft_calendar.CalendarView', function (require) { var core = require('web.core'); var Dialog = require('web.Dialog'); var framework = require('web.framework'); -const CalendarView = require('@calendar/js/calendar_view')[Symbol.for("default")]; const CalendarRenderer = require('@calendar/js/calendar_renderer')[Symbol.for("default")].AttendeeCalendarRenderer; const CalendarController = require('@calendar/js/calendar_controller')[Symbol.for("default")]; const CalendarModel = require('@calendar/js/calendar_model')[Symbol.for("default")]; -const viewRegistry = require('web.view_registry'); const session = require('web.session'); var _t = core._t; @@ -263,7 +261,6 @@ const MicrosoftCalendarRenderer = CalendarRenderer.include({ */ _onSyncMicrosoftCalendar: function () { var self = this; - var context = this.getSession().user_context; this.$microsoftButton.prop('disabled', true); this.trigger_up('syncMicrosoftCalendar', { on_always: function () { diff --git a/addons/point_of_sale/static/src/js/PosComponent.js b/addons/point_of_sale/static/src/js/PosComponent.js index adf6e149358..51b82078721 100644 --- a/addons/point_of_sale/static/src/js/PosComponent.js +++ b/addons/point_of_sale/static/src/js/PosComponent.js @@ -2,7 +2,7 @@ odoo.define('point_of_sale.PosComponent', function (require) { 'use strict'; const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, onRendered } = owl; + const { onRendered } = owl; class PosComponent extends LegacyComponent { setup() { diff --git a/addons/point_of_sale/static/src/js/Screens/PartnerListScreen/PartnerListScreen.js b/addons/point_of_sale/static/src/js/Screens/PartnerListScreen/PartnerListScreen.js index 750a78ccbd6..a731a5d394f 100644 --- a/addons/point_of_sale/static/src/js/Screens/PartnerListScreen/PartnerListScreen.js +++ b/addons/point_of_sale/static/src/js/Screens/PartnerListScreen/PartnerListScreen.js @@ -103,7 +103,6 @@ odoo.define('point_of_sale.PartnerListScreen', function(require) { // We declare this event handler as a debounce function in // order to lower its trigger rate. async updatePartnerList(event) { - let newPartnerList = await this.getNewPartners(); this.state.query = event.target.value; const partners = this.partners; if (event.code === 'Enter' && partners.length === 1) { diff --git a/addons/point_of_sale/static/src/js/utils.js b/addons/point_of_sale/static/src/js/utils.js index 3ec44b28759..e419029f9bf 100644 --- a/addons/point_of_sale/static/src/js/utils.js +++ b/addons/point_of_sale/static/src/js/utils.js @@ -3,8 +3,6 @@ odoo.define('point_of_sale.utils', function (require) { const { ConnectionAbortedError, ConnectionLostError } = require('@web/core/network/rpc_service'); - const { EventBus } = owl; - function getFileAsText(file) { return new Promise((resolve, reject) => { if (!file) { diff --git a/addons/point_of_sale/static/tests/tours/point_of_sale.js b/addons/point_of_sale/static/tests/tours/point_of_sale.js index c1f10d03c24..efd5d952976 100644 --- a/addons/point_of_sale/static/tests/tours/point_of_sale.js +++ b/addons/point_of_sale/static/tests/tours/point_of_sale.js @@ -3,7 +3,6 @@ odoo.define('point_of_sale.tour.pricelist', function (require) { "use strict"; var Tour = require('web_tour.tour'); - var rpc = require('web.rpc'); var utils = require('web.utils'); var round_di = utils.round_decimals; @@ -240,18 +239,6 @@ odoo.define('point_of_sale.tour.acceptance', function (require) { }]; } - function generate_keypad_steps(amount_str, keypad_selector) { - var i, steps = [], current_char; - for (i = 0; i < amount_str.length; ++i) { - current_char = amount_str[i]; - steps.push({ - content: 'press ' + current_char + ' on payment keypad', - trigger: keypad_selector + ' .input-button:contains("' + current_char + '"):visible' - }); - } - return steps; - } - function press_payment_numpad(val) { return [{ content: `press ${val} on payment screen numpad`, diff --git a/addons/point_of_sale/static/tests/unit/helpers/test_env.js b/addons/point_of_sale/static/tests/unit/helpers/test_env.js index 49fca2fccc3..7001a440433 100644 --- a/addons/point_of_sale/static/tests/unit/helpers/test_env.js +++ b/addons/point_of_sale/static/tests/unit/helpers/test_env.js @@ -11,7 +11,6 @@ odoo.define('point_of_sale.test_env', async function (require) { const makeTestEnvironment = require('web.test_env'); const env = require('point_of_sale.env'); const { PosGlobalState } = require('point_of_sale.models'); - const Registries = require('point_of_sale.Registries'); const cleanup = require("@web/../tests/helpers/cleanup"); // We override this method in the pos unit tests to prevent the unnecessary error in the web tests. diff --git a/addons/point_of_sale/static/tests/unit/test_NumberBuffer.js b/addons/point_of_sale/static/tests/unit/test_NumberBuffer.js index bf1fd4e7692..3b834472ffe 100644 --- a/addons/point_of_sale/static/tests/unit/test_NumberBuffer.js +++ b/addons/point_of_sale/static/tests/unit/test_NumberBuffer.js @@ -7,7 +7,7 @@ odoo.define('point_of_sale.tests.NumberBuffer', function(require) { const { mount } = require('@web/../tests/helpers/utils'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState, xml } = owl; + const { useState, xml } = owl; QUnit.module('unit tests for NumberBuffer', { before() {}, diff --git a/addons/portal/static/src/js/portal_chatter.js b/addons/portal/static/src/js/portal_chatter.js index ec399e5075d..ed2e70ea43a 100644 --- a/addons/portal/static/src/js/portal_chatter.js +++ b/addons/portal/static/src/js/portal_chatter.js @@ -30,7 +30,6 @@ var PortalChatter = publicWidget.Widget.extend({ * @constructor */ init: function (parent, options) { - var self = this; this.options = {}; this._super.apply(this, arguments); diff --git a/addons/pos_hr/static/src/js/CashierName.js b/addons/pos_hr/static/src/js/CashierName.js index cbbca8535d3..343e3868ee6 100644 --- a/addons/pos_hr/static/src/js/CashierName.js +++ b/addons/pos_hr/static/src/js/CashierName.js @@ -1,4 +1,3 @@ -/* global Sha1 */ odoo.define('pos_hr.CashierName', function (require) { 'use strict'; diff --git a/addons/pos_hr/static/src/js/LoginScreen.js b/addons/pos_hr/static/src/js/LoginScreen.js index dcb73be80b5..a431464be23 100644 --- a/addons/pos_hr/static/src/js/LoginScreen.js +++ b/addons/pos_hr/static/src/js/LoginScreen.js @@ -1,4 +1,3 @@ -/* global Sha1 */ odoo.define('pos_hr.LoginScreen', function (require) { 'use strict'; diff --git a/addons/pos_restaurant/static/src/js/Screens/ProductScreen/ControlButtons/SubmitOrderButton.js b/addons/pos_restaurant/static/src/js/Screens/ProductScreen/ControlButtons/SubmitOrderButton.js index 25af2d221b4..3a09241151b 100644 --- a/addons/pos_restaurant/static/src/js/Screens/ProductScreen/ControlButtons/SubmitOrderButton.js +++ b/addons/pos_restaurant/static/src/js/Screens/ProductScreen/ControlButtons/SubmitOrderButton.js @@ -6,8 +6,6 @@ odoo.define('pos_restaurant.SubmitOrderButton', function(require) { const { useListener } = require("@web/core/utils/hooks"); const Registries = require('point_of_sale.Registries'); - const { onWillUnmount } = owl; - /** * IMPROVEMENT: Perhaps this class is quite complicated for its worth. * This is because it needs to listen to changes to the current order. diff --git a/addons/pos_sale/static/src/js/OrderManagementScreen/SaleOrderFetcher.js b/addons/pos_sale/static/src/js/OrderManagementScreen/SaleOrderFetcher.js index bb676db3555..f6f4ef145aa 100644 --- a/addons/pos_sale/static/src/js/OrderManagementScreen/SaleOrderFetcher.js +++ b/addons/pos_sale/static/src/js/OrderManagementScreen/SaleOrderFetcher.js @@ -42,7 +42,6 @@ odoo.define('pos_sale.SaleOrderFetcher', function (require) { async fetch() { try { let limit, offset; - let start, end; // Show orders from the backend. offset = this.nPerPage + diff --git a/addons/pos_sale/static/src/js/SetSaleOrderButton.js b/addons/pos_sale/static/src/js/SetSaleOrderButton.js index 1ad3296851b..d0dd57ecb89 100644 --- a/addons/pos_sale/static/src/js/SetSaleOrderButton.js +++ b/addons/pos_sale/static/src/js/SetSaleOrderButton.js @@ -7,8 +7,6 @@ odoo.define('pos_sale.SetSaleOrderButton', function(require) { const Registries = require('point_of_sale.Registries'); const { isConnectionError } = require('point_of_sale.utils'); - const { onMounted, onWillUnmount } = owl; - class SetSaleOrderButton extends PosComponent { setup() { super.setup(); diff --git a/addons/project/static/src/js/right_panel/project_right_panel.js b/addons/project/static/src/js/right_panel/project_right_panel.js index c2235673010..5eadfdc0af4 100644 --- a/addons/project/static/src/js/right_panel/project_right_panel.js +++ b/addons/project/static/src/js/right_panel/project_right_panel.js @@ -4,7 +4,7 @@ import { AddMilestone, OpenMilestone } from '@project/js/right_panel/project_uti import { formatFloat } from "@web/fields/formatters"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillStart, onWillUpdateProps, useState } = owl; +const { onWillStart, onWillUpdateProps, useState } = owl; export default class ProjectRightPanel extends LegacyComponent { setup() { diff --git a/addons/project/static/src/js/right_panel/project_utils.js b/addons/project/static/src/js/right_panel/project_utils.js index e4f9f959dec..3bf3b2d801a 100644 --- a/addons/project/static/src/js/right_panel/project_utils.js +++ b/addons/project/static/src/js/right_panel/project_utils.js @@ -1,12 +1,11 @@ /** @odoo-module **/ -import { _lt } from 'web.core'; import fieldUtils from 'web.field_utils'; import { ComponentAdapter, standaloneAdapter } from 'web.OwlCompatibility'; import { FormViewDialog } from 'web.view_dialogs'; import { useService } from "@web/core/utils/hooks"; -const { Component, onWillUpdateProps, useRef, useState } = owl; +const { Component, onWillUpdateProps, useState } = owl; class MilestoneComponent extends Component { setup() { diff --git a/addons/project/static/src/js/widgets/project_name_with_subtask_count_widget.js b/addons/project/static/src/js/widgets/project_name_with_subtask_count_widget.js index a5adeb94cf0..a9266fb8e12 100644 --- a/addons/project/static/src/js/widgets/project_name_with_subtask_count_widget.js +++ b/addons/project/static/src/js/widgets/project_name_with_subtask_count_widget.js @@ -11,8 +11,8 @@ export const FieldNameWithSubTaskCount = FieldChar.extend({ this._super(...arguments); if (this.viewType === 'kanban') { // remove click event handler - const {click, ...events} = this.events; - this.events = events; + this.events = { ...this.events }; + delete this.events.click; } }, diff --git a/addons/project/static/src/project_sharing/components/favorite_menu_registry.js b/addons/project/static/src/project_sharing/components/favorite_menu_registry.js index 13b05bf1556..bdde197a993 100644 --- a/addons/project/static/src/project_sharing/components/favorite_menu_registry.js +++ b/addons/project/static/src/project_sharing/components/favorite_menu_registry.js @@ -27,7 +27,7 @@ export function prepareFavoriteMenuRegister() { customFavoriteItemKey = 'custom-favorite-item'; const favoriteMenuRegistry = registry.category("favoriteMenu"); - for (const [key, _] of favoriteMenuRegistry.getEntries()) { + for (const [key] of favoriteMenuRegistry.getEntries()) { if (key !== customFavoriteItemKey) { favoriteMenuRegistry.remove(key); } diff --git a/addons/project/static/src/project_sharing/project_sharing.js b/addons/project/static/src/project_sharing/project_sharing.js index ffae7e7d9aa..bce34f00c6f 100644 --- a/addons/project/static/src/project_sharing/project_sharing.js +++ b/addons/project/static/src/project_sharing/project_sharing.js @@ -8,7 +8,7 @@ import { ErrorHandler } from "@web/core/utils/components"; import { session } from '@web/session'; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useEffect } = owl; +const { useEffect } = owl; export class ProjectSharingWebClient extends LegacyComponent { setup() { diff --git a/addons/stock/static/src/js/inventory_singleton_list_renderer.js b/addons/stock/static/src/js/inventory_singleton_list_renderer.js index b8eedd810da..970f0ddfbec 100644 --- a/addons/stock/static/src/js/inventory_singleton_list_renderer.js +++ b/addons/stock/static/src/js/inventory_singleton_list_renderer.js @@ -1,11 +1,8 @@ odoo.define('stock.SingletonListRenderer', function (require) { "use strict"; -var core = require('web.core'); var ListRenderer = require('web.ListRenderer'); -var _t = core._t; - /** * The purpose of this override is to disable line buttons when the row is edited. * diff --git a/addons/stock/static/src/js/popover_widget.js b/addons/stock/static/src/js/popover_widget.js index 97f6a4c05ee..965c3c55fe6 100644 --- a/addons/stock/static/src/js/popover_widget.js +++ b/addons/stock/static/src/js/popover_widget.js @@ -5,7 +5,6 @@ var AbstractField = require('web.AbstractField'); var core = require('web.core'); var QWeb = core.qweb; var Context = require('web.Context'); -var data_manager = require('web.data_manager'); var fieldRegistry = require('web.field_registry'); /** diff --git a/addons/stock/static/src/js/stock_orderpoint_list_controller.js b/addons/stock/static/src/js/stock_orderpoint_list_controller.js index 3bcc90cc3b3..ff38d58a4bb 100644 --- a/addons/stock/static/src/js/stock_orderpoint_list_controller.js +++ b/addons/stock/static/src/js/stock_orderpoint_list_controller.js @@ -3,7 +3,6 @@ odoo.define('stock.StockOrderpointListController', function (require) { var core = require('web.core'); var ListController = require('web.ListController'); -var FormView = require('web.FormView'); var qweb = core.qweb; diff --git a/addons/stock/static/src/js/stock_orderpoint_list_model.js b/addons/stock/static/src/js/stock_orderpoint_list_model.js index c9f0acb9012..dc65dde3f1d 100644 --- a/addons/stock/static/src/js/stock_orderpoint_list_model.js +++ b/addons/stock/static/src/js/stock_orderpoint_list_model.js @@ -1,11 +1,8 @@ odoo.define('stock.StockOrderpointListModel', function (require) { "use strict"; -var core = require('web.core'); var ListModel = require('web.ListModel'); -var qweb = core.qweb; - var StockOrderpointListModel = ListModel.extend({ diff --git a/addons/test_event_full/static/src/js/tours/wevent_register_tour.js b/addons/test_event_full/static/src/js/tours/wevent_register_tour.js index 782b3fea0c0..c7ee4b4cd50 100644 --- a/addons/test_event_full/static/src/js/tours/wevent_register_tour.js +++ b/addons/test_event_full/static/src/js/tours/wevent_register_tour.js @@ -134,11 +134,6 @@ var browseTalksSteps = [{ trigger: 'a:contains("Talks")', }]; -var browseExhibitorsSteps = [{ - content: 'Browse Exhibitors', - trigger: 'a:contains("Exhibitors")', -}]; - var browseMeetSteps = [{ content: 'Browse Meet', trigger: 'a:contains("Community")', diff --git a/addons/web/static/src/core/commands/default_providers.js b/addons/web/static/src/core/commands/default_providers.js index a35be087e8f..e5a80830cb5 100644 --- a/addons/web/static/src/core/commands/default_providers.js +++ b/addons/web/static/src/core/commands/default_providers.js @@ -9,8 +9,6 @@ import { getVisibleElements } from "@web/core/utils/ui"; import { DefaultCommandItem } from "./command_palette"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - const commandSetupRegistry = registry.category("command_setup"); commandSetupRegistry.add("default", { emptyMessage: _lt("No command found"), diff --git a/addons/web/static/src/core/datepicker/datepicker.js b/addons/web/static/src/core/datepicker/datepicker.js index 4851e053870..622dca86bae 100644 --- a/addons/web/static/src/core/datepicker/datepicker.js +++ b/addons/web/static/src/core/datepicker/datepicker.js @@ -6,7 +6,6 @@ import { useAutofocus } from "@web/core/utils/hooks"; import { LegacyComponent } from "@web/legacy/legacy_component"; const { - Component, onMounted, onWillUpdateProps, onWillUnmount, diff --git a/addons/web/static/src/core/dialog/dialog.js b/addons/web/static/src/core/dialog/dialog.js index 69e2ab772b5..b5b7ad1d425 100644 --- a/addons/web/static/src/core/dialog/dialog.js +++ b/addons/web/static/src/core/dialog/dialog.js @@ -4,7 +4,7 @@ import { useHotkey } from "@web/core/hotkeys/hotkey_hook"; import { useActiveElement } from "../ui/ui_service"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useRef, useChildSubEnv, xml } = owl; +const { useRef, useChildSubEnv, xml } = owl; export class Dialog extends LegacyComponent { setup() { diff --git a/addons/web/static/src/core/dropdown/dropdown.js b/addons/web/static/src/core/dropdown/dropdown.js index fe4c6eeb717..9f694bc77ae 100644 --- a/addons/web/static/src/core/dropdown/dropdown.js +++ b/addons/web/static/src/core/dropdown/dropdown.js @@ -7,7 +7,6 @@ import { localization } from "../l10n/localization"; import { LegacyComponent } from "@web/legacy/legacy_component"; const { - Component, EventBus, onWillStart, useEffect, diff --git a/addons/web/static/src/core/dropdown/dropdown_item.js b/addons/web/static/src/core/dropdown/dropdown_item.js index 12792213c2d..e2c95778cb0 100644 --- a/addons/web/static/src/core/dropdown/dropdown_item.js +++ b/addons/web/static/src/core/dropdown/dropdown_item.js @@ -2,8 +2,6 @@ import { DROPDOWN } from "./dropdown"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - /** * @enum {string} */ diff --git a/addons/web/static/src/core/effects/rainbow_man.js b/addons/web/static/src/core/effects/rainbow_man.js index 717f07aabb5..45b2017b873 100644 --- a/addons/web/static/src/core/effects/rainbow_man.js +++ b/addons/web/static/src/core/effects/rainbow_man.js @@ -3,7 +3,7 @@ import { browser } from "@web/core/browser/browser"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useEffect, useExternalListener } = owl; +const { useEffect, useExternalListener } = owl; /** * @typedef Common diff --git a/addons/web/static/src/core/file_input/file_input.js b/addons/web/static/src/core/file_input/file_input.js index c2910b6c53e..d013cfe48ba 100644 --- a/addons/web/static/src/core/file_input/file_input.js +++ b/addons/web/static/src/core/file_input/file_input.js @@ -3,7 +3,7 @@ import { useService } from "@web/core/utils/hooks"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useRef } = owl; +const { useRef } = owl; /** * Custom file input diff --git a/addons/web/static/src/core/utils/components.js b/addons/web/static/src/core/utils/components.js index 7b8099325ba..254d2fd79c2 100644 --- a/addons/web/static/src/core/utils/components.js +++ b/addons/web/static/src/core/utils/components.js @@ -1,6 +1,6 @@ /** @odoo-module **/ -const { Component, onError, useComponent, xml } = owl; +const { Component, onError, xml } = owl; export class ErrorHandler extends Component { setup() { diff --git a/addons/web/static/src/legacy/js/components/action_menus.js b/addons/web/static/src/legacy/js/components/action_menus.js index a93b947d56a..c84339a6c44 100644 --- a/addons/web/static/src/legacy/js/components/action_menus.js +++ b/addons/web/static/src/legacy/js/components/action_menus.js @@ -7,7 +7,6 @@ odoo.define('web.ActionMenus', function (require) { const { LegacyComponent } = require("@web/legacy/legacy_component"); const { - Component, onMounted, onPatched, onWillStart, diff --git a/addons/web/static/src/legacy/js/components/custom_checkbox.js b/addons/web/static/src/legacy/js/components/custom_checkbox.js index 6c32c9785d4..fee2457fbae 100644 --- a/addons/web/static/src/legacy/js/components/custom_checkbox.js +++ b/addons/web/static/src/legacy/js/components/custom_checkbox.js @@ -4,8 +4,6 @@ odoo.define('web.CustomCheckbox', function (require) { const utils = require('web.utils'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component } = owl; - /** * Custom checkbox * diff --git a/addons/web/static/src/legacy/js/components/custom_file_input.js b/addons/web/static/src/legacy/js/components/custom_file_input.js index 81ae42e0a6d..fd4a36a6722 100644 --- a/addons/web/static/src/legacy/js/components/custom_file_input.js +++ b/addons/web/static/src/legacy/js/components/custom_file_input.js @@ -2,7 +2,7 @@ odoo.define('web.CustomFileInput', function (require) { "use strict"; const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useRef } = owl; + const { useRef } = owl; /** * Custom file input diff --git a/addons/web/static/src/legacy/js/components/datepicker.js b/addons/web/static/src/legacy/js/components/datepicker.js index 62e17591bb9..da4a909c4d5 100644 --- a/addons/web/static/src/legacy/js/components/datepicker.js +++ b/addons/web/static/src/legacy/js/components/datepicker.js @@ -7,7 +7,6 @@ odoo.define('web.DatePickerOwl', function (require) { const { LegacyComponent } = require("@web/legacy/legacy_component"); const { - Component, onMounted, onPatched, onWillUnmount, diff --git a/addons/web/static/src/legacy/js/components/dropdown_menu.js b/addons/web/static/src/legacy/js/components/dropdown_menu.js index 0fcb7240a0e..881d2e2bd76 100644 --- a/addons/web/static/src/legacy/js/components/dropdown_menu.js +++ b/addons/web/static/src/legacy/js/components/dropdown_menu.js @@ -5,7 +5,7 @@ odoo.define('web.DropdownMenu', function (require) { const DropdownMenuItem = require('web.DropdownMenuItem'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useExternalListener, useRef, useState } = owl; + const { useExternalListener, useRef, useState } = owl; /** * Dropdown menu diff --git a/addons/web/static/src/legacy/js/components/dropdown_menu_item.js b/addons/web/static/src/legacy/js/components/dropdown_menu_item.js index 2b047e8c8f6..c70a58ae206 100644 --- a/addons/web/static/src/legacy/js/components/dropdown_menu_item.js +++ b/addons/web/static/src/legacy/js/components/dropdown_menu_item.js @@ -4,7 +4,7 @@ odoo.define('web.DropdownMenuItem', function (require) { const { useListener } = require("@web/core/utils/hooks"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useExternalListener, useRef, useState } = owl; + const { useExternalListener, useRef, useState } = owl; /** * Dropdown menu item diff --git a/addons/web/static/src/legacy/js/components/pager.js b/addons/web/static/src/legacy/js/components/pager.js index 390141b5325..bca9178753f 100644 --- a/addons/web/static/src/legacy/js/components/pager.js +++ b/addons/web/static/src/legacy/js/components/pager.js @@ -4,7 +4,7 @@ odoo.define('web.Pager', function (require) { const { useAutofocus } = require("@web/core/utils/hooks"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, onWillUpdateProps, useState } = owl; + const { onWillUpdateProps, useState } = owl; /** * Pager diff --git a/addons/web/static/src/legacy/js/control_panel/comparison_menu.js b/addons/web/static/src/legacy/js/control_panel/comparison_menu.js index cfbcdeb1246..a28057bbc6b 100644 --- a/addons/web/static/src/legacy/js/control_panel/comparison_menu.js +++ b/addons/web/static/src/legacy/js/control_panel/comparison_menu.js @@ -7,8 +7,6 @@ odoo.define("web.ComparisonMenu", function (require) { const { useModel } = require("web.Model"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component } = owl; - class ComparisonMenu extends LegacyComponent { setup() { this.icon = FACET_ICONS.comparison; diff --git a/addons/web/static/src/legacy/js/control_panel/control_panel.js b/addons/web/static/src/legacy/js/control_panel/control_panel.js index 5e9fbab459a..7c8846b661b 100644 --- a/addons/web/static/src/legacy/js/control_panel/control_panel.js +++ b/addons/web/static/src/legacy/js/control_panel/control_panel.js @@ -13,7 +13,6 @@ odoo.define('web.ControlPanel', function (require) { const { LegacyComponent } = require("@web/legacy/legacy_component"); const { - Component, onMounted, onPatched, onWillDestroy, diff --git a/addons/web/static/src/legacy/js/control_panel/custom_favorite_item.js b/addons/web/static/src/legacy/js/control_panel/custom_favorite_item.js index 0b8e11f06dd..24ba1408cfd 100644 --- a/addons/web/static/src/legacy/js/control_panel/custom_favorite_item.js +++ b/addons/web/static/src/legacy/js/control_panel/custom_favorite_item.js @@ -8,7 +8,7 @@ odoo.define('web.CustomFavoriteItem', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState } = owl; + const { useState } = owl; let favoriteId = 0; diff --git a/addons/web/static/src/legacy/js/control_panel/custom_filter_item.js b/addons/web/static/src/legacy/js/control_panel/custom_filter_item.js index c4140e56a0b..1b1b46c366d 100644 --- a/addons/web/static/src/legacy/js/control_panel/custom_filter_item.js +++ b/addons/web/static/src/legacy/js/control_panel/custom_filter_item.js @@ -2,7 +2,6 @@ odoo.define('web.CustomFilterItem', function (require) { "use strict"; const { Dropdown } = require("@web/core/dropdown/dropdown"); - const { DropdownItem } = require("@web/core/dropdown/dropdown_item"); const { DatePicker, DateTimePicker } = require('web.DatePickerOwl'); const Domain = require('web.Domain'); const { FIELD_OPERATORS, FIELD_TYPES } = require('web.searchUtils'); @@ -10,7 +9,7 @@ odoo.define('web.CustomFilterItem', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState } = owl; + const { useState } = owl; /** * Filter generator menu diff --git a/addons/web/static/src/legacy/js/control_panel/favorite_menu.js b/addons/web/static/src/legacy/js/control_panel/favorite_menu.js index d03644d64ee..4f3a735cf28 100644 --- a/addons/web/static/src/legacy/js/control_panel/favorite_menu.js +++ b/addons/web/static/src/legacy/js/control_panel/favorite_menu.js @@ -9,7 +9,7 @@ odoo.define('web.FavoriteMenu', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState } = owl; + const { useState } = owl; /** * 'Favorites' menu diff --git a/addons/web/static/src/legacy/js/control_panel/filter_menu.js b/addons/web/static/src/legacy/js/control_panel/filter_menu.js index 735c57f8ea7..772797053e5 100644 --- a/addons/web/static/src/legacy/js/control_panel/filter_menu.js +++ b/addons/web/static/src/legacy/js/control_panel/filter_menu.js @@ -8,8 +8,6 @@ odoo.define('web.FilterMenu', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component } = owl; - /** * 'Filters' menu * diff --git a/addons/web/static/src/legacy/js/control_panel/groupby_menu.js b/addons/web/static/src/legacy/js/control_panel/groupby_menu.js index 7e95d572987..0c47d9e566a 100644 --- a/addons/web/static/src/legacy/js/control_panel/groupby_menu.js +++ b/addons/web/static/src/legacy/js/control_panel/groupby_menu.js @@ -8,8 +8,6 @@ odoo.define('web.GroupByMenu', function (require) { const { useModel } = require('web.Model'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component } = owl; - class GroupByMenu extends LegacyComponent { setup() { diff --git a/addons/web/static/src/legacy/js/control_panel/search_bar.js b/addons/web/static/src/legacy/js/control_panel/search_bar.js index 2bb6e95665c..865f1d6e691 100644 --- a/addons/web/static/src/legacy/js/control_panel/search_bar.js +++ b/addons/web/static/src/legacy/js/control_panel/search_bar.js @@ -8,7 +8,7 @@ odoo.define('web.SearchBar', function (require) { const { fuzzyTest } = require('@web/core/utils/search'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, onMounted, onWillUnmount, toRaw, useExternalListener, useState } = owl; + const { onMounted, onWillUnmount, toRaw, useExternalListener, useState } = owl; const CHAR_FIELDS = ['char', 'html', 'many2many', 'many2one', 'one2many', 'text']; let sourceId = 0; diff --git a/addons/web/static/src/legacy/js/core/dom.js b/addons/web/static/src/legacy/js/core/dom.js index 38c1a0c3729..9f2f668003f 100644 --- a/addons/web/static/src/legacy/js/core/dom.js +++ b/addons/web/static/src/legacy/js/core/dom.js @@ -20,7 +20,6 @@ odoo.define('web.dom', function (require) { */ var concurrency = require('web.concurrency'); -var config = require('web.config'); var core = require('web.core'); var _t = core._t; diff --git a/addons/web/static/src/legacy/js/core/domain.js b/addons/web/static/src/legacy/js/core/domain.js index d5535f4af03..4192b0066a8 100644 --- a/addons/web/static/src/legacy/js/core/domain.js +++ b/addons/web/static/src/legacy/js/core/domain.js @@ -322,7 +322,6 @@ var Domain = collections.Tree.extend({ if (!domain.length) { return 'True'; } - var self = this; function consume(stack) { var len = stack.length; if (len <= 1) { diff --git a/addons/web/static/src/legacy/js/core/error_utils.js b/addons/web/static/src/legacy/js/core/error_utils.js index 83ec86626c9..6f7ccc60f51 100644 --- a/addons/web/static/src/legacy/js/core/error_utils.js +++ b/addons/web/static/src/legacy/js/core/error_utils.js @@ -12,7 +12,6 @@ import { _t } from "web.core"; * @returns {string} */ export function formatTraceback(error) { - const traceback = error.stack; // Error.prototype.stack is non-standard. // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error // However, most engines provide an implementation. diff --git a/addons/web/static/src/legacy/js/core/owl_dialog.js b/addons/web/static/src/legacy/js/core/owl_dialog.js index 8c9dca0f4df..ce9eae72061 100644 --- a/addons/web/static/src/legacy/js/core/owl_dialog.js +++ b/addons/web/static/src/legacy/js/core/owl_dialog.js @@ -1,7 +1,7 @@ odoo.define('web.OwlDialog', function (require) { "use strict"; - const { Component, useRef, onMounted, onWillUnmount } = owl; + const { useRef, onMounted, onWillUnmount } = owl; const SIZE_CLASSES = { 'extra-large': 'modal-xl', 'large': 'modal-lg', diff --git a/addons/web/static/src/legacy/js/core/popover.js b/addons/web/static/src/legacy/js/core/popover.js index 2e98ea37bae..1e9d440df4c 100644 --- a/addons/web/static/src/legacy/js/core/popover.js +++ b/addons/web/static/src/legacy/js/core/popover.js @@ -2,7 +2,7 @@ odoo.define('web.Popover', function (require) { 'use strict'; const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, status, onWillUnmount, useEffect, useRef, useState } = owl; + const { status, onWillUnmount, useEffect, useRef, useState } = owl; /** * Popover diff --git a/addons/web/static/src/legacy/js/fields/abstract_field_owl.js b/addons/web/static/src/legacy/js/fields/abstract_field_owl.js index e6fbe2b6703..6631348dc29 100644 --- a/addons/web/static/src/legacy/js/fields/abstract_field_owl.js +++ b/addons/web/static/src/legacy/js/fields/abstract_field_owl.js @@ -5,7 +5,7 @@ odoo.define('web.AbstractFieldOwl', function (require) { const { useListener } = require("@web/core/utils/hooks"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, onWillUpdateProps, useEffect } = owl; + const { onWillUpdateProps, useEffect } = owl; /** * This file defines the Owl version of the AbstractField. Specific fields diff --git a/addons/web/static/src/legacy/js/fields/relational_fields.js b/addons/web/static/src/legacy/js/fields/relational_fields.js index acbead18f05..ba22f2c7378 100644 --- a/addons/web/static/src/legacy/js/fields/relational_fields.js +++ b/addons/web/static/src/legacy/js/fields/relational_fields.js @@ -14,7 +14,6 @@ odoo.define('web.relational_fields', function (require) { */ var AbstractField = require('web.AbstractField'); -var basicFields = require('web.basic_fields'); var concurrency = require('web.concurrency'); const ControlPanelX2Many = require('web.ControlPanelX2Many'); var core = require('web.core'); @@ -2793,7 +2792,8 @@ var FieldMany2ManyTagsAvatar = FieldMany2ManyTags.extend({ // Remove event handlers on this widget to ensure that the kanban 'global // click' opens the clicked record -const { click, ...M2MAvatarMixinEvents } = AbstractField.prototype.events; +const M2MAvatarMixinEvents = { ...AbstractField.prototype.events }; +delete M2MAvatarMixinEvents.click; const M2MAvatarMixin = { visibleAvatarCount: 3, // number of visible avatar events: M2MAvatarMixinEvents, diff --git a/addons/web/static/src/legacy/js/public/public_widget.js b/addons/web/static/src/legacy/js/public/public_widget.js index ef2805b12b2..0bc15140570 100644 --- a/addons/web/static/src/legacy/js/public/public_widget.js +++ b/addons/web/static/src/legacy/js/public/public_widget.js @@ -5,7 +5,6 @@ */ import dom from 'web.dom'; -import session from 'web.session'; import Widget from 'web.Widget'; /** diff --git a/addons/web/static/src/legacy/js/services/data_manager.js b/addons/web/static/src/legacy/js/services/data_manager.js index f5bb482a66d..45c56c7384c 100644 --- a/addons/web/static/src/legacy/js/services/data_manager.js +++ b/addons/web/static/src/legacy/js/services/data_manager.js @@ -93,7 +93,7 @@ return core.Class.extend({ // Freeze the fields dict as it will be shared between views and // no one should edit it utils.deepFreeze(result.fields); - for (const [viewId, viewType] of views_descr) { + for (const [ /* viewId */ , viewType] of views_descr) { const fvg = result.fields_views[viewType]; fvg.viewFields = fvg.fields; fvg.fields = result.fields; diff --git a/addons/web/static/src/legacy/js/views/abstract_controller.js b/addons/web/static/src/legacy/js/views/abstract_controller.js index 87f37912029..631fbdf11c0 100644 --- a/addons/web/static/src/legacy/js/views/abstract_controller.js +++ b/addons/web/static/src/legacy/js/views/abstract_controller.js @@ -18,8 +18,6 @@ import { ComponentWrapper } from 'web.OwlCompatibility'; import mvc from 'web.mvc'; import session from 'web.session'; -const { Component } = owl; - var AbstractController = mvc.Controller.extend(ActionMixin, { custom_events: _.extend({}, ActionMixin.custom_events, { navigation_move: '_onNavigationMove', diff --git a/addons/web/static/src/legacy/js/views/abstract_renderer_owl.js b/addons/web/static/src/legacy/js/views/abstract_renderer_owl.js index 6d5dfa56f80..1fc1e1bdea8 100644 --- a/addons/web/static/src/legacy/js/views/abstract_renderer_owl.js +++ b/addons/web/static/src/legacy/js/views/abstract_renderer_owl.js @@ -1,7 +1,7 @@ /** @odoo-module alias=web.AbstractRendererOwl **/ import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onMounted, onPatched } = owl; +const { onMounted, onPatched } = owl; // Renderers may display sample data when there is no real data to display. In // this case the data is displayed with opacity and can't be clicked. Moreover, diff --git a/addons/web/static/src/legacy/js/views/basic/basic_model.js b/addons/web/static/src/legacy/js/views/basic/basic_model.js index 0093e3d41d4..063a0bcd727 100644 --- a/addons/web/static/src/legacy/js/views/basic/basic_model.js +++ b/addons/web/static/src/legacy/js/views/basic/basic_model.js @@ -5246,7 +5246,7 @@ var BasicModel = AbstractModel.extend({ * representing the same res_id record */ _updateDuplicateRecords(recordID, updateFn) { - const { model, res_id } = this.localData[recordID]; + const { res_id } = this.localData[recordID]; // Get the topmost groupedby m2m list const getTopmostID = () => { let element = this.localData[recordID]; diff --git a/addons/web/static/src/legacy/js/views/calendar/calendar_model.js b/addons/web/static/src/legacy/js/views/calendar/calendar_model.js index f1a37543c1a..8078f2c275b 100644 --- a/addons/web/static/src/legacy/js/views/calendar/calendar_model.js +++ b/addons/web/static/src/legacy/js/views/calendar/calendar_model.js @@ -316,7 +316,6 @@ return AbstractModel.extend({ this.data.end_date = this.data.start_date.clone().add(5, 'week').day(this.week_stop).endOf('day'); break; case 'week': - var weekStart = this.data.start_date.clone().startOf('week'); var weekStartDay = this.week_start; if (this.data.start_date.day() < this.week_start) { // The week's first day is after our current day diff --git a/addons/web/static/src/legacy/js/views/calendar/calendar_renderer.js b/addons/web/static/src/legacy/js/views/calendar/calendar_renderer.js index 1f0208c79dc..2038f674d46 100644 --- a/addons/web/static/src/legacy/js/views/calendar/calendar_renderer.js +++ b/addons/web/static/src/legacy/js/views/calendar/calendar_renderer.js @@ -5,7 +5,6 @@ odoo.define('web.CalendarRenderer', function (require) { var AbstractRenderer = require('web.AbstractRenderer'); var CalendarPopover = require('web.CalendarPopover'); var core = require('web.core'); -var Dialog = require('web.Dialog'); var field_utils = require('web.field_utils'); var FieldManagerMixin = require('web.FieldManagerMixin'); var relational_fields = require('web.relational_fields'); @@ -169,7 +168,6 @@ var SidebarFilter = Widget.extend(FieldManagerMixin, { */ _onFilterCheckAll: function (e) { let $input = $(e.currentTarget); - let $filter = $(e.currentTarget).closest('.o_calendar_filter_item'); this.filter_check_all[this.fieldName] = $input.prop('checked'); this.trigger_up('changeFilter', { 'fieldName': this.fieldName, diff --git a/addons/web/static/src/legacy/js/views/form/form_renderer.js b/addons/web/static/src/legacy/js/views/form/form_renderer.js index 3a006c075aa..3d7e3bbd8c0 100644 --- a/addons/web/static/src/legacy/js/views/form/form_renderer.js +++ b/addons/web/static/src/legacy/js/views/form/form_renderer.js @@ -213,7 +213,6 @@ var FormRenderer = BasicRenderer.extend({ * */ enableButtons: function () { - const allButtons = this.$el[0].querySelectorAll('.o_statusbar_buttons button, .oe_button_box button'); this.manuallyDisabledButtons.forEach((button) => { button.removeAttribute("disabled"); }); diff --git a/addons/web/static/src/legacy/js/views/kanban/kanban_column.js b/addons/web/static/src/legacy/js/views/kanban/kanban_column.js index cd4cdc64c55..ad7afde7d21 100644 --- a/addons/web/static/src/legacy/js/views/kanban/kanban_column.js +++ b/addons/web/static/src/legacy/js/views/kanban/kanban_column.js @@ -1,7 +1,6 @@ odoo.define('web.KanbanColumn', function (require) { "use strict"; -var config = require('web.config'); var core = require('web.core'); var session = require('web.session'); var Dialog = require('web.Dialog'); diff --git a/addons/web/static/src/legacy/js/views/kanban/kanban_controller.js b/addons/web/static/src/legacy/js/views/kanban/kanban_controller.js index 4c28ba17aa0..5ff92948aff 100644 --- a/addons/web/static/src/legacy/js/views/kanban/kanban_controller.js +++ b/addons/web/static/src/legacy/js/views/kanban/kanban_controller.js @@ -212,7 +212,6 @@ var KanbanController = BasicController.extend({ * @returns {Promise} */ _resequenceRecords: function (column_id, ids) { - var self = this; return this.model.resequence(this.modelName, ids, column_id); }, /** @@ -464,7 +463,6 @@ var KanbanController = BasicController.extend({ * @param {OdooEvent} ev */ _onResequenceColumn: function (ev) { - var self = this; this._resequenceColumns(ev.data.ids); }, /** diff --git a/addons/web/static/src/legacy/js/views/kanban/kanban_model.js b/addons/web/static/src/legacy/js/views/kanban/kanban_model.js index 72f93e1d5b2..34e745d07c9 100644 --- a/addons/web/static/src/legacy/js/views/kanban/kanban_model.js +++ b/addons/web/static/src/legacy/js/views/kanban/kanban_model.js @@ -402,7 +402,7 @@ var KanbanModel = BasicModel.extend({ async _readProgressBarGroup(list, options) { const groupsDef = this._readGroup(list, options); const progressBarDef = this._readProgressBar(list); - const [groups, progressBar] = await Promise.all([groupsDef, progressBarDef]); + const [ /* groups */ , progressBar] = await Promise.all([groupsDef, progressBarDef]); // For each empty group having an active filter, we clear their filter and refetch. // For instance, this could arrive when we drag out all records of a column diff --git a/addons/web/static/src/legacy/js/views/pivot/pivot_renderer.js b/addons/web/static/src/legacy/js/views/pivot/pivot_renderer.js index b7380bc06f9..2c398c596c0 100644 --- a/addons/web/static/src/legacy/js/views/pivot/pivot_renderer.js +++ b/addons/web/static/src/legacy/js/views/pivot/pivot_renderer.js @@ -8,7 +8,7 @@ import { CustomGroupByItem } from "@web/search/group_by_menu/custom_group_by_item"; import { LegacyComponent } from "@web/legacy/legacy_component"; - const { Component, useEffect, useExternalListener, useState } = owl; + const { useEffect, useExternalListener, useState } = owl; export class PivotGroupByMenu extends LegacyComponent { @@ -30,7 +30,7 @@ if (this.props.hasSearchArchGroupBys) { items = this.props.searchModel.get('filters', f => f.type === 'groupBy'); let groupNumber = 1 + Math.max(...items.map(g => g.groupNumber), 0); - for (const [_, customGroupBy] of this.props.customGroupBys) { + for (const [ , customGroupBy] of this.props.customGroupBys) { customGroupBy.groupNumber = groupNumber++; items.push(customGroupBy); } diff --git a/addons/web/static/src/legacy/js/views/search_panel.js b/addons/web/static/src/legacy/js/views/search_panel.js index 87c3d45ab05..556287ffe22 100644 --- a/addons/web/static/src/legacy/js/views/search_panel.js +++ b/addons/web/static/src/legacy/js/views/search_panel.js @@ -3,7 +3,7 @@ import { Model, useModel } from "web.Model"; import { LegacyComponent } from "@web/legacy/legacy_component"; - const { Component, onMounted, onWillStart, onWillUpdateProps, useRef, useState, useSubEnv } = owl; + const { onMounted, onWillStart, onWillUpdateProps, useRef, useState, useSubEnv } = owl; /** * Search panel diff --git a/addons/web/static/src/legacy/js/views/search_panel_model_extension.js b/addons/web/static/src/legacy/js/views/search_panel_model_extension.js index 1eaf062f324..6db2d562723 100644 --- a/addons/web/static/src/legacy/js/views/search_panel_model_extension.js +++ b/addons/web/static/src/legacy/js/views/search_panel_model_extension.js @@ -130,11 +130,11 @@ exportState() { const state = Object.assign({}, super.exportState()); state.sections = serialiseMap(state.sections); - for (const [id, section] of state.sections) { + for (const [/* id */ , section] of state.sections) { section.values = serialiseMap(section.values); if (section.groups) { section.groups = serialiseMap(section.groups); - for (const [id, group] of section.groups) { + for (const [/* id */ , group] of section.groups) { group.values = serialiseMap(group.values); } } diff --git a/addons/web/static/src/legacy/js/widgets/change_password.js b/addons/web/static/src/legacy/js/widgets/change_password.js index 567da0806b7..10098e357a9 100644 --- a/addons/web/static/src/legacy/js/widgets/change_password.js +++ b/addons/web/static/src/legacy/js/widgets/change_password.js @@ -8,7 +8,6 @@ odoo.define('web.ChangePassword', function (require) { var AbstractAction = require('web.AbstractAction'); var core = require('web.core'); -var Dialog = require('web.Dialog'); var web_client = require('web.web_client'); var _t = core._t; diff --git a/addons/web/static/src/legacy/js/widgets/week_days.js b/addons/web/static/src/legacy/js/widgets/week_days.js index f8975f0dc8f..1f7bbc434dd 100644 --- a/addons/web/static/src/legacy/js/widgets/week_days.js +++ b/addons/web/static/src/legacy/js/widgets/week_days.js @@ -6,7 +6,7 @@ odoo.define('web.WeekDays', function (require) { const utils = require('web.utils'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, onWillUpdateProps, useState } = owl; + const { onWillUpdateProps, useState } = owl; class WeekDays extends LegacyComponent { setup() { diff --git a/addons/web/static/src/legacy/legacy_client_actions.js b/addons/web/static/src/legacy/legacy_client_actions.js index bae9a63b84f..b32d55fa728 100644 --- a/addons/web/static/src/legacy/legacy_client_actions.js +++ b/addons/web/static/src/legacy/legacy_client_actions.js @@ -10,7 +10,7 @@ import { breadcrumbsToLegacy } from "./backend_utils"; import { useLegacyRefs } from "./utils"; import { LegacyComponent } from "./legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const actionRegistry = registry.category("actions"); const legacyClientActionTemplate = xml` diff --git a/addons/web/static/src/legacy/legacy_views.js b/addons/web/static/src/legacy/legacy_views.js index d8c14a8f1f3..e2f0e4d5994 100644 --- a/addons/web/static/src/legacy/legacy_views.js +++ b/addons/web/static/src/legacy/legacy_views.js @@ -16,7 +16,7 @@ import { registry } from "@web/core/registry"; import { loadPublicAsset } from "@web/core/assets"; import { LegacyComponent } from "./legacy_component"; -const { Component, xml, onWillStart } = owl; +const { xml, onWillStart } = owl; const viewRegistry = registry.category("views"); function getJsClassWidget(fieldsInfo) { diff --git a/addons/web/static/src/search/group_by_menu/custom_group_by_item.js b/addons/web/static/src/search/group_by_menu/custom_group_by_item.js index 91466170497..f4ba79f88c8 100644 --- a/addons/web/static/src/search/group_by_menu/custom_group_by_item.js +++ b/addons/web/static/src/search/group_by_menu/custom_group_by_item.js @@ -3,7 +3,7 @@ import { Dropdown } from "@web/core/dropdown/dropdown"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useState } = owl; +const { useState } = owl; export class CustomGroupByItem extends LegacyComponent { setup() { diff --git a/addons/web/static/src/search/search_bar/search_bar.js b/addons/web/static/src/search/search_bar/search_bar.js index 32e18c9140e..66c52344c45 100644 --- a/addons/web/static/src/search/search_bar/search_bar.js +++ b/addons/web/static/src/search/search_bar/search_bar.js @@ -8,7 +8,7 @@ import { useAutofocus, useBus, useService } from "@web/core/utils/hooks"; import { fuzzyTest } from "@web/core/utils/search"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useExternalListener, useState } = owl; +const { useExternalListener, useState } = owl; const parsers = registry.category("parsers"); const CHAR_FIELDS = ["char", "html", "many2many", "many2one", "one2many", "text"]; diff --git a/addons/web/static/src/search/search_panel/search_panel.js b/addons/web/static/src/search/search_panel/search_panel.js index b0198f22282..aa9e3e9638e 100644 --- a/addons/web/static/src/search/search_panel/search_panel.js +++ b/addons/web/static/src/search/search_panel/search_panel.js @@ -2,7 +2,7 @@ import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onMounted, onWillStart, onWillUpdateProps, useState } = owl; +const { onMounted, onWillStart, onWillUpdateProps, useState } = owl; /** * Search panel diff --git a/addons/web/static/src/search/with_search/with_search.js b/addons/web/static/src/search/with_search/with_search.js index 69dfdeb6649..0d6f4dc7e39 100644 --- a/addons/web/static/src/search/with_search/with_search.js +++ b/addons/web/static/src/search/with_search/with_search.js @@ -5,7 +5,7 @@ import { SearchModel } from "@web/search/search_model"; import { CallbackRecorder, useSetupAction } from "@web/webclient/actions/action_hook"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillStart, onWillUpdateProps, toRaw, useSubEnv } = owl; +const { onWillStart, onWillUpdateProps, toRaw, useSubEnv } = owl; export const SEARCH_KEYS = ["comparison", "context", "domain", "groupBy", "orderBy"]; const OTHER_SEARCH_KEYS = ["irFilters", "searchViewArch", "searchViewFields", "searchViewId"]; diff --git a/addons/web/static/src/views/graph/graph_renderer.js b/addons/web/static/src/views/graph/graph_renderer.js index d5df2eac113..511e6a1397b 100644 --- a/addons/web/static/src/views/graph/graph_renderer.js +++ b/addons/web/static/src/views/graph/graph_renderer.js @@ -9,7 +9,7 @@ import { useAssets } from "@web/core/assets"; import { renderToString } from "@web/core/utils/render"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillUnmount, useEffect, useRef } = owl; +const { onWillUnmount, useEffect, useRef } = owl; const NO_DATA = _lt("No data"); diff --git a/addons/web/static/src/views/graph/graph_view.js b/addons/web/static/src/views/graph/graph_view.js index 8f15cb5bb9e..7bca90d6e7e 100644 --- a/addons/web/static/src/views/graph/graph_view.js +++ b/addons/web/static/src/views/graph/graph_view.js @@ -15,7 +15,6 @@ import { GraphModel } from "./graph_model"; import { GraphRenderer } from "./graph_renderer"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; const viewRegistry = registry.category("views"); export class GraphView extends LegacyComponent { diff --git a/addons/web/static/src/views/layout.js b/addons/web/static/src/views/layout.js index ded0d8e2882..896d1ef9468 100644 --- a/addons/web/static/src/views/layout.js +++ b/addons/web/static/src/views/layout.js @@ -4,8 +4,6 @@ import { ControlPanel } from "@web/search/control_panel/control_panel"; import { SearchPanel } from "@web/search/search_panel/search_panel"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; - /** * @param {Object} params * @returns {Object} diff --git a/addons/web/static/src/views/onboarding_banner.js b/addons/web/static/src/views/onboarding_banner.js index 3705e63f3b4..68ab9c2cc9a 100644 --- a/addons/web/static/src/views/onboarding_banner.js +++ b/addons/web/static/src/views/onboarding_banner.js @@ -5,7 +5,7 @@ import { useService } from "@web/core/utils/hooks"; import { useActionLinks } from "@web/views/helpers/view_hook"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, markup, onWillStart, xml } = owl; +const { markup, onWillStart, xml } = owl; export class OnboardingBanner extends LegacyComponent { setup() { diff --git a/addons/web/static/src/views/pivot/pivot_renderer.js b/addons/web/static/src/views/pivot/pivot_renderer.js index a9f34646c93..5345faf8023 100644 --- a/addons/web/static/src/views/pivot/pivot_renderer.js +++ b/addons/web/static/src/views/pivot/pivot_renderer.js @@ -7,7 +7,7 @@ import { PivotGroupByMenu } from "@web/views/pivot/pivot_group_by_menu"; import fieldUtils from "web.field_utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillUpdateProps } = owl; +const { onWillUpdateProps } = owl; const formatterRegistry = registry.category("formatters"); export class PivotRenderer extends LegacyComponent { diff --git a/addons/web/static/src/views/pivot/pivot_view.js b/addons/web/static/src/views/pivot/pivot_view.js index 80666597b1a..b56fd1a8906 100644 --- a/addons/web/static/src/views/pivot/pivot_view.js +++ b/addons/web/static/src/views/pivot/pivot_view.js @@ -15,7 +15,6 @@ import { PivotModel } from "@web/views/pivot/pivot_model"; import { PivotRenderer } from "@web/views/pivot/pivot_renderer"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component } = owl; const viewRegistry = registry.category("views"); export class PivotView extends LegacyComponent { diff --git a/addons/web/static/src/views/view.js b/addons/web/static/src/views/view.js index 9d5c4b2fd06..43c5b22e1ff 100644 --- a/addons/web/static/src/views/view.js +++ b/addons/web/static/src/views/view.js @@ -10,7 +10,7 @@ import { useActionLinks } from "@web/views/helpers/view_hook"; import { extractLayoutComponents } from "@web/views/layout"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillUpdateProps, onWillStart, toRaw, useSubEnv } = owl; +const { onWillUpdateProps, onWillStart, toRaw, useSubEnv } = owl; const viewRegistry = registry.category("views"); /** @typedef {Object} Config diff --git a/addons/web/static/src/views/view_service.js b/addons/web/static/src/views/view_service.js index 474f645f38a..cf8a0668551 100644 --- a/addons/web/static/src/views/view_service.js +++ b/addons/web/static/src/views/view_service.js @@ -79,7 +79,7 @@ export const viewService = { const viewDescriptions = { __legacy__: result, }; // for legacy purpose, keys in result are left in viewDescriptions - for (const [_, viewType] of params.views) { + for (const [, viewType] of params.views) { const viewDescription = JSON.parse( JSON.stringify(result.fields_views[viewType]) ); diff --git a/addons/web/static/src/webclient/navbar/navbar.js b/addons/web/static/src/webclient/navbar/navbar.js index 05a4d13333f..153c9fa6bf5 100644 --- a/addons/web/static/src/webclient/navbar/navbar.js +++ b/addons/web/static/src/webclient/navbar/navbar.js @@ -8,7 +8,7 @@ import { debounce } from "@web/core/utils/timing"; import { ErrorHandler } from "@web/core/utils/components"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onWillDestroy, useExternalListener, useEffect, useRef } = owl; +const { onWillDestroy, useExternalListener, useEffect, useRef } = owl; const systrayRegistry = registry.category("systray"); const getBoundingClientRect = Element.prototype.getBoundingClientRect; diff --git a/addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js b/addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js index 7412921dfe8..97de1310987 100644 --- a/addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js +++ b/addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js @@ -8,7 +8,7 @@ import { browser } from "@web/core/browser/browser"; import { symmetricalDifference } from "@web/core/utils/arrays"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useState } = owl; +const { useState } = owl; export class SwitchCompanyMenu extends LegacyComponent { setup() { diff --git a/addons/web/static/tests/core/commands/command_palette_tests.js b/addons/web/static/tests/core/commands/command_palette_tests.js index 66fdac4e70e..c610577978a 100644 --- a/addons/web/static/tests/core/commands/command_palette_tests.js +++ b/addons/web/static/tests/core/commands/command_palette_tests.js @@ -23,7 +23,6 @@ const { Component, xml } = owl; let env; let target; -let testComponent; const serviceRegistry = registry.category("services"); class FooterComponent extends Component {} @@ -61,7 +60,7 @@ QUnit.module("Command Palette Dialog", { }); QUnit.test("empty providers", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const config = { providers: [], }; @@ -84,7 +83,7 @@ QUnit.test("empty providers", async (assert) => { }); QUnit.test("custom empty message", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const configByNamespace = { default: { emptyMessage: "Empty Default", @@ -141,7 +140,7 @@ QUnit.test("custom debounce delay", async (assert) => { }, }); - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const configByNamespace = { "@": { debounceDelay: 200, @@ -183,7 +182,7 @@ QUnit.test("custom debounce delay", async (assert) => { }); QUnit.test("custom placeholder", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const config = { placeholder: "placeholder test", providers: [], @@ -202,7 +201,7 @@ QUnit.test("custom placeholder", async (assert) => { }); QUnit.test("add a footer", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const config = { providers: [], FooterComponent, @@ -225,7 +224,7 @@ QUnit.test("command with a Custom Component", async (assert) => { `; - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -266,7 +265,7 @@ QUnit.test("command with a Custom Component", async (assert) => { }); QUnit.test("multi namespace with provider", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -318,7 +317,7 @@ QUnit.test("multi namespace with provider", async (assert) => { }); QUnit.test("apply a fuzzysearch on the namespace default not on the others", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -382,7 +381,7 @@ QUnit.test("apply a fuzzysearch on the namespace default not on the others", asy }); QUnit.test("multi provider with the same namespace", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -426,7 +425,7 @@ QUnit.test("multi provider with the same namespace", async (assert) => { }); QUnit.test("check the concurrency during a research", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const imSearchDef = makeDeferred(); const provide = async (env, options) => { if (options.searchValue) { @@ -471,7 +470,7 @@ QUnit.test("check the concurrency during a research", async (assert) => { QUnit.test( "open the command palette with a searchValue already in the searchbar", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -519,7 +518,7 @@ QUnit.test( ); QUnit.test("open the command palette with a namespace already in the searchbar", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -566,7 +565,7 @@ QUnit.test("open the command palette with a namespace already in the searchbar", }); QUnit.test("multi provider with categories", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -695,7 +694,7 @@ QUnit.test("multi provider with categories", async (assert) => { }); QUnit.test("don't display by categories if there is a search value", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -757,7 +756,7 @@ QUnit.test("don't display by categories if there is a search value", async (asse }); QUnit.test("click on command", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const commands = [ { name: "Command1", @@ -798,7 +797,7 @@ QUnit.test("click on command", async (assert) => { }); QUnit.test("press enter on command", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const commands = [ { name: "Command1", @@ -842,7 +841,7 @@ QUnit.test("press enter on command", async (assert) => { }); QUnit.test("keyboard navigation scroll", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const commands = [ { name: "Command1" }, { name: "Command2" }, @@ -1000,7 +999,7 @@ QUnit.test("keyboard navigation scroll", async (assert) => { }); QUnit.test("multi level command", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const configByNamespace = { default: { emptyMessage: "Empty Default", @@ -1074,7 +1073,7 @@ QUnit.test("multi level command", async (assert) => { }); QUnit.test("command palette dialog can be rendered and closed on outside click", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const config = { providers: [], @@ -1094,7 +1093,7 @@ QUnit.test("command palette dialog can be rendered and closed on outside click", QUnit.test("navigate in the command palette with the arrows", async (assert) => { assert.expect(6); - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const commands = [ { @@ -1155,7 +1154,7 @@ QUnit.test("navigate in the command palette with the arrows", async (assert) => QUnit.test("navigate in the command palette with an empty list", async (assert) => { assert.expect(6); - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const providers = [ { provide: () => [], @@ -1183,7 +1182,7 @@ QUnit.test("navigate in the command palette with an empty list", async (assert) }); QUnit.test("bold the searchValue on the commands", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { @@ -1238,7 +1237,7 @@ QUnit.test("bold the searchValue on the commands", async (assert) => { }); QUnit.test("bold the searchValue on the commands with special char", async (assert) => { - testComponent = await mount(TestComponent, target, { env }); + await mount(TestComponent, target, { env }); const action = () => {}; const providers = [ { diff --git a/addons/web/static/tests/core/commands/command_service_tests.js b/addons/web/static/tests/core/commands/command_service_tests.js index cfc21bed0c0..20d11960235 100644 --- a/addons/web/static/tests/core/commands/command_service_tests.js +++ b/addons/web/static/tests/core/commands/command_service_tests.js @@ -22,7 +22,7 @@ import { } from "../../helpers/utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let env; let target; diff --git a/addons/web/static/tests/core/datepicker_tests.js b/addons/web/static/tests/core/datepicker_tests.js index 264c5cccb96..986f081cfe2 100644 --- a/addons/web/static/tests/core/datepicker_tests.js +++ b/addons/web/static/tests/core/datepicker_tests.js @@ -10,7 +10,7 @@ import { createComponent } from "web.test_utils"; import { registerCleanup } from "../helpers/cleanup"; import { makeTestEnv } from "../helpers/mock_env"; import { makeFakeLocalizationService } from "../helpers/mock_services"; -import { click, destroy, getFixture, mount, triggerEvent } from "../helpers/utils"; +import { click, getFixture, mount, triggerEvent } from "../helpers/utils"; import { applyFilter, toggleMenu } from "@web/../tests/search/helpers"; const { Component, xml } = owl; diff --git a/addons/web/static/tests/core/dialog_tests.js b/addons/web/static/tests/core/dialog_tests.js index b52af729507..ffe4f530fc8 100644 --- a/addons/web/static/tests/core/dialog_tests.js +++ b/addons/web/static/tests/core/dialog_tests.js @@ -10,7 +10,7 @@ import { click, destroy, getFixture, mount } from "../helpers/utils"; import { makeFakeDialogService } from "../helpers/mock_services"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, useEffect, useState, xml } = owl; +const { useEffect, useState, xml } = owl; const serviceRegistry = registry.category("services"); let parent; let target; diff --git a/addons/web/static/tests/core/effects/effect_service_tests.js b/addons/web/static/tests/core/effects/effect_service_tests.js index c0d6fd78762..62adf57608a 100644 --- a/addons/web/static/tests/core/effects/effect_service_tests.js +++ b/addons/web/static/tests/core/effects/effect_service_tests.js @@ -17,7 +17,7 @@ import { } from "../../helpers/utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, markup, xml } = owl; +const { markup, xml } = owl; const serviceRegistry = registry.category("services"); const mainComponentRegistry = registry.category("main_components"); diff --git a/addons/web/static/tests/core/errors/error_service_tests.js b/addons/web/static/tests/core/errors/error_service_tests.js index 0df7447c924..847e9c39796 100644 --- a/addons/web/static/tests/core/errors/error_service_tests.js +++ b/addons/web/static/tests/core/errors/error_service_tests.js @@ -22,7 +22,7 @@ import { import { makeDeferred, nextTick, patchWithCleanup } from "../../helpers/utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const errorDialogRegistry = registry.category("error_dialogs"); const errorHandlerRegistry = registry.category("error_handlers"); const serviceRegistry = registry.category("services"); diff --git a/addons/web/static/tests/core/l10n/translation_tests.js b/addons/web/static/tests/core/l10n/translation_tests.js index d314b115451..f3386520d3c 100644 --- a/addons/web/static/tests/core/l10n/translation_tests.js +++ b/addons/web/static/tests/core/l10n/translation_tests.js @@ -12,7 +12,7 @@ import { patch, unpatch } from "@web/core/utils/patch"; import { session } from "@web/session"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const { DateTime, Settings } = luxon; const terms = { Hello: "Bonjour" }; diff --git a/addons/web/static/tests/core/network/rpc_service_tests.js b/addons/web/static/tests/core/network/rpc_service_tests.js index 640910c1ad7..4ecc5f8ef1c 100644 --- a/addons/web/static/tests/core/network/rpc_service_tests.js +++ b/addons/web/static/tests/core/network/rpc_service_tests.js @@ -19,7 +19,7 @@ import { import { registerCleanup } from "../../helpers/cleanup"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let isXHRMocked = false; const serviceRegistry = registry.category("services"); diff --git a/addons/web/static/tests/core/orm_service_tests.js b/addons/web/static/tests/core/orm_service_tests.js index 88b0184b638..04742690c64 100644 --- a/addons/web/static/tests/core/orm_service_tests.js +++ b/addons/web/static/tests/core/orm_service_tests.js @@ -259,7 +259,7 @@ QUnit.test("webSearchRead method", async (assert) => { }); QUnit.test("useModel is specialized for component", async (assert) => { - const [query, rpc] = makeFakeRPC(); + const [, /* query */ rpc] = makeFakeRPC(); serviceRegistry.add("rpc", rpc); const env = await makeTestEnv(); @@ -306,7 +306,7 @@ QUnit.test("silent mode", async (assert) => { QUnit.test("validate some obviously wrong calls", async (assert) => { assert.expect(2); - const [query, rpc] = makeFakeRPC(); + const [, /* query*/ rpc] = makeFakeRPC(); serviceRegistry.add("rpc", rpc); const env = await makeTestEnv(); try { diff --git a/addons/web/static/tests/core/ui_service_tests.js b/addons/web/static/tests/core/ui_service_tests.js index 65636a3c459..a528702c9f8 100644 --- a/addons/web/static/tests/core/ui_service_tests.js +++ b/addons/web/static/tests/core/ui_service_tests.js @@ -4,8 +4,7 @@ import { registry } from "@web/core/registry"; import { uiService, useActiveElement } from "@web/core/ui/ui_service"; import { makeTestEnv } from "../helpers/mock_env"; import { makeFakeLocalizationService } from "../helpers/mock_services"; -import { destroy, getFixture, mount, nextTick } from "../helpers/utils"; -import { LegacyComponent } from "@web/legacy/legacy_component"; +import { getFixture, mount, nextTick } from "../helpers/utils"; const { Component, xml } = owl; const serviceRegistry = registry.category("services"); diff --git a/addons/web/static/tests/legacy/component_extension_tests.js b/addons/web/static/tests/legacy/component_extension_tests.js index 4f99af33966..0fdf1587298 100644 --- a/addons/web/static/tests/legacy/component_extension_tests.js +++ b/addons/web/static/tests/legacy/component_extension_tests.js @@ -6,7 +6,7 @@ odoo.define('web.component_extension_tests', function (require) { const { destroy, getFixture, mount } = require("@web/../tests/helpers/utils"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, xml } = owl; + const { xml } = owl; const { useListener } = require("@web/core/utils/hooks"); let target; diff --git a/addons/web/static/tests/legacy/components/dropdown_menu_tests.js b/addons/web/static/tests/legacy/components/dropdown_menu_tests.js index b19e13a85b6..951701ead0e 100644 --- a/addons/web/static/tests/legacy/components/dropdown_menu_tests.js +++ b/addons/web/static/tests/legacy/components/dropdown_menu_tests.js @@ -7,7 +7,7 @@ odoo.define('web.dropdown_menu_tests', function (require) { const { mount } = require("@web/../tests/helpers/utils"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState, xml } = owl; + const { useState, xml } = owl; const { createComponent } = testUtils; QUnit.module('Components', { diff --git a/addons/web/static/tests/legacy/components/pager_tests.js b/addons/web/static/tests/legacy/components/pager_tests.js index afceb73e4cf..6d852e21a80 100644 --- a/addons/web/static/tests/legacy/components/pager_tests.js +++ b/addons/web/static/tests/legacy/components/pager_tests.js @@ -7,7 +7,7 @@ odoo.define('web.pager_tests', function (require) { const { createComponent } = testUtils; - const { Component, xml, useState } = owl; + const { xml, useState } = owl; class PagerController extends LegacyComponent { setup() { diff --git a/addons/web/static/tests/legacy/core/owl_dialog_tests.js b/addons/web/static/tests/legacy/core/owl_dialog_tests.js index 28a2c2a424d..22bf8197d62 100644 --- a/addons/web/static/tests/legacy/core/owl_dialog_tests.js +++ b/addons/web/static/tests/legacy/core/owl_dialog_tests.js @@ -17,7 +17,7 @@ odoo.define('web.owl_dialog_tests', function (require) { const { createWebClient, doAction } = require("@web/../tests/webclient/helpers"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState, xml } = owl; + const { useState, xml } = owl; const EscapeKey = { key: 'Escape', keyCode: 27, which: 27 }; QUnit.module('core', {}, function () { diff --git a/addons/web/static/tests/legacy/core/popover_tests.js b/addons/web/static/tests/legacy/core/popover_tests.js index 8b2137e2991..8cc68369908 100644 --- a/addons/web/static/tests/legacy/core/popover_tests.js +++ b/addons/web/static/tests/legacy/core/popover_tests.js @@ -7,7 +7,7 @@ odoo.define('web.popover_tests', function (require) { const { click, mount } = require("@web/../tests/helpers/utils"); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, useState, xml } = owl; + const { useState, xml } = owl; QUnit.module('core', {}, function () { QUnit.module('Popover'); diff --git a/addons/web/static/tests/legacy/core/widget_tests.js b/addons/web/static/tests/legacy/core/widget_tests.js index dc704abe274..ed8fac6c789 100644 --- a/addons/web/static/tests/legacy/core/widget_tests.js +++ b/addons/web/static/tests/legacy/core/widget_tests.js @@ -497,7 +497,7 @@ QUnit.module('core', {}, function () { assert.expect(2); var parent = new Widget(); - var child = new (Widget.extend({ + new (Widget.extend({ destroy: function () { assert.step('destroy'); } diff --git a/addons/web/static/tests/legacy/fields/basic_fields_tests.js b/addons/web/static/tests/legacy/fields/basic_fields_tests.js index 245d74a1c17..00b154a4191 100644 --- a/addons/web/static/tests/legacy/fields/basic_fields_tests.js +++ b/addons/web/static/tests/legacy/fields/basic_fields_tests.js @@ -6,7 +6,6 @@ var basicFields = require('web.basic_fields'); var concurrency = require('web.concurrency'); var config = require('web.config'); var core = require('web.core'); -var FormController = require('web.FormController'); var FormView = require('web.FormView'); var KanbanView = require('web.KanbanView'); var ListView = require('web.ListView'); @@ -17,7 +16,7 @@ var field_registry = require('web.field_registry'); const makeTestEnvironment = require("web.test_env"); const { makeLegacyCommandService } = require("@web/legacy/utils"); const { registry } = require("@web/core/registry"); -const { getFixture, legacyExtraNextTick, patchWithCleanup, triggerHotkey, nextTick, click } = require("@web/../tests/helpers/utils"); +const { getFixture, legacyExtraNextTick, triggerHotkey, nextTick, click } = require("@web/../tests/helpers/utils"); const { createWebClient, doAction } = require('@web/../tests/webclient/helpers'); var createView = testUtils.createView; @@ -6345,7 +6344,6 @@ QUnit.module('basic_fields', { QUnit.test('phone field in editable list view on normal screens', async function (assert) { assert.expect(8); - var doActionCount = 0; var list = await createView({ View: ListView, diff --git a/addons/web/static/tests/legacy/fields/relational_fields/field_one2many_tests.js b/addons/web/static/tests/legacy/fields/relational_fields/field_one2many_tests.js index fca2bbd3975..aada8b45683 100644 --- a/addons/web/static/tests/legacy/fields/relational_fields/field_one2many_tests.js +++ b/addons/web/static/tests/legacy/fields/relational_fields/field_one2many_tests.js @@ -18,7 +18,6 @@ const { patch, unpatch } = require('web.utils'); const { makeLegacyDialogMappingTestEnv } = require('@web/../tests/helpers/legacy_env_utils'); -const cpHelpers = require('@web/../tests/search/helpers'); var createView = testUtils.createView; const { FieldOne2Many } = relationalFields; const AbstractFieldOwl = require('web.AbstractFieldOwl'); diff --git a/addons/web/static/tests/legacy/fields/relational_fields_tests.js b/addons/web/static/tests/legacy/fields/relational_fields_tests.js index fd00a37aee2..23558857b3b 100644 --- a/addons/web/static/tests/legacy/fields/relational_fields_tests.js +++ b/addons/web/static/tests/legacy/fields/relational_fields_tests.js @@ -2,7 +2,6 @@ odoo.define('web.relational_fields_tests', function (require) { "use strict"; var AbstractStorageService = require('web.AbstractStorageService'); -var FormController = require('web.FormController'); var FormView = require('web.FormView'); const KanbanView = require('web.KanbanView'); var ListView = require('web.ListView'); diff --git a/addons/web/static/tests/legacy/owl_compatibility_tests.js b/addons/web/static/tests/legacy/owl_compatibility_tests.js index 431997dad3f..ca45449b7e0 100644 --- a/addons/web/static/tests/legacy/owl_compatibility_tests.js +++ b/addons/web/static/tests/legacy/owl_compatibility_tests.js @@ -21,7 +21,6 @@ odoo.define('web.OwlCompatibilityTests', function (require) { const { mount, useLogLifeCycle, destroy } = require("@web/../tests/helpers/utils"); const { - Component, onError, onMounted, onWillDestroy, @@ -32,9 +31,6 @@ odoo.define('web.OwlCompatibilityTests', function (require) { xml, } = owl; - // from Owl internal status enum - const ISMOUNTED = 3; - const WidgetAdapter = Widget.extend(WidgetAdapterMixin, { destroy() { this._super(...arguments); @@ -420,7 +416,7 @@ odoo.define('web.OwlCompatibilityTests', function (require) { Parent.components = { ComponentAdapter }; const target = testUtils.prepareTarget(); - const parent = await mount(Parent, target); + await mount(Parent, target); widget.trigger_up('some-event', { value: 'a' }); widget.trigger_up('some_event', { value: 'b' }); // _ are converted to - @@ -500,7 +496,7 @@ odoo.define('web.OwlCompatibilityTests', function (require) { }; const target = testUtils.prepareTarget(); - const parent = await mount(Parent, target, { env }); + await mount(Parent, target, { env }); }); QUnit.test("sub widget that requests the session", async function (assert) { diff --git a/addons/web/static/tests/legacy/views/abstract_controller_tests.js b/addons/web/static/tests/legacy/views/abstract_controller_tests.js index a75b03f3c52..d695b32e3c0 100644 --- a/addons/web/static/tests/legacy/views/abstract_controller_tests.js +++ b/addons/web/static/tests/legacy/views/abstract_controller_tests.js @@ -8,7 +8,6 @@ var BasicView = require("web.BasicView"); var BasicRenderer = require("web.BasicRenderer"); const AbstractRenderer = require('web.AbstractRendererOwl'); const RendererWrapper = require('web.RendererWrapper'); -const { nextTick } = require('web.test_utils'); const { xml, onMounted, onWillUnmount, onWillDestroy } = owl; diff --git a/addons/web/static/tests/legacy/views/basic_view_tests.js b/addons/web/static/tests/legacy/views/basic_view_tests.js index f6a60c7ba2b..f8ef97e92e7 100644 --- a/addons/web/static/tests/legacy/views/basic_view_tests.js +++ b/addons/web/static/tests/legacy/views/basic_view_tests.js @@ -7,7 +7,7 @@ odoo.define('web.basic_view_tests', function (require) { const widgetRegistryOwl = require('web.widgetRegistry'); const { LegacyComponent } = require("@web/legacy/legacy_component"); - const { Component, xml } = owl; + const { xml } = owl; const createView = testUtils.createView; diff --git a/addons/web/static/tests/legacy/views/calendar_tests.js b/addons/web/static/tests/legacy/views/calendar_tests.js index 09610bff8bb..75f95d7de7a 100644 --- a/addons/web/static/tests/legacy/views/calendar_tests.js +++ b/addons/web/static/tests/legacy/views/calendar_tests.js @@ -2,7 +2,6 @@ odoo.define('web.calendar_tests', function (require) { "use strict"; const AbstractField = require('web.AbstractField'); -var AbstractStorageService = require('web.AbstractStorageService'); const BasicModel = require('web.BasicModel'); var CalendarView = require('web.CalendarView'); var CalendarRenderer = require('web.CalendarRenderer'); @@ -503,7 +502,6 @@ QUnit.module('Views', { QUnit.test('quickcreate with custom create_name_field', async function (assert) { assert.expect(3); - var event = $.Event(); this.data.custom_event = { fields: { id: {string: "ID", type: "integer"}, @@ -648,7 +646,6 @@ QUnit.module('Views', { }, }); - var event = $.Event(); var calendar = await createCalendarView({ View: CalendarView, model: 'event', diff --git a/addons/web/static/tests/legacy/views/form_tests.js b/addons/web/static/tests/legacy/views/form_tests.js index 8e09ff4632c..61d6eb0696c 100644 --- a/addons/web/static/tests/legacy/views/form_tests.js +++ b/addons/web/static/tests/legacy/views/form_tests.js @@ -32,7 +32,7 @@ const { registry } = require("@web/core/registry"); const { scrollerService } = require("@web/core/scroller_service"); const { LegacyComponent } = require("@web/legacy/legacy_component"); -const { Component, onMounted, onWillUnmount, xml } = owl; +const { onMounted, onWillUnmount, xml } = owl; let serverData; let target; @@ -1338,7 +1338,6 @@ QUnit.module('Views', { res_id: 2, }); - var count = 0; await testUtils.mock.intercept(form, "execute_action", function (event) { if (event.data.action_data.name == "action_to_perform") { assert.containsN(form, 'button.oe_stat_button[disabled]', 2, "While performing the action, both buttons should be disabled."); diff --git a/addons/web/static/tests/legacy/views/kanban_tests.js b/addons/web/static/tests/legacy/views/kanban_tests.js index 91d669a405b..170595ab954 100644 --- a/addons/web/static/tests/legacy/views/kanban_tests.js +++ b/addons/web/static/tests/legacy/views/kanban_tests.js @@ -21,7 +21,7 @@ const cpHelpers = require('@web/../tests/search/helpers'); var createView = testUtils.createView; const { Markup } = require("web.utils"); -const { Component, markup, xml } = owl; +const { markup, xml } = owl; QUnit.module('Views', { before: function () { @@ -245,7 +245,6 @@ QUnit.module('Views', { // add active field on partner model and make all records active this.data.partner.fields.active = {string: 'Active', type: 'char', default: true}; - var envIDs = [1, 2, 3, 4]; // the ids that should be in the environment during this test var kanban = await createView({ View: KanbanView, model: 'partner', @@ -280,7 +279,6 @@ QUnit.module('Views', { // archive the records of the first column assert.containsN(kanban, '.o_kanban_group:last .o_kanban_record', 3, "last column should contain 3 records"); - envIDs = [4]; testUtils.kanban.toggleGroupSettings(kanban.$('.o_kanban_group:last')); await testUtils.dom.click(kanban.$('.o_kanban_group:last .o_column_archive_records')); assert.ok($('.modal').length, 'a confirm modal should be displayed'); @@ -300,7 +298,6 @@ QUnit.module('Views', { // add active field on partner model and make all records active this.data.partner.fields.active = {string: 'Active', type: 'char', default: true}; - var envIDs = [1, 2, 3, 4]; // the ids that should be in the environment during this test var kanban = await createView({ View: KanbanView, model: 'partner', diff --git a/addons/web/static/tests/legacy/views/list_tests.js b/addons/web/static/tests/legacy/views/list_tests.js index 2c924bfef6f..5f0d4b93415 100644 --- a/addons/web/static/tests/legacy/views/list_tests.js +++ b/addons/web/static/tests/legacy/views/list_tests.js @@ -29,7 +29,7 @@ const { getFixture, click, legacyExtraNextTick } = require("@web/../tests/helper const { createWebClient, doAction, loadState } = require('@web/../tests/webclient/helpers'); const { _t } = core; -const { Component, markup, onMounted, onWillUnmount, xml } = owl; +const { markup, onMounted, onWillUnmount, xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/legacy/views/state_mapping_tests.js b/addons/web/static/tests/legacy/views/state_mapping_tests.js index a942dc91902..d6399e705d9 100644 --- a/addons/web/static/tests/legacy/views/state_mapping_tests.js +++ b/addons/web/static/tests/legacy/views/state_mapping_tests.js @@ -26,7 +26,7 @@ import legacyViewRegistry from "web.view_registry"; import { browser } from "@web/core/browser/browser"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const serviceRegistry = registry.category("services"); const viewRegistry = registry.category("views"); diff --git a/addons/web/static/tests/legacy/views/view_dialogs_tests.js b/addons/web/static/tests/legacy/views/view_dialogs_tests.js index ce7da1b86a7..3f28c5b1bd7 100644 --- a/addons/web/static/tests/legacy/views/view_dialogs_tests.js +++ b/addons/web/static/tests/legacy/views/view_dialogs_tests.js @@ -195,7 +195,6 @@ QUnit.module('Views', { }, }); - var dialog; new dialogs.SelectCreateDialog(parent, { no_create: true, readonly: true, @@ -205,9 +204,7 @@ QUnit.module('Views', { search_default_groupby_bar: true, search_default_foo: 'piou', }, - }).open().then(function (result) { - dialog = result; - }); + }).open(); await testUtils.nextTick(); const modal = document.body.querySelector(".modal"); await cpHelpers.removeFacet(modal, "Bar"); diff --git a/addons/web/static/tests/legacy/widgets/week_days_tests.js b/addons/web/static/tests/legacy/widgets/week_days_tests.js index 80430c4e051..1766d176509 100644 --- a/addons/web/static/tests/legacy/widgets/week_days_tests.js +++ b/addons/web/static/tests/legacy/widgets/week_days_tests.js @@ -3,7 +3,6 @@ odoo.define('web.week_days_tests', function (require) { const FormView = require('web.FormView'); const testUtils = require('web.test_utils'); - const { _t } = require('web.core'); QUnit.module('WeeklyRecurrence', { beforeEach() { diff --git a/addons/web/static/tests/search/favorite_menu_tests.js b/addons/web/static/tests/search/favorite_menu_tests.js index b5d482dd0b7..398ca477039 100644 --- a/addons/web/static/tests/search/favorite_menu_tests.js +++ b/addons/web/static/tests/search/favorite_menu_tests.js @@ -18,7 +18,6 @@ import { toggleFavoriteMenu, toggleMenuItem, } from "./helpers"; -import { LegacyComponent } from "@web/legacy/legacy_component"; const { Component, onWillUpdateProps, xml } = owl; const serviceRegistry = registry.category("services"); diff --git a/addons/web/static/tests/setup.js b/addons/web/static/tests/setup.js index 5a5dfb65f67..abae6539f52 100644 --- a/addons/web/static/tests/setup.js +++ b/addons/web/static/tests/setup.js @@ -56,7 +56,7 @@ function checkGlobalObjectsIntegrity() { const finals = objects.map((obj) => stringifyObjectValues(obj[0], obj[1])); for (const index in initials) { if (initials[index] !== finals[index]) { - const [global, keys] = objects[index]; + const [, /* global */ keys] = objects[index]; throw new Error( `The keys "${keys}" of some global objects (usually session or _t) may have been polluted by the test "${infos.testName}" in module "${infos.moduleName}"` ); diff --git a/addons/web/static/tests/views/view_tests.js b/addons/web/static/tests/views/view_tests.js index 54730df0fb8..440db8d071e 100644 --- a/addons/web/static/tests/views/view_tests.js +++ b/addons/web/static/tests/views/view_tests.js @@ -532,7 +532,7 @@ QUnit.module("Views", (hooks) => { }, }); - const view = await makeView({ + await makeView({ serverData, mockRPC: () => { throw new Error("no RPC expected"); diff --git a/addons/web/static/tests/webclient/actions/client_action_tests.js b/addons/web/static/tests/webclient/actions/client_action_tests.js index 9db3142c47f..bc639a01081 100644 --- a/addons/web/static/tests/webclient/actions/client_action_tests.js +++ b/addons/web/static/tests/webclient/actions/client_action_tests.js @@ -10,7 +10,7 @@ import { click, getFixture, legacyExtraNextTick, patchWithCleanup } from "../../ import { createWebClient, doAction, getActionManagerServerData } from "./../helpers"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/webclient/actions/concurrency_tests.js b/addons/web/static/tests/webclient/actions/concurrency_tests.js index 686f3db963f..fbcd632f3a1 100644 --- a/addons/web/static/tests/webclient/actions/concurrency_tests.js +++ b/addons/web/static/tests/webclient/actions/concurrency_tests.js @@ -3,15 +3,19 @@ import { click, getFixture, makeDeferred } from "@web/../tests/helpers/utils"; import { ControlPanel } from "@web/search/control_panel/control_panel"; import { createWebClient, doAction, getActionManagerServerData } from "./../helpers"; -import { isItemSelected, toggleFilterMenu, toggleMenuItem } from "@web/../tests/search/helpers"; +import { + isItemSelected, + toggleFilterMenu, + toggleMenuItem, + switchView, +} from "@web/../tests/search/helpers"; import { legacyExtraNextTick, nextTick } from "../../helpers/utils"; import { registry } from "@web/core/registry"; import testUtils from "web.test_utils"; import { useSetupView } from "@web/views/helpers/view_hook"; -import * as cpHelpers from "@web/../tests/search/helpers"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const actionRegistry = registry.category("actions"); let serverData; @@ -67,11 +71,11 @@ QUnit.module("ActionManager", (hooks) => { const webClient = await createWebClient({ serverData, mockRPC }); await doAction(webClient, 4); // kanban view is loaded, switch to list view - await cpHelpers.switchView(target, "list"); + await switchView(target, "list"); await legacyExtraNextTick(); // here, list view is not ready yet, because def is not resolved // switch back to kanban view - await cpHelpers.switchView(target, "kanban"); + await switchView(target, "kanban"); await legacyExtraNextTick(); // here, we want the kanban view to reload itself, regardless of list view assert.verifySteps([ @@ -415,7 +419,7 @@ QUnit.module("ActionManager", (hooks) => { assert.containsOnce(target, ".o_control_panel .o_list_buttons"); // reload (the search_read RPC will be blocked) def = testUtils.makeTestPromise(); - await cpHelpers.switchView(target, "list"); + await switchView(target, "list"); await legacyExtraNextTick(); assert.containsN(target, ".o_list_view .o_data_row", 5); assert.containsOnce(target, ".o_control_panel .o_list_buttons"); @@ -480,7 +484,7 @@ QUnit.module("ActionManager", (hooks) => { await nextTick(); await legacyExtraNextTick(); assert.containsOnce(target, ".o_list_view", "should still contain the list view"); - await cpHelpers.switchView(target, "kanban"); + await switchView(target, "kanban"); def.resolve(); await testUtils.nextTick(); await legacyExtraNextTick(); @@ -517,7 +521,7 @@ QUnit.module("ActionManager", (hooks) => { doAction(webClient, 4, { clearBreadcrumbs: true }); await testUtils.nextTick(); await legacyExtraNextTick(); - await cpHelpers.switchView(target, "kanban"); + await switchView(target, "kanban"); def.resolve(); await testUtils.nextTick(); await legacyExtraNextTick(); diff --git a/addons/web/static/tests/webclient/actions/error_handling_tests.js b/addons/web/static/tests/webclient/actions/error_handling_tests.js index a29173bd897..a089ad30589 100644 --- a/addons/web/static/tests/webclient/actions/error_handling_tests.js +++ b/addons/web/static/tests/webclient/actions/error_handling_tests.js @@ -7,7 +7,7 @@ import { click, getFixture, nextTick, patchWithCleanup } from "../../helpers/uti import { errorService } from "@web/core/errors/error_service"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/webclient/actions/load_state_tests.js b/addons/web/static/tests/webclient/actions/load_state_tests.js index e85a7d7d8c3..578641f5852 100644 --- a/addons/web/static/tests/webclient/actions/load_state_tests.js +++ b/addons/web/static/tests/webclient/actions/load_state_tests.js @@ -28,7 +28,7 @@ import { import { errorService } from "@web/core/errors/error_service"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/webclient/actions/push_state_tests.js b/addons/web/static/tests/webclient/actions/push_state_tests.js index 23940270a7e..aae69904aa7 100644 --- a/addons/web/static/tests/webclient/actions/push_state_tests.js +++ b/addons/web/static/tests/webclient/actions/push_state_tests.js @@ -14,7 +14,7 @@ import { import { createWebClient, doAction, getActionManagerServerData } from "./../helpers"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/webclient/actions/target_tests.js b/addons/web/static/tests/webclient/actions/target_tests.js index 9eb965901d4..8e3ff86d124 100644 --- a/addons/web/static/tests/webclient/actions/target_tests.js +++ b/addons/web/static/tests/webclient/actions/target_tests.js @@ -19,7 +19,7 @@ import { useService } from "@web/core/utils/hooks"; import { ClientErrorDialog } from "@web/core/errors/error_dialogs"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, onMounted, xml } = owl; +const { onMounted, xml } = owl; let serverData; let target; diff --git a/addons/web/static/tests/webclient/navbar_tests.js b/addons/web/static/tests/webclient/navbar_tests.js index 634bd817e47..55cea8160bf 100644 --- a/addons/web/static/tests/webclient/navbar_tests.js +++ b/addons/web/static/tests/webclient/navbar_tests.js @@ -20,7 +20,7 @@ import { } from "../helpers/utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const systrayRegistry = registry.category("systray"); const serviceRegistry = registry.category("services"); diff --git a/addons/web/static/tests/webclient/user_menu_tests.js b/addons/web/static/tests/webclient/user_menu_tests.js index 331d095ef20..56f8b6466eb 100644 --- a/addons/web/static/tests/webclient/user_menu_tests.js +++ b/addons/web/static/tests/webclient/user_menu_tests.js @@ -17,7 +17,6 @@ const serviceRegistry = registry.category("services"); const userMenuRegistry = registry.category("user_menuitems"); let target; let env; -let userMenu; QUnit.module("UserMenu", { async beforeEach() { @@ -84,7 +83,7 @@ QUnit.test("can be rendered", async (assert) => { }, }; }); - userMenu = await mount(UserMenu, target, { env }); + await mount(UserMenu, target, { env }); assert.containsOnce(target, "img.o_user_avatar"); assert.strictEqual( target.querySelector("img.o_user_avatar").dataset.src, @@ -119,7 +118,7 @@ QUnit.test("can be rendered", async (assert) => { QUnit.test("display the correct name in debug mode", async (assert) => { patchWithCleanup(odoo, { debug: "1" }); env = await makeTestEnv(); - userMenu = await mount(UserMenu, target, { env }); + await mount(UserMenu, target, { env }); assert.containsOnce(target, "img.o_user_avatar"); assert.containsOnce(target, "span.oe_topbar_name"); assert.strictEqual(target.querySelector(".oe_topbar_name").textContent, "Sauron (test)"); @@ -153,7 +152,7 @@ QUnit.test("can execute the callback of settings", async (assert) => { env = await makeTestEnv(testConfig); userMenuRegistry.add("profile", preferencesItem); - userMenu = await mount(UserMenu, target, { env }); + await mount(UserMenu, target, { env }); await click(target.querySelector("button.dropdown-toggle")); assert.containsOnce(target, ".dropdown-menu .dropdown-item"); const item = target.querySelector(".dropdown-menu .dropdown-item"); diff --git a/addons/web/static/tests/webclient/webclient_tests.js b/addons/web/static/tests/webclient/webclient_tests.js index 57911402eff..4395b2bc6fc 100644 --- a/addons/web/static/tests/webclient/webclient_tests.js +++ b/addons/web/static/tests/webclient/webclient_tests.js @@ -15,7 +15,7 @@ import { fakeTitleService } from "../helpers/mock_services"; import { destroy, getFixture, mount, patchWithCleanup, triggerEvent } from "../helpers/utils"; import { LegacyComponent } from "@web/legacy/legacy_component"; -const { Component, xml } = owl; +const { xml } = owl; const mainComponentRegistry = registry.category("main_components"); const serviceRegistry = registry.category("services"); diff --git a/addons/web/tooling/_eslintrc.json b/addons/web/tooling/_eslintrc.json index 79025b0ddf7..7c603e79cf4 100644 --- a/addons/web/tooling/_eslintrc.json +++ b/addons/web/tooling/_eslintrc.json @@ -18,7 +18,8 @@ "no-dupe-class-members": ["error"], "no-unsafe-negation": ["error"], "no-duplicate-imports": ["error"], - "valid-typeof": ["error"] + "valid-typeof": ["error"], + "no-unused-vars": ["error", { "vars": "all", "args": "none", "ignoreRestSiblings": false, "caughtErrors": "none" }] }, "globals": { "odoo": "writable", diff --git a/addons/web_editor/static/src/js/backend/field_html.js b/addons/web_editor/static/src/js/backend/field_html.js index 9b2bdc3bcc7..95e6170f919 100644 --- a/addons/web_editor/static/src/js/backend/field_html.js +++ b/addons/web_editor/static/src/js/backend/field_html.js @@ -273,10 +273,6 @@ var FieldHtml = basic_fields.DebouncedField.extend(TranslatableFieldMixin, { if (this.nodeOptions.notEditable) { return this._renderReadonly(); } - var value = this._textToHtml(this.value); - if (this.nodeOptions.wrapper) { - value = this._wrap(value); - } var fieldNameAttachment = _.chain(this.recordData) .pairs() .find(function (value) { diff --git a/addons/web_editor/static/src/js/common/ace.js b/addons/web_editor/static/src/js/common/ace.js index 460254a5a17..c3ffafae00e 100644 --- a/addons/web_editor/static/src/js/common/ace.js +++ b/addons/web_editor/static/src/js/common/ace.js @@ -1,7 +1,6 @@ odoo.define('web_editor.ace', function (require) { 'use strict'; -var ajax = require('web.ajax'); var config = require('web.config'); var concurrency = require('web.concurrency'); var core = require('web.core'); diff --git a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js index 9fef4c26294..fffb9e02c18 100644 --- a/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js +++ b/addons/web_editor/static/src/js/wysiwyg/wysiwyg.js @@ -1007,7 +1007,6 @@ const Wysiwyg = Widget.extend({ if (!sel.rangeCount) { return; } - const range = sel.getRangeAt(0); // We lose the current selection inside the content editable when we // click the media dialog button so we need to be able to restore the // selection when the modal is closed. diff --git a/addons/web_editor/static/src/js/wysiwyg/wysiwyg_iframe.js b/addons/web_editor/static/src/js/wysiwyg/wysiwyg_iframe.js index 9ac5ab0541a..b52935aa9f4 100644 --- a/addons/web_editor/static/src/js/wysiwyg/wysiwyg_iframe.js +++ b/addons/web_editor/static/src/js/wysiwyg/wysiwyg_iframe.js @@ -7,7 +7,6 @@ var core = require('web.core'); var config = require('web.config'); var qweb = core.qweb; -var promiseCommon; var promiseWysiwyg; diff --git a/addons/web_editor/static/tests/field_html_tests.js b/addons/web_editor/static/tests/field_html_tests.js index f669b52a0dd..907aebbff3d 100644 --- a/addons/web_editor/static/tests/field_html_tests.js +++ b/addons/web_editor/static/tests/field_html_tests.js @@ -10,9 +10,7 @@ var core = require('web.core'); var Wysiwyg = require('web_editor.wysiwyg'); var MediaDialog = require('wysiwyg.widgets.MediaDialog'); var LinkDialog = require('wysiwyg.widgets.LinkDialog'); -var FieldHtml = require('web_editor.field.html'); -const { registerCleanup } = require("@web/../tests/helpers/cleanup"); const { legacyExtraNextTick, patchWithCleanup } = require("@web/../tests/helpers/utils"); var _t = core._t; diff --git a/addons/web_kanban_gauge/static/src/js/kanban_gauge.js b/addons/web_kanban_gauge/static/src/js/kanban_gauge.js index b050c71c735..144b70fb77e 100644 --- a/addons/web_kanban_gauge/static/src/js/kanban_gauge.js +++ b/addons/web_kanban_gauge/static/src/js/kanban_gauge.js @@ -57,12 +57,6 @@ var GaugeWidget = AbstractField.extend({ } max_value = Math.max(gauge_value, max_value); - // label - var label = this.nodeOptions.label || ""; - if (this.nodeOptions.label_field) { - label = this.recordData[this.nodeOptions.label_field]; - } - // title var title = this.nodeOptions.title || this.field.string; diff --git a/addons/web_unsplash/static/src/js/unsplash_image_widget.js b/addons/web_unsplash/static/src/js/unsplash_image_widget.js index 1ee1f1288f5..d01d2d451e4 100644 --- a/addons/web_unsplash/static/src/js/unsplash_image_widget.js +++ b/addons/web_unsplash/static/src/js/unsplash_image_widget.js @@ -3,7 +3,6 @@ odoo.define('web_unsplash.image_widgets', function (require) { var core = require('web.core'); var UnsplashAPI = require('unsplash.api'); -const {UploadProgressToast} = require('@web_editor/js/wysiwyg/widgets/upload_progress_toast'); var widgetsMedia = require('wysiwyg.widgets.media'); const {_t} = require('web.core'); diff --git a/addons/web_unsplash/static/src/js/unsplashapi.js b/addons/web_unsplash/static/src/js/unsplashapi.js index 8156be6c4bc..473a9f37d37 100644 --- a/addons/web_unsplash/static/src/js/unsplashapi.js +++ b/addons/web_unsplash/static/src/js/unsplashapi.js @@ -2,7 +2,6 @@ odoo.define('unsplash.api', function (require) { 'use strict'; var Class = require('web.Class'); -var rpc = require('web.rpc'); var Mixins = require('web.mixins'); var ServicesMixin = require('web.ServicesMixin'); diff --git a/addons/website/static/src/js/content/website_root.js b/addons/website/static/src/js/content/website_root.js index ca21abd52d7..53ab280eafe 100644 --- a/addons/website/static/src/js/content/website_root.js +++ b/addons/website/static/src/js/content/website_root.js @@ -296,7 +296,6 @@ export const WebsiteRoot = publicRootData.PublicRoot.extend(KeyboardNavigationMi return; } - var self = this; var $data = $(ev.currentTarget).parents(".js_publish_management:first"); this._rpc({ route: $data.data('controller') || '/website/publish', diff --git a/addons/website/static/src/js/editor/wysiwyg.js b/addons/website/static/src/js/editor/wysiwyg.js index a8e0bee70a6..038b5385411 100644 --- a/addons/website/static/src/js/editor/wysiwyg.js +++ b/addons/website/static/src/js/editor/wysiwyg.js @@ -3,7 +3,6 @@ odoo.define('website.wysiwyg', function (require) { var Wysiwyg = require('web_editor.wysiwyg'); var snippetsEditor = require('web_editor.snippet.editor'); -const weWidgets = require('wysiwyg.widgets'); /** * Show/hide the dropdowns associated to the given toggles and allows to wait diff --git a/addons/website/static/src/js/menu/new_content.js b/addons/website/static/src/js/menu/new_content.js index 4c63e51d610..3857477b804 100644 --- a/addons/website/static/src/js/menu/new_content.js +++ b/addons/website/static/src/js/menu/new_content.js @@ -106,7 +106,7 @@ var NewContentMenu = websiteNavbarData.WebsiteNavbarActionWidget.extend({ return; } var url = '/website/add/' + encodeURIComponent(val); - const res = wUtils.sendRequest(url, { + wUtils.sendRequest(url, { add_menu: $dialog.find('input[type="checkbox"]').is(':checked') || '', }); return new Promise(function () {}); diff --git a/addons/website/static/src/snippets/s_dynamic_snippet_carousel/000.js b/addons/website/static/src/snippets/s_dynamic_snippet_carousel/000.js index 5d1a5c38e93..6d633729f3d 100644 --- a/addons/website/static/src/snippets/s_dynamic_snippet_carousel/000.js +++ b/addons/website/static/src/snippets/s_dynamic_snippet_carousel/000.js @@ -1,8 +1,6 @@ odoo.define('website.s_dynamic_snippet_carousel', function (require) { 'use strict'; -const config = require('web.config'); -const core = require('web.core'); const publicWidget = require('web.public.widget'); const DynamicSnippet = require('website.s_dynamic_snippet'); diff --git a/addons/website_event/static/src/js/display_timer_widget.js b/addons/website_event/static/src/js/display_timer_widget.js index 5f61273661f..8af998d6c57 100644 --- a/addons/website_event/static/src/js/display_timer_widget.js +++ b/addons/website_event/static/src/js/display_timer_widget.js @@ -1,8 +1,6 @@ odoo.define('website_event.display_timer_widget', function (require) { 'use strict'; -var core = require('web.core'); -var _t = core._t; var publicWidget = require('web.public.widget'); publicWidget.registry.displayTimerWidget = publicWidget.Widget.extend({ diff --git a/addons/website_event/static/src/js/website_event.editor.js b/addons/website_event/static/src/js/website_event.editor.js index 555f6e09373..4b61e93dd88 100644 --- a/addons/website_event/static/src/js/website_event.editor.js +++ b/addons/website_event/static/src/js/website_event.editor.js @@ -216,7 +216,6 @@ var EventCreateDialog = Dialog.extend({ * @private */ _submitForm: function () { - var self = this; var eventValues = this._prepareFormValues(); var errors = this._validateForm(eventValues) console.log(eventValues, errors); diff --git a/addons/website_event_track/static/src/js/service_worker.js b/addons/website_event_track/static/src/js/service_worker.js index 8d15d087bf3..f396edac68f 100644 --- a/addons/website_event_track/static/src/js/service_worker.js +++ b/addons/website_event_track/static/src/js/service_worker.js @@ -11,7 +11,7 @@ const MAX_CACHE_QUOTA = 0.5; // eslint-disable-next-line no-undef const CDN_URL = __ODOO_CDN_URL__; // {string|undefined} the cdn_url configured for the website if activated -const { Store, set, get, del } = idbKeyval; +const { Store, set, get } = idbKeyval; const pendingRequestsQueueName = `${PREFIX}-pending-requests`; const cacheName = `${PREFIX}-cache`; const syncStore = new Store(`${PREFIX}-sync-db`, `${PREFIX}-sync-store`); diff --git a/addons/website_event_track/static/src/js/website_event_pwa_widget.js b/addons/website_event_track/static/src/js/website_event_pwa_widget.js index 2cc986a4771..49b42196b93 100644 --- a/addons/website_event_track/static/src/js/website_event_pwa_widget.js +++ b/addons/website_event_track/static/src/js/website_event_pwa_widget.js @@ -18,7 +18,6 @@ odoo.define("website_event_track.website_event_pwa_widget", function (require) { var config = require("web.config"); var publicWidget = require("web.public.widget"); - var utils = require("web.utils"); var PWAInstallBanner = publicWidget.Widget.extend({ xmlDependencies: ["/website_event_track/static/src/xml/website_event_pwa.xml"], diff --git a/addons/website_event_track_live/static/src/js/website_event_track_live.js b/addons/website_event_track_live/static/src/js/website_event_track_live.js index 241a104befa..89aa4c5d8ff 100644 --- a/addons/website_event_track_live/static/src/js/website_event_track_live.js +++ b/addons/website_event_track_live/static/src/js/website_event_track_live.js @@ -1,6 +1,4 @@ /* global YT */ -var onYouTubeIframeAPIReady; - odoo.define('website_event_track_live.website_event_youtube_embed', function (require) { 'use strict'; @@ -79,7 +77,7 @@ publicWidget.registry.websiteEventTrackLive = publicWidget.Widget.extend({ var $youtubeElement = $('