From bbcff0e777e0f63b80af070da1effba26621e125 Mon Sep 17 00:00:00 2001
From: Antonin Bourguignon <abo@openerp.com>
Date: Wed, 13 Feb 2013 13:09:40 +0100
Subject: [PATCH] [IMP] add a test for get_option_warning()

bzr revid: abo@openerp.com-20130213120940-ycgg7kgfwymav7yn
---
 openerp/addons/base/tests/test_res_config.py | 48 +++++++++++++++-----
 1 file changed, 36 insertions(+), 12 deletions(-)

diff --git a/openerp/addons/base/tests/test_res_config.py b/openerp/addons/base/tests/test_res_config.py
index b1013bf18e8..ee2a753a885 100644
--- a/openerp/addons/base/tests/test_res_config.py
+++ b/openerp/addons/base/tests/test_res_config.py
@@ -1,5 +1,6 @@
 import unittest2
 
+import openerp
 import openerp.tests.common as common
 
 class test_res_config(common.TransactionCase):
@@ -7,11 +8,30 @@ class test_res_config(common.TransactionCase):
     def setUp(self):
         super(test_res_config, self).setUp()
         self.res_config = self.registry('res.config.settings')
+
+        # Define the test values
         self.menu_xml_id = 'base.menu_action_res_users'
         self.full_field_name = 'res.partner.lang'
+        self.error_msg = "WarningRedirect test string: %(field:res.partner.lang)s - %(menu:base.menu_action_res_users)s."
+        # Note: see the get_config_warning() doc for a better example
+
+        # Fetch the expected values
+        module_name, menu_xml_id = self.menu_xml_id.split('.')
+        dummy, menu_id = self.registry('ir.model.data').get_object_reference(self.cr, self.uid, module_name, menu_xml_id)
+        ir_ui_menu = self.registry('ir.ui.menu').browse(self.cr, self.uid, menu_id, context=None)
+
+        model_name, field_name = self.full_field_name.rsplit('.', 1)
+
+        self.expected_path = ir_ui_menu.complete_name
+        self.expected_action_id = ir_ui_menu.action.id
+        self.expected_name = self.registry(model_name).fields_get(self.cr, self.uid, allfields=[field_name], context=None)[field_name]['string']
+        self.expected_final_error_msg = self.error_msg % {
+            'field:res.partner.lang': self.expected_name,
+            'menu:base.menu_action_res_users': self.expected_path
+        }
 
     def test_00_get_option_path(self):
-        """ The get_option_path() should return a tuple containing a string and an integer """
+        """ The get_option_path() method should return a tuple containing a string and an integer """
         res = self.res_config.get_option_path(self.cr, self.uid, self.menu_xml_id, context=None)
 
         # Check types
@@ -21,22 +41,26 @@ class test_res_config(common.TransactionCase):
         self.assertTrue(isinstance(res[1], long)), "The second element of the tuple should be an long (got %s)" % type(res[1])
 
         # Check returned values
-        module_name, menu_xml_id = self.menu_xml_id.split('.')
-        dummy, menu_id = self.registry('ir.model.data').get_object_reference(self.cr, self.uid, module_name, menu_xml_id)
-        ir_ui_menu = self.registry('ir.ui.menu').browse(self.cr, self.uid, menu_id, context=None)
-
-        self.assertTrue(res[0] == ir_ui_menu.complete_name), "Result mismatch: expected %s, got %s" % (ir_ui_menu.complete_name, res[0])
-        self.assertTrue(res[1] == ir_ui_menu.action.id), "Result mismatch: expected %s, got %s" % (ir_ui_menu.action.id, res[1])
+        self.assertTrue(res[0] == self.expected_path), "Result mismatch: expected %s, got %s" % (self.expected_path, res[0])
+        self.assertTrue(res[1] == self.expected_action_id), "Result mismatch: expected %s, got %s" % (self.expected_action_id, res[1])
 
     def test_10_get_option_name(self):
-        """ The get_option_name() should return a string """
+        """ The get_option_name() method should return a string """
         res = self.res_config.get_option_name(self.cr, self.uid, self.full_field_name, context=None)
 
         # Check type
-        self.assertTrue(isinstance(res, basestring)), "The result of get_option_name() should be a basestring (got %s)" % type(res)
+        self.assertTrue(isinstance(res, basestring)), "Result type mismatch: expected basestring, got %s" % type(res)
 
         # Check returned value
-        model_name, field_name = self.full_field_name.rsplit('.', 1)
-        expected_value = self.registry(model_name).fields_get(self.cr, self.uid, allfields=[field_name], context=None)[field_name]['string']
+        self.assertTrue(res == self.expected_name), "Result mismatch: expected %s, got %s" % (self.expected_name, res)
 
-        self.assertTrue(res == expected_value), "Result mismatch: expected %s, got %s" % (res, expected_value)
+    def test_20_get_config_warning(self):
+        """ The get_config_warning() method should return a RedirectWarning exception """
+        res = self.res_config.get_config_warning(self.cr, self.error_msg, context=None)
+
+        # Check type
+        self.assertTrue(isinstance(res, openerp.exceptions.RedirectWarning)), "Result type mismatch: expected RedirectWarning, got %s" % type(res)
+
+        # Check returned value
+        self.assertTrue(res.args[0], self.expected_final_error_msg), "Result mismatch: expected %s, got %s" % (self.expected_final_error_msg, res.args[0])
+        self.assertTrue(res.args[1], self.expected_action_id), "Result mismatch: expected %s, got %s" % (self.expected_action_id, res.args[1])