From bb42687206e61ff3d08d006c2d7c558e38b862ea Mon Sep 17 00:00:00 2001
From: Thibault Francois <tfr@openerp.com>
Date: Tue, 17 Nov 2020 16:27:30 +0000
Subject: [PATCH] [FIX] hr_holidays: Cannot save regular allocation

Problem
-------
For regular allocation that have an empty date_from
(Allocation existing before 14.0),
it's not possible to save any change since an invisible field is required
and cannot be set.

Solution
--------
The field date from should be only required for type accrual

closes odoo/odoo#61892

X-original-commit: 700e584dd22fb7bc845675b4a49a3e5a85a7253a
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
---
 addons/hr_holidays/views/hr_leave_allocation_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/hr_holidays/views/hr_leave_allocation_views.xml b/addons/hr_holidays/views/hr_leave_allocation_views.xml
index edf8a232401..9f5c9ba8020 100644
--- a/addons/hr_holidays/views/hr_leave_allocation_views.xml
+++ b/addons/hr_holidays/views/hr_leave_allocation_views.xml
@@ -163,7 +163,7 @@
             <xpath expr="//field[@name='allocation_type']" position="after">
                 <label for="date_from" attrs="{'invisible': [('allocation_type', '=', 'regular')]}"/>
                 <div class="o_row" attrs="{'invisible': [('allocation_type', '=', 'regular')]}">
-                    <field name="date_from" widget="date" required="1" class="mr-2"/>
+                    <field name="date_from" widget="date" class="mr-2" attrs="{'required': [('allocation_type', '=', 'accrual')]}" />
                     Run until <field name="date_to" help="If no value set, runs indefinitely" class="ml-2" widget="date"/>
                 </div>
                 <label for="date_from" invisible="1"/>