From b994c8c5169792822273131bc446d3582c2e1a2e Mon Sep 17 00:00:00 2001 From: "Abdelouahab (abla)" Date: Tue, 23 May 2023 13:09:49 +0000 Subject: [PATCH] [FIX] analytic: avoid popup overflow To Reproduce ============ - create many analytic plans and link them to an analytic account - create an invoice and add couple of lines, stop when the page becomes scrollable - on the last line click on Analytic, the popup is positioned under the line and we can't reach last plans Problem ======= - according to [getBestPosition](https://github.com/odoo/odoo/blob/16.0/addons/web/static/src/core/position_hook.js#L83), we try different options to position the popup and we take the first one to mach. - in this use-case, the different positions tried by `getBestPosition` are overflowing because of the height of the popup. Solution ======== limit the height of the popup to half size of page opw-3252165 closes odoo/odoo#123542 X-original-commit: 3a7aaa36a487d101a70cb24c3c720a61f50a33ef Signed-off-by: abla001 --- .../components/analytic_distribution/analytic_distribution.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.scss b/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.scss index db3dcfbd807..19bb30a7434 100644 --- a/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.scss +++ b/addons/analytic/static/src/components/analytic_distribution/analytic_distribution.scss @@ -37,6 +37,7 @@ .analytic_distribution_popup { width: 400px; + max-height: 50vh; cursor: default; .o_input {