From b921ee49ae55878ca4161e8b32b9cca16665fd89 Mon Sep 17 00:00:00 2001
From: "Xavier BOL (xbo)" <xbo@odoo.com>
Date: Wed, 18 Jan 2023 10:10:27 +0000
Subject: [PATCH] [FIX] project: fix unexpected behavior due to refactor on
 views

Before this commit, the default group by on task list view in Field
Service app is stage as it is the case in Project app, this behavior is
not wanted, the list view in Field Service app should have no group by
by default. Also, the default group by in My tasks should be personal
stages and no default group by should be in the list view of All Tasks
menu. Finally, the parent task has been removed in the main list view
instead of displaying in debug mode.

This commit fixes the list view in Field Service to avoid having any group
by by default and also changes the default group by `My Tasks` and `All
tasks` menu. It also adds the parent task field in the main list view
of task and that field will be displayed if the "Sub-tasks" feature and
the debug mode is enabled.

X-original-commit: e8aa2177d5640e9c366fa685651de1b85416705c
Part-of: odoo/odoo#111125
---
 addons/project/views/project_views.xml | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/addons/project/views/project_views.xml b/addons/project/views/project_views.xml
index 5d90fce4f94..ed0e363e79e 100644
--- a/addons/project/views/project_views.xml
+++ b/addons/project/views/project_views.xml
@@ -1520,8 +1520,6 @@
             <field name="arch" type="xml">
                 <tree position="attributes">
                     <attribute name="multi_edit">1</attribute>
-                    <attribute name="js_class">project_task_list</attribute>
-                    <attribute name="default_group_by">stage_id</attribute>
                 </tree>
                 <field name="date_deadline" position="after">
                     <field name="activity_ids" string="Next Activity" widget="list_activity" optional="show"/>
@@ -1535,6 +1533,9 @@
                 <tree position="inside">
                     <field name="recurrence_id" invisible="1" />
                 </tree>
+                <xpath expr="//field[@name='partner_id']" position="after">
+                    <field name="parent_id" optional="hide" attrs="{'invisible': [('allow_subtasks', '=', False)]}" groups="base.group_no_one"/>
+                </xpath>
             </field>
         </record>
 
@@ -1546,7 +1547,10 @@
             <field name="mode">primary</field>
             <field name="priority">2</field>
             <field name="arch" type="xml">
-                <tree position="inside"/>
+                <tree position="attributes">
+                    <attribute name="js_class">project_task_list</attribute>
+                    <attribute name="default_group_by">stage_id</attribute>
+                </tree>
             </field>
         </record>
 
@@ -1677,18 +1681,6 @@
             <field name="model">project.task</field>
             <field name="inherit_id" ref="view_task_tree2"/>
             <field name="mode">primary</field>
-            <field name="arch" type="xml">
-                <field name="stage_id" position="replace">
-                    <field name="stage_display" optional="show" string="Stage"/>
-                </field>
-            </field>
-        </record>
-
-        <record id="open_view_all_tasks_list_view" model="ir.ui.view">
-            <field name="name">open.view.all.tasks.list.view</field>
-            <field name="model">project.task</field>
-            <field name="inherit_id" ref="view_task_tree2"/>
-            <field name="mode">primary</field>
             <field name="arch" type="xml">
                 <tree position="attributes">
                     <attribute name="default_group_by">personal_stage_type_ids</attribute>
@@ -1783,7 +1775,7 @@
             <field name="sequence" eval="10"/>
             <field name="view_mode">tree</field>
             <field name="act_window_id" ref="action_view_all_task"/>
-            <field name="view_id" ref="open_view_my_tasks_list_view"/>
+            <field name="view_id" ref="open_view_all_tasks_list_view"/>
         </record>
         <record id="open_view_all_task_list_kanban" model="ir.actions.act_window.view">
             <field name="sequence" eval="20"/>