From b8b450544c4a9ba70e8b2cbc59eacd57e98e8b2f Mon Sep 17 00:00:00 2001
From: Adrien Schoffeniels <adsc@odoo.com>
Date: Mon, 21 Aug 2023 14:36:43 +0200
Subject: [PATCH] [IMP] web: remove hideKanbanOption from properties field

Purpose:
--------
This commit removes the "hideKanbanOption" from the properties field.
This option allowed to prevent users to make properties visible on cards
(kanban cards and calendar popovers).
The rationale being that there is no reason to prevent users of adding
properties on cards now that they have been redesigned (see commit [1]).

Task-3458627

[1]: https://github.com/odoo/odoo/commit/25e8fbe0a1327c289df826cf6eb7882098a4c325

Part-of: odoo/odoo#132578
---
 addons/crm/views/crm_lead_views.xml                            | 2 +-
 addons/event/views/event_registration_views.xml                | 2 +-
 addons/fleet/views/fleet_vehicle_views.xml                     | 2 +-
 addons/project/views/project_task_views.xml                    | 2 +-
 .../web/static/src/views/fields/properties/properties_field.js | 3 ---
 .../static/src/views/fields/properties/property_definition.js  | 1 -
 .../static/src/views/fields/properties/property_definition.xml | 2 +-
 7 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/addons/crm/views/crm_lead_views.xml b/addons/crm/views/crm_lead_views.xml
index a8f3bd2dc6b..0a1908d8778 100644
--- a/addons/crm/views/crm_lead_views.xml
+++ b/addons/crm/views/crm_lead_views.xml
@@ -252,7 +252,7 @@
                             </group>
                         </group>
                         <div class="d-flex">
-                            <field name="lead_properties" nolabel="1" columns="2" hideKanbanOption="1"/>
+                            <field name="lead_properties" nolabel="1" columns="2"/>
                         </div>
                         <notebook>
                             <page string="Internal Notes" name="internal_notes">
diff --git a/addons/event/views/event_registration_views.xml b/addons/event/views/event_registration_views.xml
index 83c5e30a124..3f449457845 100644
--- a/addons/event/views/event_registration_views.xml
+++ b/addons/event/views/event_registration_views.xml
@@ -81,7 +81,7 @@
                             <field name="utm_source_id"/>
                         </group>
                     </group>
-                    <field name="registration_properties" columns="2" hideKanbanOption="1"/>
+                    <field name="registration_properties" columns="2"/>
                 </sheet>
                 <div class="oe_chatter">
                     <field name="message_follower_ids"/>
diff --git a/addons/fleet/views/fleet_vehicle_views.xml b/addons/fleet/views/fleet_vehicle_views.xml
index a736ea658d7..baa2d93a068 100644
--- a/addons/fleet/views/fleet_vehicle_views.xml
+++ b/addons/fleet/views/fleet_vehicle_views.xml
@@ -112,7 +112,7 @@
                         </group>
                     </group>
                     <div class="d-flex">
-                        <field name="vehicle_properties" nolabel="1" columns="2" hideKanbanOption="1"/>
+                        <field name="vehicle_properties" nolabel="1" columns="2"/>
                     </div>
                     <notebook>
                         <page string="Tax Info">
diff --git a/addons/project/views/project_task_views.xml b/addons/project/views/project_task_views.xml
index fa60f33befe..d901458c77d 100644
--- a/addons/project/views/project_task_views.xml
+++ b/addons/project/views/project_task_views.xml
@@ -372,7 +372,7 @@
                         </group>
                     </group>
                     <div class="d-flex">
-                        <field name="task_properties" nolabel="1" columns="2" hideKanbanOption="1"/>
+                        <field name="task_properties" nolabel="1" columns="2"/>
                     </div>
                     <notebook>
                         <page name="description_page" string="Description">
diff --git a/addons/web/static/src/views/fields/properties/properties_field.js b/addons/web/static/src/views/fields/properties/properties_field.js
index 66e6981aa68..6dd421b1089 100644
--- a/addons/web/static/src/views/fields/properties/properties_field.js
+++ b/addons/web/static/src/views/fields/properties/properties_field.js
@@ -31,7 +31,6 @@ export class PropertiesField extends Component {
         context: { type: Object, optional: true },
         columns: { type: Number, optional: true },
         showAddButton: { type: Boolean, optional: true },
-        hideKanbanOption: { type: Boolean, optional: true },
     };
 
     setup() {
@@ -898,7 +897,6 @@ export class PropertiesField extends Component {
             isNewlyCreated: isNewlyCreated,
             propertyIndex: propertyIndex,
             propertiesSize: propertiesList.length,
-            hideKanbanOption: this.props.hideKanbanOption,
         });
     }
 
@@ -943,7 +941,6 @@ export const propertiesField = {
             context: dynamicInfo.context,
             columns: parseInt(attrs.columns || "1"),
             showAddButton: archParseBoolean(attrs.showAddButton),
-            hideKanbanOption: archParseBoolean(attrs.hideKanbanOption),
         };
     },
 };
diff --git a/addons/web/static/src/views/fields/properties/property_definition.js b/addons/web/static/src/views/fields/properties/property_definition.js
index f020c5bcc25..b64a488a540 100644
--- a/addons/web/static/src/views/fields/properties/property_definition.js
+++ b/addons/web/static/src/views/fields/properties/property_definition.js
@@ -401,7 +401,6 @@ PropertyDefinition.props = {
     canChangeDefinition: { type: Boolean, optional: true },
     checkDefinitionWriteAccess: { type: Function, optional: true },
     propertyDefinition: { optional: true },
-    hideKanbanOption: { type: Boolean, optional: true },
     context: { type: Object },
     isNewlyCreated: { type: Boolean, optional: true },
     // index and number of properties, to hide the move arrows when needed
diff --git a/addons/web/static/src/views/fields/properties/property_definition.xml b/addons/web/static/src/views/fields/properties/property_definition.xml
index afdc4795f3a..e6cc9692f4f 100644
--- a/addons/web/static/src/views/fields/properties/property_definition.xml
+++ b/addons/web/static/src/views/fields/properties/property_definition.xml
@@ -156,7 +156,7 @@
                         onChange.bind="onDefaultChange"
                     />
                 </div>
-                <div t-if="!props.hideKanbanOption and state.propertyDefinition.type !== 'separator'"
+                <div t-if="state.propertyDefinition.type !== 'separator'"
                     class="o_field_property_definition_kanban d-contents mb-3 mb-sm-0">
                     <label t-att-for="getUniqueDomID('kanban')" class="o_form_label align-self-center text-900">
                         Display in Cards