From b77cd5ee2093ad1c2bb42fcfdfaa61ebdb8a4384 Mon Sep 17 00:00:00 2001
From: luvi <luvi@odoo.com>
Date: Wed, 27 Jul 2022 07:37:16 +0000
Subject: [PATCH] [FIX] web: ImageUrlField without value

This commit fixes an issue with the ImageUrlField
widget. When no value was given, the image displayed
a broken file instead of being empty. A test
has been added.

closes odoo/odoo#96820

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
---
 .../fields/image_url/image_url_field.xml      |  1 +
 .../views/fields/image_url_field_tests.js     | 26 +++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/addons/web/static/src/views/fields/image_url/image_url_field.xml b/addons/web/static/src/views/fields/image_url/image_url_field.xml
index b10139fc3c3..e28c2252815 100644
--- a/addons/web/static/src/views/fields/image_url/image_url_field.xml
+++ b/addons/web/static/src/views/fields/image_url/image_url_field.xml
@@ -3,6 +3,7 @@
 
     <t t-name="web.ImageUrlField" owl="1">
         <img
+            t-if="props.value"
             class="img img-fluid"
             alt="Image"
             t-att-src="state.src"
diff --git a/addons/web/static/tests/views/fields/image_url_field_tests.js b/addons/web/static/tests/views/fields/image_url_field_tests.js
index 3be54ccd62d..6545ec6f7fe 100644
--- a/addons/web/static/tests/views/fields/image_url_field_tests.js
+++ b/addons/web/static/tests/views/fields/image_url_field_tests.js
@@ -212,4 +212,30 @@ QUnit.module("Fields", (hooks) => {
         await click(target.querySelector(".o_kanban_record"));
         assert.verifySteps(["open record"]);
     });
+
+    QUnit.test("image fields with empty value", async function (assert) {
+        serverData.models.partner.records[0].foo = false;
+
+        await makeView({
+            serverData,
+            type: "form",
+            resModel: "partner",
+            arch: `
+                <form>
+                    <field name="foo" widget="image_url" options="{'size': [90, 90]}"/>
+                </form>`,
+            resId: 1,
+        });
+
+        assert.hasClass(
+            target.querySelector('div[name="foo"].o_field_empty'),
+            "o_field_image_url",
+            "the widget should have the correct class"
+        );
+        assert.containsNone(
+            target,
+            'div[name="foo"] > img',
+            "the widget should not contain an image"
+        );
+    });
 });