From b74ca03bcb7d9aece3c3425b5a675264443167cd Mon Sep 17 00:00:00 2001 From: Joseph Caburnay Date: Wed, 15 Nov 2023 13:24:23 +0100 Subject: [PATCH] [FIX] pos_sale: runbot error 27820 `Orderline.getDisplayData()` relies on the presence of the component's `env`. However, since 7dd76be303b6769767ef0736ba738fc0063a4a28, an `Orderline` instance can be created without `env`, which results to a traceback when rendering the order widget. This commit makes sure the `env` is present in the Orderline instance created from pos_sale module. Closes runbot error: 27820 closes odoo/odoo#142167 Signed-off-by: Vlad Stroia (vlst) --- .../sale_order_management_screen.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/addons/pos_sale/static/src/app/order_management_screen/sale_order_management_screen/sale_order_management_screen.js b/addons/pos_sale/static/src/app/order_management_screen/sale_order_management_screen/sale_order_management_screen.js index 0d2f3b384b9..c8ebd168f64 100644 --- a/addons/pos_sale/static/src/app/order_management_screen/sale_order_management_screen/sale_order_management_screen.js +++ b/addons/pos_sale/static/src/app/order_management_screen/sale_order_management_screen/sale_order_management_screen.js @@ -219,7 +219,7 @@ export class SaleOrderManagementScreen extends ControlButtonsMixin(Component) { sale_order_line_id: line, customer_note: line.customer_note, }; - let new_line = new Orderline({ env: this.env }, line_values); + const new_line = new Orderline({ env: this.env }, line_values); if ( new_line.get_product().tracking !== "none" && @@ -257,12 +257,11 @@ export class SaleOrderManagementScreen extends ControlButtonsMixin(Component) { if (product_unit && !product.get_unit().is_pos_groupable) { //loop for value of quantity for (let j = 0; j < new_line.quantity; j++) { - let splitted_line = new Orderline({}, line_values); + const splitted_line = new Orderline({ env: this.env }, line_values); splitted_line.quantity = 1; this.pos.get_order().add_orderline(splitted_line); } - } - else { + } else { this.pos.get_order().add_orderline(new_line); } }