From b703d3b0c7e6ee85487cfb488070c4a34a0fb075 Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Mon, 30 Dec 2019 13:09:06 +0000 Subject: [PATCH] [FIX] website_mail(_channel): don't use self.env in controller Without this, it will crash since self.env does not exists in a controller. Using request will still crash later since `check_followers` does not exists. Introduced with 957c99abd53b42fa82903ad7ad03300797a706cf Found while working on task-2152191 closes odoo/odoo#42509 X-original-commit: 70e4a716feda7acb7385a98ac51ab40dabc3f50e Signed-off-by: Romain Derie (rde) --- addons/website_mail/controllers/main.py | 2 +- addons/website_mail_channel/controllers/main.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/addons/website_mail/controllers/main.py b/addons/website_mail/controllers/main.py index 5e15faaa294..6d00c064149 100644 --- a/addons/website_mail/controllers/main.py +++ b/addons/website_mail/controllers/main.py @@ -18,7 +18,7 @@ class WebsiteMail(http.Controller): partner_ids = request.env.user.partner_id.ids else: # mail_thread method - partner_ids = [p.id for p in request.env['mail.thread'].sudo()._mail_find_partner_from_emails([email], records=record.sudo(), check_followers=True) if p] + partner_ids = [p.id for p in request.env['mail.thread'].sudo()._mail_find_partner_from_emails([email], records=record.sudo()) if p] if not partner_ids or not partner_ids[0]: name = email.split('@')[0] partner_ids = request.env['res.partner'].sudo().create({'name': name, 'email': email}).ids diff --git a/addons/website_mail_channel/controllers/main.py b/addons/website_mail_channel/controllers/main.py index c51fc8de585..6fcbff984fa 100644 --- a/addons/website_mail_channel/controllers/main.py +++ b/addons/website_mail_channel/controllers/main.py @@ -111,7 +111,7 @@ class MailGroup(http.Controller): else: # public users will recieve confirmation email - partner_ids = [p.id for p in self.env['mail.thread'].sudo()._mail_find_partner_from_emails([email], records=channel.sudo(), check_followers=True) if p] + partner_ids = [p.id for p in request.env['mail.thread'].sudo()._mail_find_partner_from_emails([email], records=channel.sudo()) if p] if not partner_ids or not partner_ids[0]: name = email.split('@')[0] partner_ids = [request.env['res.partner'].sudo().create({'name': name, 'email': email}).id]