From b6bc6453e433fc16bc258b961111d00662dc5b66 Mon Sep 17 00:00:00 2001
From: Swapnesh Shah <swapneshshah111@gmail.com>
Date: Sun, 26 Jul 2020 17:38:14 +0000
Subject: [PATCH] [FIX] website_sale: align abandoned orders count and records

The purpose of the button "Abandoned Carts" on the eCommerce dashboard is to
encourage user to send recovery emails.
Before this commit, the domain wasn't correct as we considered all the
abandoned cart, including the ones which an email was sent.

After this commit, the domain of the filter "Abandoned Carts" took into
consideration the abandoned cart and the carts for whom it is necessary
to send an email.

This commit closes #52799
---
 .../static/src/xml/website_sale_dashboard.xml |  2 +-
 .../website_sale/views/sale_order_views.xml   | 19 -------------------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/addons/website_sale/static/src/xml/website_sale_dashboard.xml b/addons/website_sale/static/src/xml/website_sale_dashboard.xml
index c864b8aa06e..a789021aa8c 100644
--- a/addons/website_sale/static/src/xml/website_sale_dashboard.xml
+++ b/addons/website_sale/static/src/xml/website_sale_dashboard.xml
@@ -15,7 +15,7 @@
                     <div class="o_highlight"><t t-esc="widget.dashboards_data.sales.summary.payment_to_capture_count"/></div>
                     Payments to Capture
                 </div>
-                <div t-if="widget.dashboards_data.sales.summary.order_carts_abandoned_count" class="o_inner_box o_dashboard_action" title="Send a recovery email to visitors who haven't completed their order." name="website_sale.action_abandoned_orders_ecommerce">
+                <div t-if="widget.dashboards_data.sales.summary.order_carts_abandoned_count" class="o_inner_box o_dashboard_action" title="Send a recovery email to visitors who haven't completed their order." name="website_sale.action_view_abandoned_tree">
                     <div class="o_highlight"><t t-esc="widget.dashboards_data.sales.summary.order_carts_abandoned_count"/></div>
                     Abandoned Carts
                 </div>
diff --git a/addons/website_sale/views/sale_order_views.xml b/addons/website_sale/views/sale_order_views.xml
index c252b796e32..fcd38c61c82 100644
--- a/addons/website_sale/views/sale_order_views.xml
+++ b/addons/website_sale/views/sale_order_views.xml
@@ -107,25 +107,6 @@
         </field>
     </record>
 
-    <record id="action_abandoned_orders_ecommerce" model="ir.actions.act_window">
-        <field name="name">Abandoned Carts</field>
-        <field name="res_model">sale.order</field>
-        <field name="view_mode">tree,form,kanban,activity</field>
-        <field name="domain">[('is_abandoned_cart', '=', True)]</field>
-        <field name="context" eval="{'show_sale': True, 'create': False, 'search_default_recovery_email' : 1}"/>
-        <field name="search_view_id" ref="view_sales_order_filter_ecommerce"/>
-        <field name="help" type="html">
-            <p class="o_view_nocontent_empty_folder">
-                No abandoned carts found
-            </p><p>
-                You'll find here all the carts abandoned by your visitors.
-                If they completed their address, you should send them a recovery email!
-            </p><p>
-                The time to mark a cart as abandoned can be changed in the settings.
-            </p>
-        </field>
-    </record>
-
     <record id="sale_order_action_to_invoice" model="ir.actions.act_window">
         <field name="name">Orders To Invoice</field>
         <field name="res_model">sale.order</field>